Re: [BUG? KERNEL 2.6.34-rc5-git5] pccard_validate_cis WARN_ON error

2010-04-28 Thread Dominik Brodowski 
Hey,

On Thu, Apr 29, 2010 at 09:40:46AM +0900, Komuro wrote:
> After issuing the "pccardctl reset",
> I get the WARN_ON error from pccard_validate_cis
> and the card does not work.
> 
> (Megahertz multi-function card)
> 
> 
> WARNING: at drivers/pcmcia/cistpl.c:1488 pccard_validate_cis+0x32/0x2c6()

is a call trace printed? If so, what is it?

Thanks & best,
Dominik

___
Linux PCMCIA reimplementation list
http://lists.infradead.org/mailman/listinfo/linux-pcmcia

[BUG? KERNEL 2.6.34-rc5-git5] pccard_validate_cis WARN_ON error

2010-04-28 Thread Komuro 
Hi,

After issuing the "pccardctl reset",
I get the WARN_ON error from pccard_validate_cis
and the card does not work.

(Megahertz multi-function card)


WARNING: at drivers/pcmcia/cistpl.c:1488 pccard_validate_cis+0x32/0x2c6()


int pccard_validate_cis(struct pcmcia_socket *s, unsigned int *info)
{
tuple_t *tuple;
cisparse_t *p;
unsigned int count = 0;
int ret, reserved, dev_ok = 0, ident_ok = 0;

if (!s)
return -EINVAL;

if (s->functions) {
WARN_ON(1);   <= HERE
return -EINVAL;
}

Best Regards
Komuro


___
Linux PCMCIA reimplementation list
http://lists.infradead.org/mailman/listinfo/linux-pcmcia

Re: [PATCH] pcmcia: fix matching rules for pseudo-multi-function cards

2010-04-28 Thread Komuro 

>here is a fix for the rule to prevent PCMCIA_DEV_ID_MATCH_FUNC_ID entries 
>to match on PFC-cards. e.g. serial_cs PCMCIA_DEVICE_FUNC_ID(2)
>will match on device 0 of a xircom CEM33 card resulting in a
>failure in xirc2ps_cs.
>I changed the code, so that the first matching struct pcmcia_device_id
>_PFC_ entry will mark the card has_pfc, preventing 
>PCMCIA_DEV_ID_MATCH_FUNC_ID to match.
>

OK. works.



___
Linux PCMCIA reimplementation list
http://lists.infradead.org/mailman/listinfo/linux-pcmcia