[BUG] pcmcia: dev_node removal (drivers with unregister_netdev check)

2010-06-06 Thread Komuro 
Dear Dominik

You introduced a bug to smc91c92_cs.c

link->priv = dev;   
  is necessary at smc91c92_probe.


--- a/drivers/net/pcmcia/smc91c92_cs.c
+++ b/drivers/net/pcmcia/smc91c92_cs.c
@@ -103,7 +103,6 @@ struct smc_private {
 u_shortmanfid;
 u_shortcardid;
 
-dev_node_t node;
 struct sk_buff *saved_skb;
 intpackets_waiting;
 void   __iomem *base;
@@ -323,7 +322,6 @@ static int smc91c92_probe(struct pcmcia_device *link)
return -ENOMEM;
 smc = netdev_priv(dev);
 smc->p_dev = link;
-link->priv = dev;<=  HERE. This is necessary!!
 


___
Linux PCMCIA reimplementation list
http://lists.infradead.org/mailman/listinfo/linux-pcmcia

[Bug 16138] PCMCIA regression

2010-06-06 Thread bugzilla-daemon 
https://bugzilla.kernel.org/show_bug.cgi?id=16138


Dominik Brodowski  changed:

   What|Removed |Added

 CC||li...@brodo.de




--- Comment #1 from Dominik Brodowski   2010-06-06 07:14:26 ---
Mikulas, have you had the chance to run the tests I mentioned on lkml already?
If not, here are my comments again:

"
Does this warning appear during reume, or during some other "special" use
case? Also, does commit cc83b08fc791045ac197e6f4a030599bcd7100c5 solve this
issue? If not: Could you enable dynamic debug logging via

# mount debugfs
mount none -t debugfs /sys/kernel/debug/

# enable debug
echo "module pcmcia +p" > /sys/kernel/debug/dynamic_debug/control
echo "module pcmcia_core +p" > /sys/kernel/debug/dynamic_debug/control
echo "module yenta_socket +p" > /sys/kernel/debug/dynamic_debug/control

and send me the resulting log (which may be looong).
"

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

___
Linux PCMCIA reimplementation list
http://lists.infradead.org/mailman/listinfo/linux-pcmcia