Re: linux-next: Tree for August 2 (scsi/pcmcia)

2010-08-02 Thread Dominik Brodowski 
Hey,

On Mon, Aug 02, 2010 at 10:27:07AM -0700, Randy Dunlap wrote:
> pcmcia changes cause these build errors in drivers/scsi/pcmcia/nsp_cs.c:
> 
> drivers/scsi/pcmcia/nsp_cs.c:1907:1: error: unterminated argument list 
> invoking macro "release_region"
> drivers/scsi/pcmcia/nsp_cs.c:1720: error: 'release_region' undeclared (first 
> use in this function)
> drivers/scsi/pcmcia/nsp_cs.c:1720: error: (Each undeclared identifier is 
> reported only once
> drivers/scsi/pcmcia/nsp_cs.c:1720: error: for each function it appears in.)
> drivers/scsi/pcmcia/nsp_cs.c:1720: error: expected ';' at end of input
> drivers/scsi/pcmcia/nsp_cs.c:1720: error: expected declaration or statement 
> at end of input
> drivers/scsi/pcmcia/nsp_cs.c:1720: error: expected declaration or statement 
> at end of input
> drivers/scsi/pcmcia/nsp_cs.c:1720: error: expected declaration or statement 
> at end of input

ah, this driver depends on !x86_64, so my make allmodconfig run didn't catch
it... Thanks!

Should be fixed for the next -next.

Best,
Dominik

___
Linux PCMCIA reimplementation list
http://lists.infradead.org/mailman/listinfo/linux-pcmcia

Re: [PATCH 01/11] pcmcia: use pcmica_{read,write}_config_byte

2010-08-02 Thread Dominik Brodowski 
Hey,

On Mon, Aug 02, 2010 at 08:59:26PM +0900, Komuro wrote:
> >--- a/drivers/net/pcmcia/xirc2ps_cs.c
> >+++ b/drivers/net/pcmcia/xirc2ps_cs.c
> 
> 
> >+if (err)
> > goto config_error;
> >-reg.Action = CS_WRITE;
> >-reg.Offset = CISREG_IOBASE_1;
> >-reg.Value = (link->io.BasePort2 >> 8) & 0xff;
> >-if ((err = pcmcia_access_configuration_register(link, ®)))
> >+
> >+err = pcmcia_write_config_byte(link, CISREG_IOBASE_1,
> >+link->io.BasePort2 & 0xff);
> 
> It should be
> 
>   err = pcmcia_write_config_byte(link, CISREG_IOBASE_1,
>   (link->io.BasePort2 >> 8) & 0xff);
> 

Fixed, thanks.

Best,
Dominik

___
Linux PCMCIA reimplementation list
http://lists.infradead.org/mailman/listinfo/linux-pcmcia

Re: [PATCH 01/11] pcmcia: use pcmica_{read,write}_config_byte

2010-08-02 Thread Komuro 
Hi,

>--- a/drivers/net/pcmcia/xirc2ps_cs.c
>+++ b/drivers/net/pcmcia/xirc2ps_cs.c


>+  if (err)
>   goto config_error;
>-  reg.Action = CS_WRITE;
>-  reg.Offset = CISREG_IOBASE_1;
>-  reg.Value = (link->io.BasePort2 >> 8) & 0xff;
>-  if ((err = pcmcia_access_configuration_register(link, ®)))
>+
>+  err = pcmcia_write_config_byte(link, CISREG_IOBASE_1,
>+  link->io.BasePort2 & 0xff);

It should be

err = pcmcia_write_config_byte(link, CISREG_IOBASE_1,
(link->io.BasePort2 >> 8) & 0xff);




___
Linux PCMCIA reimplementation list
http://lists.infradead.org/mailman/listinfo/linux-pcmcia