Re: [PATCH 18/33] pcmcia: sa1100: provide generic CF support
On Mon, Aug 29, 2016 at 12:25 PM, Russell King
wrote:
> Provide generic non-voltage sensing socket support for StrongARM
> platforms using the gpiolib and regulator subsystems to obtain the
> resources to control the socket.
>
> Signed-off-by: Russell King
(...)
> +static int sa11x0_drv_pcmcia_probe(struct platform_device *pdev)
> +{
> + struct soc_pcmcia_socket *skt;
> + struct device *dev = &pdev->dev;
> +
> + if (dev->id == -1)
> + return sa11x0_drv_pcmcia_legacy_probe(pdev);
There is a typo there, it should be pdev->id rather than dev->id.
After fixing this, my legacy h3600 PCMCIA started probing again.
(It revealed another bug in fetching GPIOs but it is an orthogobal
problem altogether, looking into it.)
Yours,
Linus Walleij
___
Linux PCMCIA reimplementation list
http://lists.infradead.org/mailman/listinfo/linux-pcmcia
Re: [PATCH 18/33] pcmcia: sa1100: provide generic CF support
On Wed, Sep 14, 2016 at 10:52:39AM +0200, Linus Walleij wrote:
> On Mon, Aug 29, 2016 at 12:25 PM, Russell King
> wrote:
>
> > Provide generic non-voltage sensing socket support for StrongARM
> > platforms using the gpiolib and regulator subsystems to obtain the
> > resources to control the socket.
> >
> > Signed-off-by: Russell King
> (...)
>
> > +static int sa11x0_drv_pcmcia_probe(struct platform_device *pdev)
> > +{
> > + struct soc_pcmcia_socket *skt;
> > + struct device *dev = &pdev->dev;
> > +
> > + if (dev->id == -1)
> > + return sa11x0_drv_pcmcia_legacy_probe(pdev);
>
> There is a typo there, it should be pdev->id rather than dev->id.
>
> After fixing this, my legacy h3600 PCMCIA started probing again.
Thanks, I've included a change there, should be part of the branch by
the time you get this email - sa1100 head should be 9ad0f8181616. If
not, it's probably still being pushed out over my slow 'net link.
> (It revealed another bug in fetching GPIOs but it is an orthogobal
> problem altogether, looking into it.)
If you're referring to the generic sa1100 pcmcia code, there's a fix
for that already in my branch.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
___
Linux PCMCIA reimplementation list
http://lists.infradead.org/mailman/listinfo/linux-pcmcia
Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver
On Thu, Sep 8, 2016 at 3:21 PM, Linus Walleij wrote: > On Mon, Sep 5, 2016 at 2:26 PM, Russell King - ARM Linux > wrote: >> On Mon, Sep 05, 2016 at 11:06:28AM +0200, Linus Walleij wrote: >>> I couldn't resist testing on the Compaq iPAQ h3600. It works the >>> same as before so: >>> Tested-by: Linus Walleij [for Compaq iPAQ H3600] >> >> Great news. I've been thinking about digging out my h3600, but it's >> very old, and hasn't been turned on for many years. I'm not sure what >> state it's in. >> >> I've been hoping to try booting some kernels with qemu-system-arm, but >> so far I've completely failed to get qemu-system-arm to do anything >> useful - it just sits there doing apparently nothing, irrespective of >> which platform I choose or which kernel I give it. >> >>> The only news in the bootlog is this: >>> sa11x0-pcmcia: probe of sa11x0-pcmcia failed with error -2 >> >> Not so great news - that's -ENOENT. Did that happen before these >> changes? That could be that the gpiod lookup table isn't found. >> However, if that were the case, I'd have expected an error message >> along the lines of: >> >> Failed to get GPIO for xxx: -nnn >> >> from soc_pcmcia_request_gpiods(). The other possibility is that >> we're not getting to sa11x0_drv_pcmcia_legacy_probe() but instead >> trying to initialise it as a generic sa11x0 socket, and >> sa11x0_pcmcia_hw_init() is failing as a result. >> >> We should be using the legacy probe on H3600, so sa11x0_pcmcia_hw_init() >> should never be reached. > > However that is what happens, this is my callstack after > adding some prints: > > sa11x0_pcmcia_init > sa11x0_drv_pcmcia_probe > soc_pcmcia_init_one > soc_pcmcia_add_one > soc_pcmcia_hw_init > sa11x0_pcmcia_hw_init > soc_pcmcia_add_one: pcmcia HW init failed > sa11x0-pcmcia: probe of sa11x0-pcmcia failed with error -2 Bah I found the cause, just a simple oneliner typo in one of the patches. I will comment on the patch in question so you can fix it up on your branch. Yours, Linus Walleij ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
Re: [PATCH 18/33] pcmcia: sa1100: provide generic CF support
On Wed, Sep 14, 2016 at 11:06 AM, Russell King - ARM Linux wrote: > Thanks, I've included a change there, should be part of the branch by > the time you get this email - sa1100 head should be 9ad0f8181616. If > not, it's probably still being pushed out over my slow 'net link. Thanks, fetched it and tested, this fix is there things work so far. >> (It revealed another bug in fetching GPIOs but it is an orthogobal >> problem altogether, looking into it.) > > If you're referring to the generic sa1100 pcmcia code, there's a fix > for that already in my branch. Unfortunately not, the bug is still there, I'll point it out in the relevant patch, just need to do a boot test. Yours, Linus Walleij ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
Re: [PATCH 10/33] pcmcia: soc_common: switch to using gpio_descs
On Mon, Aug 29, 2016 at 12:24 PM, Russell King
wrote:
> Switch to using the gpiod_* consumer API rather than the legacy API.
>
> Signed-off-by: Russell King
(...)
> +int soc_pcmcia_request_gpiods(struct soc_pcmcia_socket *skt)
> +{
> + int i;
> +
> + for (i = 0; i < ARRAY_SIZE(skt->stat); i++) {
> + struct gpio_desc *desc;
> +
Here I inserted:
/* Skip over unnamed GPIOs, assume unused */
if (!skt->stat[i].name)
continue;
to get it working again on h3600.
> + desc = gpiod_get(skt->socket.dev.parent,
> +skt->stat[i].name, GPIOD_IN);
> + if (IS_ERR(desc)) {
> + dev_err(skt->socket.dev.parent,
> + "Failed to get GPIO for %s: %ld\n",
> + skt->stat[i].name, PTR_ERR(desc));
> + __soc_pcmcia_hw_shutdown(skt, i);
> + return PTR_ERR(desc);
> + }
It bugs out for me on the legacy h3600, since it only defines
two of these pins not all of the ARRAY_SIZE(skt->stat) pins
will succeed and we get an error message like this:
sa11x0-pcmcia sa11x0-pcmcia: Failed to get GPIO for (null): -2
sa11x0-pcmcia: probe of sa11x0-pcmcia failed with error -2
With the patch above it goes away and the log is silent.
The debugfs gpio file looks like this:
cat gpio
gpiochip0: GPIOs 0-27, gpio:
gpio-0 (|Power Button) in hi
gpio-10 (|pcmcia1-detect ) in hi
gpio-11 (|pcmcia1-ready ) in hi
gpio-17 (|pcmcia0-detect ) in hi
gpio-18 (|Action button ) in hi
gpio-21 (|pcmcia0-ready ) in hi
gpio-23 (|dcd ) in hi
gpio-25 (|cts ) in lo
gpio-26 (|rts ) out lo
gpiochip1: GPIOs 28-43, parent: platform/htc-egpio, htc-egpio:
gpio-28 (|Flash Vpp ) out lo
gpio-29 (|PCMCIA CARD RESET ) out lo
gpio-30 (|OPT RESET ) out lo
gpio-32 (|OPT NVRAM ON) out lo
gpio-33 (|OPT ON ) out lo
gpio-34 (|LCD power ) out lo
gpio-36 (|LCD control ) out lo
gpio-42 (|LCD 5v ) out lo
gpio-43 (|LCD 9v/-6.5v) out lo
Which seems like before the patch series.
I still suspect the PCMCIA is not really working but I have
limited experience of the bus so I don't really know how
to test it deeply or have my PCMCIA ethernet or harddrive
probe properly.
There are no regressions however, so with something like
the above patch applied:
Tested-by: Linus Walleij
For the whole patch series on H3600.
Yours,
Linus Walleij
___
Linux PCMCIA reimplementation list
http://lists.infradead.org/mailman/listinfo/linux-pcmcia
Re: [PATCH 10/33] pcmcia: soc_common: switch to using gpio_descs
On Wed, Sep 14, 2016 at 01:29:04PM +0200, Linus Walleij wrote:
> On Mon, Aug 29, 2016 at 12:24 PM, Russell King
> wrote:
>
> > Switch to using the gpiod_* consumer API rather than the legacy API.
> >
> > Signed-off-by: Russell King
> (...)
>
> > +int soc_pcmcia_request_gpiods(struct soc_pcmcia_socket *skt)
> > +{
> > + int i;
> > +
> > + for (i = 0; i < ARRAY_SIZE(skt->stat); i++) {
> > + struct gpio_desc *desc;
> > +
>
> Here I inserted:
>
> /* Skip over unnamed GPIOs, assume unused */
> if (!skt->stat[i].name)
> continue;
>
> to get it working again on h3600.
Thanks, I'll add that.
> > + desc = gpiod_get(skt->socket.dev.parent,
> > +skt->stat[i].name, GPIOD_IN);
> > + if (IS_ERR(desc)) {
> > + dev_err(skt->socket.dev.parent,
> > + "Failed to get GPIO for %s: %ld\n",
> > + skt->stat[i].name, PTR_ERR(desc));
> > + __soc_pcmcia_hw_shutdown(skt, i);
> > + return PTR_ERR(desc);
> > + }
>
>
> It bugs out for me on the legacy h3600, since it only defines
> two of these pins not all of the ARRAY_SIZE(skt->stat) pins
> will succeed and we get an error message like this:
>
> sa11x0-pcmcia sa11x0-pcmcia: Failed to get GPIO for (null): -2
> sa11x0-pcmcia: probe of sa11x0-pcmcia failed with error -2
>
> With the patch above it goes away and the log is silent.
> The debugfs gpio file looks like this:
>
> cat gpio
> gpiochip0: GPIOs 0-27, gpio:
> gpio-0 (|Power Button) in hi
> gpio-10 (|pcmcia1-detect ) in hi
> gpio-11 (|pcmcia1-ready ) in hi
> gpio-17 (|pcmcia0-detect ) in hi
> gpio-18 (|Action button ) in hi
> gpio-21 (|pcmcia0-ready ) in hi
> gpio-23 (|dcd ) in hi
> gpio-25 (|cts ) in lo
> gpio-26 (|rts ) out lo
>
> gpiochip1: GPIOs 28-43, parent: platform/htc-egpio, htc-egpio:
> gpio-28 (|Flash Vpp ) out lo
> gpio-29 (|PCMCIA CARD RESET ) out lo
> gpio-30 (|OPT RESET ) out lo
> gpio-32 (|OPT NVRAM ON) out lo
> gpio-33 (|OPT ON ) out lo
> gpio-34 (|LCD power ) out lo
> gpio-36 (|LCD control ) out lo
> gpio-42 (|LCD 5v ) out lo
> gpio-43 (|LCD 9v/-6.5v) out lo
>
> Which seems like before the patch series.
Yay.
> I still suspect the PCMCIA is not really working but I have
> limited experience of the bus so I don't really know how
> to test it deeply or have my PCMCIA ethernet or harddrive
> probe properly.
Yes, to me the H3600 code looks really really really weird - the way
H3XXX_EGPIO_CARD_RESET is "shared" (badly) between both sockets is
certainly racy. I've no idea what the semantics there are supposed
to be - I suspect that H3600 PCMCIA hasn't worked for a very long
time, or if it has, it's probably not been reliable.
> There are no regressions however, so with something like
> the above patch applied:
> Tested-by: Linus Walleij
>
> For the whole patch series on H3600.
Thanks!
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
___
Linux PCMCIA reimplementation list
http://lists.infradead.org/mailman/listinfo/linux-pcmcia
