[RFC] PCMCIA patches for 2.6.34-rc5 -- 2nd batch
Hey, in order to solve bugzilla bug 13426, and to fix another bug Alexander Kurz tracked down, I intend to submit a pull request for two additional patches tomorrow. They're available at git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia-2.6.git urgent As usual, I'm interested in your input to this patch series. The individual patches will be sent out to the PCMCIA list in a few moments. Best, Dominik Alexander Kurz (1): pcmcia: fix matching rules for pseudo-multi-function cards Dominik Brodowski (1): pcmcia: pcmcia_dev_present bugfix drivers/pcmcia/ds.c | 54 +-- include/pcmcia/ds.h |7 ++--- include/pcmcia/ss.h |8 ++ 3 files changed, 24 insertions(+), 45 deletions(-) ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
Re: [RFC] PCMCIA patches for 2.6.34
Hey, On Mon, Jan 11, 2010 at 11:01:49PM +0100, Wolfram Sang wrote: Knowing now that this is a flaw, I digged up something, check the following call chain in ide_detach from ide-cs.c: ide_release - pcmcia_disable_device - pcmcia_release_io Then(!) release_region is called twice, but the io-resources are gone by now. From what I see, I'd suggest the following patch which makes the warnings go away for me. To me, it looks correct. I just wonder as this seems to have gone unnoticed for quite a while. If you think this rfc is correct, I will create a proper patch out of it and remove the shadowing introduced by fbc69fd9b76158daaa83e5372e44fdd81df20f92. Patch looks proper to me -- nice catch. Best, Dominik ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
Re: [RFC] PCMCIA patches for 2.6.34
On Wed, Jan 06, 2010 at 07:30:27PM +0100, Wolfram Sang wrote: thanks for testing -- I think module insertion removal, combined with card insertion ejection or suspend / resume might be the most likely error path this time; though I couldn't create any issues here on my test box... I did the suggested testing now and everything still behaves like the 2.6.30-distro kernel from Debian. Cool work! This also means, I discovered something I never noticed before. This happens when I remove CF-cards (same for both types I have lying here): [ 150.313371] pcmcia_socket pcmcia_socket0: pccard: PCMCIA card inserted into slot 0 [ 150.314593] pcmcia 0.0: pcmcia: registering new device pcmcia0.0 [ 150.392217] Probing IDE interface ide2... [ 150.667050] hde: SanDisk SDCFH-128, CFA DISK drive [ 151.306831] ide2 at 0xc100-0xc107,0xc10e on irq 11 [ 151.306939] hde: max request size: 128KiB [ 151.306948] hde: 250880 sectors (128 MB) w/1KiB Cache, CHS=980/8/32 [ 151.307042] hde: hde1 [ 151.327094] ide-cs: hde: Vpp = 0.0 [ 154.778843] pcmcia_socket pcmcia_socket0: pccard: card ejected from slot 0 [ 154.779280] Trying to free nonexistent resource c10e-c10e [ 154.779289] Trying to free nonexistent resource c100-c107 The last two lines sound like a problem. Is it known? (I repeat: This is not a regression of your patches, it also happens with 2.6.30.) Ping? (This time without dropped CC :)) Has anyone seen this message? Is it intended? -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
Re: [RFC] PCMCIA patches for 2.6.34
Hi Dominik, here are some patches relating to the PCMCIA subsystem, and intended for 2.6.34. I'm interested in your input to this patch series. They'll be sent to the PCMCIA list shortly, with CC to other lists if deemed Looks interesting, I will pull your master(?)-branch this evening and give it a test. Any hints on what to try/look for especially? Suspend/Resume seems one candidate next to the usual I'll try a bunch of cards... Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
Re: [RFC] PCMCIA patches for 2.6.34
Hey Wolfram, On Wed, Jan 06, 2010 at 03:03:32PM +0100, Wolfram Sang wrote: here are some patches relating to the PCMCIA subsystem, and intended for 2.6.34. I'm interested in your input to this patch series. They'll be sent to the PCMCIA list shortly, with CC to other lists if deemed Looks interesting, I will pull your master(?)-branch this evening and give it a test. Any hints on what to try/look for especially? Suspend/Resume seems one candidate next to the usual I'll try a bunch of cards... It's indeed the master branch, and I added just a few more patches. Many thanks for testing -- I think module insertion removal, combined with card insertion ejection or suspend / resume might be the most likely error path this time; though I couldn't create any issues here on my test box... Best, Dominik ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
Re: [RFC] PCMCIA patches for 2.6.34
thanks for testing -- I think module insertion removal, combined with card insertion ejection or suspend / resume might be the most likely error path this time; though I couldn't create any issues here on my test box... I did the suggested testing now and everything still behaves like the 2.6.30-distro kernel from Debian. Cool work! This also means, I discovered something I never noticed before. This happens when I remove CF-cards (same for both types I have lying here): [ 150.313371] pcmcia_socket pcmcia_socket0: pccard: PCMCIA card inserted into slot 0 [ 150.314593] pcmcia 0.0: pcmcia: registering new device pcmcia0.0 [ 150.392217] Probing IDE interface ide2... [ 150.667050] hde: SanDisk SDCFH-128, CFA DISK drive [ 151.306831] ide2 at 0xc100-0xc107,0xc10e on irq 11 [ 151.306939] hde: max request size: 128KiB [ 151.306948] hde: 250880 sectors (128 MB) w/1KiB Cache, CHS=980/8/32 [ 151.307042] hde: hde1 [ 151.327094] ide-cs: hde: Vpp = 0.0 [ 154.778843] pcmcia_socket pcmcia_socket0: pccard: card ejected from slot 0 [ 154.779280] Trying to free nonexistent resource c10e-c10e [ 154.779289] Trying to free nonexistent resource c100-c107 The last two lines sound like a problem. Is it known? (I repeat: This is not a regression of your patches, it also happens with 2.6.30.) Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc Description: Digital signature ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia
