[2.6 patch] bitmap.h: remove dead artefacts
bitmap_active() no longer exists and BITMAP_ACTIVE is no longer used. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- include/linux/raid/bitmap.h |2 -- 1 file changed, 2 deletions(-) f2c10857c60e13e63c67c656713b50b18f2bc1e4 diff --git a/include/linux/raid/bitmap.h b/include/linux/raid/bitmap.h index 75e17a0..306a1d1 100644 --- a/include/linux/raid/bitmap.h +++ b/include/linux/raid/bitmap.h @@ -138,7 +138,6 @@ typedef __u16 bitmap_counter_t; /* use these for bitmap-flags and bitmap-sb-state bit-fields */ enum bitmap_state { - BITMAP_ACTIVE = 0x001, /* the bitmap is in use */ BITMAP_STALE = 0x002, /* the bitmap file is out of date or had -EIO */ BITMAP_WRITE_ERROR = 0x004, /* A write error has occurred */ BITMAP_HOSTENDIAN = 0x8000, @@ -258,7 +257,6 @@ struct bitmap { int bitmap_create(mddev_t *mddev); void bitmap_flush(mddev_t *mddev); void bitmap_destroy(mddev_t *mddev); -int bitmap_active(struct bitmap *bitmap); char *file_path(struct file *file, char *buf, int count); void bitmap_print_sb(struct bitmap *bitmap); - To unsubscribe from this list: send the line unsubscribe linux-raid in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
multiple xor_block() functions
include/linux/raid/xor.h:extern void xor_block(unsigned int count, unsigned int bytes, void **ptr); drivers/md/xor.c:xor_block(unsigned int count, unsigned int bytes, void **ptr) drivers/md/xor.c:EXPORT_SYMBOL(xor_block); and net/ieee80211/ieee80211_crypt_ccmp.c:static inline void xor_block(u8 * b, u8 * a, size_t len) At least one of them has to be renamed. cu Adrian -- Is there not promise of rain? Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. Only a promise, Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line unsubscribe linux-raid in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: BLK_DEV_MD with CONFIG_NET
On Wed, Mar 21, 2007 at 11:30:24PM +0100, Arnd Bergmann wrote: On Wednesday 21 March 2007 13:02:46 Sam Ravnborg wrote: Anything which is every exported to modules, which ought to be the situation in this case, should be obj-y not lib-y right? That is also my understanding of lib-y - I should update makefiles.txt to reflect this.. Strictly speaking, it could well be obj-m instead of obj-y if it is _only_ used by modules. OTOH, it makes the Makefile a lot simpler to not optimize for this case. No, it is only used by modules only if CONFIG_BLK_DEV_MD=m and CONFIG_NET=n... And except for some legacy drivers, there shouldn't be any module-only code in the kernel. The solution is either obj-y or obj-$(CONFIG_CSUM_PARIAL). Arnd cu Adrian -- Is there not promise of rain? Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. Only a promise, Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line unsubscribe linux-raid in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: 2.6.19.2, cp 18gb_file 18gb_file.2 = OOM killer, 100% reproducible
On Sun, Jan 21, 2007 at 10:54:09AM -0500, Justin Piszcz wrote: On Sun, 21 Jan 2007, [EMAIL PROTECTED] wrote: From: Justin Piszcz [EMAIL PROTECTED] Date: Sat, Jan 20, 2007 at 04:03:42PM -0500 My swap is on, 2GB ram and 2GB of swap on this machine. I can't go back to 2.6.17.13 as it does not recognize the NICs in my machine correctly and the Alsa Intel HD Audio driver has bugs etc, I guess I am stuck with 2.6.19.2 :( Well, if you can't go back, you could always test 2.6.20-rc5. That's why it's out there :-) It can't be any worse! Good luck, Jurriaan -- It might look like I'm doing nothing, but at the cellular level I'm really quite busy. Hans Haas Debian (Unstable) GNU/Linux 2.6.20-rc5 2x2011 bogomips load 1.97 the Jack Vance Integral Edition: http://www.integralarchive.org - To unsubscribe from this list: send the line unsubscribe linux-raid in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html It is worse-- NAT doesn't work and HDDTEMP doesn't work anymore either. Do I understand it correctly from the further emails in this thread that the NAT problem was the known netfilter options mess when upgrading from 2.6.19 to 2.6.20, and enabling some more netfilter options fixed it? hddtemp has a known bug: Subject: `hddtemp' no longer works References : http://lkml.org/lkml/2006/12/14/272 http://bugzilla.kernel.org/show_bug.cgi?id=7581 Submitter : Alistair John Strachan [EMAIL PROTECTED] Nicolas Mailhot [EMAIL PROTECTED] Handled-By : Jens Axboe [EMAIL PROTECTED] Status : bug in hddtemp: http://bugzilla.kernel.org/show_bug.cgi?id=7581 Justin. cu Adrian -- Is there not promise of rain? Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. Only a promise, Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line unsubscribe linux-raid in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
2.6.20-rc6: known unfixed regressions (part 1)
This email lists some known regressions in 2.6.20-rc6 compared to 2.6.19 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly involved with one or more of these issues. Due to the huge amount of recipients, please trim the Cc when answering. Subject: NULL pointer dereference at as_move_to_dispatch() References : http://lkml.org/lkml/2007/1/22/141 Submitter : Andrew Vasquez [EMAIL PROTECTED] Status : unknown Subject: raid1: copying a big file triggers OOM killer References : http://lkml.org/lkml/2007/1/20/69 Submitter : Justin Piszcz [EMAIL PROTECTED] Handled-By : Jens Axboe [EMAIL PROTECTED] Status : problem is being debugged Subject: ext3 with data=journal hangs when running fsx-linux since -rc2 References : http://bugzilla.kernel.org/show_bug.cgi?id=7844 Submitter : Randy Dunlap [EMAIL PROTECTED] Handled-By : Linus Torvalds [EMAIL PROTECTED] Randy Dunlap [EMAIL PROTECTED] Andrew Morton [EMAIL PROTECTED] Status : problem is being debugged Subject: reboot instead of powerdown (CONFIG_USB_SUSPEND) References : http://lkml.org/lkml/2006/12/25/40 http://bugzilla.kernel.org/show_bug.cgi?id=7828 Submitter : Berthold Cogel [EMAIL PROTECTED] François Valenduc [EMAIL PROTECTED] Handled-By : Alan Stern [EMAIL PROTECTED] Status : problem is being debugged Subject: usb somehow broken (CONFIG_USB_SUSPEND) References : http://lkml.org/lkml/2007/1/11/146 Submitter : Prakash Punnoor [EMAIL PROTECTED] Handled-By : Oliver Neukum [EMAIL PROTECTED] Alan Stern [EMAIL PROTECTED] Status : problem is being debugged Subject: fix geode_configure() References : http://lkml.org/lkml/2007/1/9/216 Submitter : Lennart Sorensen [EMAIL PROTECTED] Caused-By : takada [EMAIL PROTECTED] commit e4f0ae0ea63caceff37a13f281a72652b7ea71ba Handled-By : takada [EMAIL PROTECTED] Lennart Sorensen [EMAIL PROTECTED] Status : patches are being discussed - To unsubscribe from this list: send the line unsubscribe linux-raid in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
2.6.20-rc5: known unfixed regressions (v3) (part 1)
This email lists some known regressions in 2.6.20-rc5 compared to 2.6.19 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly involved with one or more of these issues. Due to the huge amount of recipients, please trim the Cc when answering. Subject: raid1: copying a big file triggers OOM killer References : http://lkml.org/lkml/2007/1/20/69 Submitter : Justin Piszcz [EMAIL PROTECTED] Status : unknown Subject: RAID-6 chunk_aligned_read problem References : http://bugzilla.kernel.org/show_bug.cgi?id=7835 Submitter : Duncan [EMAIL PROTECTED] Status : unknown Subject: ext3 with data=journal hangs when running fsx-linux since -rc2 References : http://bugzilla.kernel.org/show_bug.cgi?id=7844 Submitter : Randy Dunlap [EMAIL PROTECTED] Status : unknown Subject: reboot instead of powerdown (CONFIG_USB_SUSPEND) References : http://lkml.org/lkml/2006/12/25/40 http://bugzilla.kernel.org/show_bug.cgi?id=7828 Submitter : Berthold Cogel [EMAIL PROTECTED] François Valenduc [EMAIL PROTECTED] Handled-By : Alexey Starikovskiy [EMAIL PROTECTED] Status : problem is being debugged Subject: usb somehow broken (CONFIG_USB_SUSPEND) References : http://lkml.org/lkml/2007/1/11/146 Submitter : Prakash Punnoor [EMAIL PROTECTED] Handled-By : Oliver Neukum [EMAIL PROTECTED] Alan Stern [EMAIL PROTECTED] Status : problem is being debugged - To unsubscribe from this list: send the line unsubscribe linux-raid in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
2.6.20-rc5: knwon unfixed regressions (v2) (part1)
This email lists some known regressions in 2.6.20-rc5 compared to 2.6.19. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any other way possibly involved with one or more of these issues. Due to the huge amount of recipients, please trim the Cc when answering. Subject: ext3 with data=journal hangs when running fsx-linux since -rc2 References : http://bugzilla.kernel.org/show_bug.cgi?id=7844 Submitter : Randy Dunlap [EMAIL PROTECTED] Status : unknown Subject: reboot instead of powerdown (CONFIG_USB_SUSPEND) References : http://lkml.org/lkml/2006/12/25/40 http://bugzilla.kernel.org/show_bug.cgi?id=7828 Submitter : Berthold Cogel [EMAIL PROTECTED] François Valenduc [EMAIL PROTECTED] Handled-By : Alexey Starikovskiy [EMAIL PROTECTED] Status : problem is being debugged Subject: usb somehow broken (CONFIG_USB_SUSPEND) References : http://lkml.org/lkml/2007/1/11/146 Submitter : Prakash Punnoor [EMAIL PROTECTED] Handled-By : Oliver Neukum [EMAIL PROTECTED] Status : problem is being debugged Subject: RAID-6 chunk_aligned_read problem References : http://bugzilla.kernel.org/show_bug.cgi?id=7835 Submitter : Duncan [EMAIL PROTECTED] Status : unknown Subject: pktcdvd fails with pata_amd References : http://bugzilla.kernel.org/show_bug.cgi?id=7810 Submitter : [EMAIL PROTECTED] Status : unknown Subject: problems with CD burning References : http://www.spinics.net/lists/linux-ide/msg06545.html Submitter : Uwe Bugla [EMAIL PROTECTED] Status : unknown Subject: sata_nv: SATA exceptions References : http://lkml.org/lkml/2007/1/14/108 Submitter : Björn Steinbrink [EMAIL PROTECTED] Caused-By : Robert Hancock [EMAIL PROTECTED] commit 2dec7555e6bf2772749113ea0ad454fcdb8cf861 Handled-By : Robert Hancock [EMAIL PROTECTED] Status : problem is being debugged - To unsubscribe from this list: send the line unsubscribe linux-raid in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC: 2.6 patch] simplify drivers/md/md.c:update_size()
On Thu, Dec 14, 2006 at 07:36:35PM -0500, Doug Ledford wrote: On Fri, 2006-12-15 at 01:19 +0100, Adrian Bunk wrote: While looking at commit 8ddeeae51f2f197b4fafcba117ee8191b49d843e, I got the impression that this commit couldn't fix anything, since the size variable can't be changed before fit gets used. Is there any big thinko, or is the patch below that slightly simplifies update_size() semantically equivalent to the current code? No, this patch is broken. Where it fails is specifically the case where you want to autofit the largest possible size, you have different size devices, and the first device is not the smallest. When you hit the first device, you will set size, then as you repeat the ITERATE_RDEV loop, when you hit the smaller device, size will be non-0 and you'll then trigger the later if and return -ENOSPC. In the case of autofit, you have to preserve the fit variable instead of looking at size so you know whether or not to modify the size when you hit a smaller device later in the list. ... OK, sorry, I've got my thinko: ITERATE_RDEV() is a loop. That's what I missed. cu Adrian -- Is there not promise of rain? Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. Only a promise, Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line unsubscribe linux-raid in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[RFC: 2.6 patch] simplify drivers/md/md.c:update_size()
While looking at commit 8ddeeae51f2f197b4fafcba117ee8191b49d843e, I got the impression that this commit couldn't fix anything, since the size variable can't be changed before fit gets used. Is there any big thinko, or is the patch below that slightly simplifies update_size() semantically equivalent to the current code? Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/md/md.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- linux-2.6.19-mm1/drivers/md/md.c.old2006-12-15 00:57:05.0 +0100 +++ linux-2.6.19-mm1/drivers/md/md.c2006-12-15 00:57:42.0 +0100 @@ -4039,57 +4039,56 @@ * Generate a 128 bit UUID */ get_random_bytes(mddev-uuid, 16); mddev-new_level = mddev-level; mddev-new_chunk = mddev-chunk_size; mddev-new_layout = mddev-layout; mddev-delta_disks = 0; mddev-dead = 0; return 0; } static int update_size(mddev_t *mddev, unsigned long size) { mdk_rdev_t * rdev; int rv; struct list_head *tmp; - int fit = (size == 0); if (mddev-pers-resize == NULL) return -EINVAL; /* The size is the amount of each device that is used. * This can only make sense for arrays with redundancy. * linear and raid0 always use whatever space is available * We can only consider changing the size if no resync * or reconstruction is happening, and if the new size * is acceptable. It must fit before the sb_offset or, * if that is data_offset, it must fit before the * size of each device. * If size is zero, we find the largest size that fits. */ if (mddev-sync_thread) return -EBUSY; ITERATE_RDEV(mddev,rdev,tmp) { sector_t avail; avail = rdev-size * 2; - if (fit (size == 0 || size avail/2)) + if (size == 0) size = avail/2; if (avail ((sector_t)size 1)) return -ENOSPC; } rv = mddev-pers-resize(mddev, (sector_t)size *2); if (!rv) { struct block_device *bdev; bdev = bdget_disk(mddev-gendisk, 0); if (bdev) { mutex_lock(bdev-bd_inode-i_mutex); i_size_write(bdev-bd_inode, (loff_t)mddev-array_size 10); mutex_unlock(bdev-bd_inode-i_mutex); bdput(bdev); } } return rv; } - To unsubscribe from this list: send the line unsubscribe linux-raid in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
FYI: [2.6.16 patch] drivers/md/md.c: update START_ARRAY printk
FYI: I've just committed the patch below in the 2.6.16 tree. cu Adrian commit f919643362f45c65457e01ddd9aed0682497b2f8 Author: Adrian Bunk [EMAIL PROTECTED] Date: Wed Nov 8 08:19:14 2006 +0100 drivers/md/md.c: update START_ARRAY printk START_ARRAY will not be removed in 2.6.16, therefore replace the date reference with a kernel version reference. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] diff --git a/drivers/md/md.c b/drivers/md/md.c index d05e312..78cca0c 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -3662,7 +3662,7 @@ static int md_ioctl(struct inode *inode, if (cnt 0 ) { printk(KERN_WARNING md: %s(pid %d) used deprecated START_ARRAY ioctl. - This will not be supported beyond July 2006\n, + START_ARRAY is removed in kernel 2.6.19 and above.\n, current-comm, current-pid); cnt--; } - To unsubscribe from this list: send the line unsubscribe linux-raid in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH-stable16] Fix a potential NULL dereference in md/raid1
On Mon, Aug 21, 2006 at 02:28:47AM +0200, Adrian Bunk wrote: On Mon, Aug 21, 2006 at 10:07:12AM +1000, Neil Brown wrote: On Monday August 21, [EMAIL PROTECTED] wrote: On Mon, Aug 21, 2006 at 09:50:13AM +1000, NeilBrown wrote: patch for 2.6.16 stable series ... Thanks for this patch. It does also apply against both 2.6.17.9 and Linus' tree. Is it not required in these trees, or are you also submitting it there? I've just sent a patch to [EMAIL PROTECTED] for 2.6.17.9. (it is the same patch with slightly different line numbers). The patch for -linus is quite different and will follow shortly (with a few other patches). OK, I'll apply this patch when it has successfully passed 2.6.17 review and got included in 2.6.17. Applied, thanks for the patch. cu Adrian -- Is there not promise of rain? Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. Only a promise, Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line unsubscribe linux-raid in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH-stable16] Fix a potential NULL dereference in md/raid1
On Mon, Aug 21, 2006 at 09:50:13AM +1000, NeilBrown wrote: patch for 2.6.16 stable series ... Thanks for this patch. It does also apply against both 2.6.17.9 and Linus' tree. Is it not required in these trees, or are you also submitting it there? cu Adrian -- Is there not promise of rain? Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. Only a promise, Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line unsubscribe linux-raid in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH-stable16] Fix a potential NULL dereference in md/raid1
On Mon, Aug 21, 2006 at 10:07:12AM +1000, Neil Brown wrote: On Monday August 21, [EMAIL PROTECTED] wrote: On Mon, Aug 21, 2006 at 09:50:13AM +1000, NeilBrown wrote: patch for 2.6.16 stable series ... Thanks for this patch. It does also apply against both 2.6.17.9 and Linus' tree. Is it not required in these trees, or are you also submitting it there? I've just sent a patch to [EMAIL PROTECTED] for 2.6.17.9. (it is the same patch with slightly different line numbers). The patch for -linus is quite different and will follow shortly (with a few other patches). OK, I'll apply this patch when it has successfully passed 2.6.17 review and got included in 2.6.17. Thanks, NeilBrown cu Adrian -- Is there not promise of rain? Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. Only a promise, Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line unsubscribe linux-raid in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[-mm patch] make variables static after klibc merge
We can now make the following variables static: - drivers/md/md.c: mdp_major - init/main.c: envp_init[] Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- This patch was already sent on: - 16 May 2006 drivers/md/md.c |2 +- init/main.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.17-rc4-mm1-full/drivers/md/md.c.old 2006-05-16 12:49:59.0 +0200 +++ linux-2.6.17-rc4-mm1-full/drivers/md/md.c 2006-05-16 12:50:17.0 +0200 @@ -2563,7 +2563,7 @@ .default_attrs = md_default_attrs, }; -int mdp_major = 0; +static int mdp_major = 0; static struct kobject *md_probe(dev_t dev, int *part, void *data) { --- linux-2.6.17-rc4-mm1-full/init/main.c.old 2006-05-16 13:20:22.0 +0200 +++ linux-2.6.17-rc4-mm1-full/init/main.c 2006-05-16 13:20:43.0 +0200 @@ -161,7 +161,7 @@ __setup(maxcpus=, maxcpus); static char * argv_init[MAX_INIT_ARGS+2] = { init, NULL, }; -char * envp_init[MAX_INIT_ENVS+2] = { HOME=/, TERM=linux, NULL, }; +static char * envp_init[MAX_INIT_ENVS+2] = { HOME=/, TERM=linux, NULL, }; static const char *panic_later, *panic_param; extern struct obs_kernel_param __setup_start[], __setup_end[]; - To unsubscribe from this list: send the line unsubscribe linux-raid in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[-mm patch] make variables static after klibc merge
On Mon, May 15, 2006 at 12:56:37AM -0700, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17-rc4/2.6.17-rc4-mm1/ - This tree contains a large number of new bugs^H^H^H^Hpatches. - klibc (Kernel libc), as git-klibc.patch (Peter Anvin) ... Changes since 2.6.17-rc3-mm1: ... git-klibc.patch ... git trees ... We can now make the following variables static: - drivers/md/md.c: mdp_major - init/main.c: envp_init[] Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/md/md.c |2 +- init/main.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.17-rc4-mm1-full/drivers/md/md.c.old 2006-05-16 12:49:59.0 +0200 +++ linux-2.6.17-rc4-mm1-full/drivers/md/md.c 2006-05-16 12:50:17.0 +0200 @@ -2563,7 +2563,7 @@ .default_attrs = md_default_attrs, }; -int mdp_major = 0; +static int mdp_major = 0; static struct kobject *md_probe(dev_t dev, int *part, void *data) { --- linux-2.6.17-rc4-mm1-full/init/main.c.old 2006-05-16 13:20:22.0 +0200 +++ linux-2.6.17-rc4-mm1-full/init/main.c 2006-05-16 13:20:43.0 +0200 @@ -161,7 +161,7 @@ __setup(maxcpus=, maxcpus); static char * argv_init[MAX_INIT_ARGS+2] = { init, NULL, }; -char * envp_init[MAX_INIT_ENVS+2] = { HOME=/, TERM=linux, NULL, }; +static char * envp_init[MAX_INIT_ENVS+2] = { HOME=/, TERM=linux, NULL, }; static const char *panic_later, *panic_param; extern struct obs_kernel_param __setup_start[], __setup_end[]; - To unsubscribe from this list: send the line unsubscribe linux-raid in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: powerpc: raid6 (raid6int8) compilation error
On Tue, Jan 10, 2006 at 02:28:31PM -0600, Serge E. Hallyn wrote: Since 2.6.15-rc6, and continuing through 2.6.15-mm2, I get the following error when compiling a kernel with gcc 3.4.4 on a power5 with RHEL4U1 installed and uptodate: drivers/md/raid6int8.c: In function `raid6_int8_gen_syndrome': drivers/md/raid6int8.c:185: error: unable to find a register to spill in class `FLOAT_REGS' drivers/md/raid6int8.c:185: error: this is the insn: (insn:HI 619 621 640 4 (set (mem:DI (plus:DI (reg/v/f:DI 122 [ p ]) (reg/v:DI 66 ctr [orig:124 d ] [124])) [0 S8 A64]) (reg/v:DI 129 [ wp0 ])) 320 {*movdi_internal64} (nil) (expr_list:REG_DEAD (reg/v:DI 129 [ wp0 ]) (nil))) drivers/md/raid6int8.c:185: confused by earlier errors, bailing out CC [M] drivers/md/raid6altivec4.o 2.6.14-rc5 does not give this error... ... This is an internal error in gcc. You should report this as a bug in gcc to RedHat. thanks, -serge cu Adrian -- Is there not promise of rain? Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. Only a promise, Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line unsubscribe linux-raid in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[2.6 patch] drivers/md/raid1.c: make a function static
This patch makes a needlessly global function static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- linux-2.6.13-rc6-mm1-full/drivers/md/raid1.c.old2005-08-22 02:50:14.0 +0200 +++ linux-2.6.13-rc6-mm1-full/drivers/md/raid1.c2005-08-22 02:50:31.0 +0200 @@ -1703,7 +1703,7 @@ return 0; } -void raid1_quiesce(mddev_t *mddev, int state) +static void raid1_quiesce(mddev_t *mddev, int state) { conf_t *conf = mddev_to_conf(mddev); - To unsubscribe from this list: send the line unsubscribe linux-raid in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html