[PATCH] RDMA/nes: Remove unused field sent_ts
This patch removes the unused field sent_ts from struct nes_cm_tcp_context.
This patch is part of an effort to clean up instances of timekeeping data-types
like 'struct timeval' which will overflow on 32-bit systems in year 2038 and
beyond.
Signed-off-by: Tina Ruchandani ruchandani.t...@gmail.com
---
drivers/infiniband/hw/nes/nes_cm.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/infiniband/hw/nes/nes_cm.h
b/drivers/infiniband/hw/nes/nes_cm.h
index f522cf6..98948f1 100644
--- a/drivers/infiniband/hw/nes/nes_cm.h
+++ b/drivers/infiniband/hw/nes/nes_cm.h
@@ -279,7 +279,6 @@ struct nes_cm_tcp_context {
u8 rcv_wscale;
struct nes_cm_tsa_context tsa_cntxt;
- struct timevalsent_ts;
};
--
2.2.0.rc0.207.ga3a616c
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] RDMA/nes: Remove unused field sent_ts
On Tuesday 03 February 2015 17:17:47 Tina Ruchandani wrote: This patch removes the unused field sent_ts from struct nes_cm_tcp_context. This patch is part of an effort to clean up instances of timekeeping data-types like 'struct timeval' which will overflow on 32-bit systems in year 2038 and beyond. Signed-off-by: Tina Ruchandani ruchandani.t...@gmail.com Acked-by: Arnd Bergmann a...@arndb.de -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] RDMA/nes: Remove unused field sent_ts
From: Tina Ruchandani [mailto:ruchandani.t...@gmail.com] Sent: Tuesday, February 03, 2015 5:48 AM This patch removes the unused field sent_ts from struct nes_cm_tcp_context. This patch is part of an effort to clean up instances of timekeeping data-types like 'struct timeval' which will overflow on 32-bit systems in year 2038 and beyond. Signed-off-by: Tina Ruchandani ruchandani.t...@gmail.com --- -- 2.2.0.rc0.207.ga3a616c Acked-by: Faisal Latif faisal.la...@intel.com -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] IB/mad: fix ifnullfree.cocci warnings
-Original Message-
From: Wu, Fengguang
Sent: Tuesday, January 27, 2015 1:36 PM
To: Weiny, Ira
Cc: kbuild-...@01.org; Roland Dreier; Hefty, Sean; Hal Rosenstock; Or Gerlitz;
Yan Burman; linux-rdma@vger.kernel.org; linux-ker...@vger.kernel.org
Subject: [PATCH] IB/mad: fix ifnullfree.cocci warnings
drivers/infiniband/core/mad.c:2088:3-8: WARNING: NULL check before freeing
functions like kfree, debugfs_remove, debugfs_remove_recursive or
usb_free_urb is not needed. Maybe consider reorganizing relevant code to
avoid passing NULL values.
NULL check before some freeing functions is not needed.
Based on checkpatch warning
kfree(NULL) is safe this check is probably not required
and kfreeaddr.cocci by Julia Lawall.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
Signed-off-by: Fengguang Wu fengguang...@intel.com
Signed-off-by: Ira Weiny ira.we...@intel.com
---
mad.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/infiniband/core/mad.c
+++ b/drivers/infiniband/core/mad.c
@@ -2084,8 +2084,7 @@ out:
/* Post another receive request for this QP */
if (response) {
ib_mad_post_receive_mads(qp_info, response);
- if (recv)
- kfree(recv);
+ kfree(recv);
} else
ib_mad_post_receive_mads(qp_info, recv); }
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] IB/mad: fix ifnullfree.cocci warnings
drivers/infiniband/core/mad.c:2088:3-8: WARNING: NULL check before
freeing functions like kfree, debugfs_remove, debugfs_remove_recursive
or usb_free_urb is not needed. Maybe consider reorganizing relevant
code to avoid passing NULL values.
NULL check before some freeing functions is not needed.
Based on checkpatch warning
kfree(NULL) is safe this check is probably not required
and kfreeaddr.cocci by Julia Lawall.
Generated by: scripts/coccinelle/free/ifnullfree.cocci
Signed-off-by: Fengguang Wu fengguang...@intel.com
Signed-off-by: Ira Weiny ira.we...@intel.com
Sorry this should have been:
Reviewed-by: Ira Weiny ira.we...@intel.com
Tested-by: Ira Weiny ira.we...@intel.com
---
mad.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--- a/drivers/infiniband/core/mad.c
+++ b/drivers/infiniband/core/mad.c
@@ -2084,8 +2084,7 @@ out:
/* Post another receive request for this QP */
if (response) {
ib_mad_post_receive_mads(qp_info, response);
- if (recv)
- kfree(recv);
+ kfree(recv);
} else
ib_mad_post_receive_mads(qp_info, recv); }
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in the
body
of a message to majord...@vger.kernel.org More majordomo info at
http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL] please pull infiniband.git
Hi Linus, Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git tags/rdma-for-linus Last minute InfiniBand/RDMA changes for 3.19: - Revert IPoIB driver back to 3.18 state. We had a number of fixes go into 3.19, but they introduced regressions. We tried to get everything fixed up but ran out of time, so we'll try again for 3.20. - Similarly, turn off the new extended query port verb. Late in the cycle we realized the ABI is not quite right, and rather than freeze something in a rush and make a mistake, we'll take a bit more time and get it right in 3.20. Haggai Eran (1): IB/core: Temporarily disable ex_query_device uverb Roland Dreier (9): Revert IPoIB: No longer use flush as a parameter Revert IPoIB: Make ipoib_mcast_stop_thread flush the workqueue Revert IPoIB: Use dedicated workqueues per interface Revert IPoIB: change init sequence ordering Revert IPoIB: fix mcast_dev_flush/mcast_restart_task race Revert IPoIB: fix MCAST_FLAG_BUSY usage Revert IPoIB: Make the carrier_on_task race aware Revert IPoIB: Consolidate rtnl_lock tasks in workqueue Merge branches 'ipoib' and 'odp' into for-next drivers/infiniband/core/uverbs_main.c | 1 - drivers/infiniband/ulp/ipoib/ipoib.h | 19 +- drivers/infiniband/ulp/ipoib/ipoib_cm.c| 18 +- drivers/infiniband/ulp/ipoib/ipoib_ib.c| 27 +-- drivers/infiniband/ulp/ipoib/ipoib_main.c | 49 ++--- drivers/infiniband/ulp/ipoib/ipoib_multicast.c | 239 + drivers/infiniband/ulp/ipoib/ipoib_verbs.c | 22 +-- 7 files changed, 134 insertions(+), 241 deletions(-) -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
