Re: [PATCH v2 01/22] staging/rdma/hfi1: Fix regression in send performance
On Wed, Oct 21, 2015 at 04:18:06PM +0300, Dan Carpenter wrote: > On Mon, Oct 19, 2015 at 10:11:16PM -0400, ira.we...@intel.com wrote: > > From: Mike Marciniszyn > > > > This additional call is a regression from qib. For small messages the > > progress > > routine always builds one and clears out the ahg state when the queue has > > gone > > to empty which is the predominant case for small messages. > > > > Inline the routine to mitigate the call and move the routine to qp.h for > > scope > > reasons. > > > > Reviewed-by: Dennis Dalessandro > > Signed-off-by: Mike Marciniszyn > > Signed-off-by: Ira Weiny > > --- > > The whole point of this patch is to do: > > > - if (qp->s_sde) > > + if (qp->s_sde && qp->s_ahgidx >= 0) > > It was not at all clear from the changelog and it was difficult to tell > because we moved code around as well. I've cleaned up the commit message. v3 should be on its way after I make sure I have addressed all your comments on all the patches. Ira > > regards, > dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2195/2195] Staging: rdma: amso1100: Fix multiple assignments on single line.
On Sun, Oct 25, 2015 at 04:50:06AM -0600, Weston Silbaugh wrote: > Multiple assignments should be avoided. > > For example: > > cm_event.ird = cm_event.ord = 128; > > Should be: > > cm_event.ird = 128; > cm_event.ord = 128; > > Signed-off-by: Weston Silbaugh Where are the 2194 other patches in this series? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer
On Sun, Oct 25, 2015 at 12:17 PM, Muhammad Falak R Wani wrote: Please follow standard naming convention for the patches. It should be [PATCH v2 1/4] and not [PATCH 1/4 v2]. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2195/2195] Staging: rdma: amso1100: Fix multiple assignments on single line.
On Sun, Oct 25, 2015 at 12:50 PM, Weston Silbaugh
wrote:
> Multiple assignments should be avoided.
>
> For example:
>
> cm_event.ird = cm_event.ord = 128;
>
> Should be:
>
> cm_event.ird = 128;
> cm_event.ord = 128;
>
> Signed-off-by: Weston Silbaugh
> ---
> drivers/staging/rdma/amso1100/c2_ae.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rdma/amso1100/c2_ae.c
> b/drivers/staging/rdma/amso1100/c2_ae.c
> index eb7a92b..20d98b7 100644
> --- a/drivers/staging/rdma/amso1100/c2_ae.c
> +++ b/drivers/staging/rdma/amso1100/c2_ae.c
> @@ -173,7 +173,8 @@ void c2_ae_event(struct c2_dev *c2dev, u32 mq_index)
> resource_user_context =
> (void *) (unsigned long) wr->ae.ae_generic.user_context;
>
> - status = cm_event.status = c2_convert_cm_status(c2_wr_get_result(wr));
> + status = c2_convert_cm_status(c2_wr_get_result(wr));
> + cm_event.status = c2_convert_cm_status(c2_wr_get_result(wr));
This is wrong fro two reasons:
1. In case of wrong status it will print twice the same error line
"Unable to convert CM status"
2. The better solution will be to rewrite the patch to remove "status
variable" at all.
>
> pr_debug("event received c2_dev=%p, event_id=%d, "
> "resource_indicator=%d, user_context=%p, status = %d\n",
> @@ -294,7 +295,8 @@ void c2_ae_event(struct c2_dev *c2dev, u32 mq_index)
> * Until ird/ord negotiation via MPAv2 support is added, send
> * max supported values
> */
> - cm_event.ird = cm_event.ord = 128;
> + cm_event.ird = 128;
> + cm_event.ord = 128;
>
> if (cm_id->event_handler)
> cm_id->event_handler(cm_id, &cm_event);
> --
> 2.4.3
>
> ___
> devel mailing list
> de...@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2195/2195] Staging: rdma: amso1100: Fix multiple assignments on single line.
Multiple assignments should be avoided.
For example:
cm_event.ird = cm_event.ord = 128;
Should be:
cm_event.ird = 128;
cm_event.ord = 128;
Signed-off-by: Weston Silbaugh
---
drivers/staging/rdma/amso1100/c2_ae.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rdma/amso1100/c2_ae.c
b/drivers/staging/rdma/amso1100/c2_ae.c
index eb7a92b..20d98b7 100644
--- a/drivers/staging/rdma/amso1100/c2_ae.c
+++ b/drivers/staging/rdma/amso1100/c2_ae.c
@@ -173,7 +173,8 @@ void c2_ae_event(struct c2_dev *c2dev, u32 mq_index)
resource_user_context =
(void *) (unsigned long) wr->ae.ae_generic.user_context;
- status = cm_event.status = c2_convert_cm_status(c2_wr_get_result(wr));
+ status = c2_convert_cm_status(c2_wr_get_result(wr));
+ cm_event.status = c2_convert_cm_status(c2_wr_get_result(wr));
pr_debug("event received c2_dev=%p, event_id=%d, "
"resource_indicator=%d, user_context=%p, status = %d\n",
@@ -294,7 +295,8 @@ void c2_ae_event(struct c2_dev *c2dev, u32 mq_index)
* Until ird/ord negotiation via MPAv2 support is added, send
* max supported values
*/
- cm_event.ird = cm_event.ord = 128;
+ cm_event.ird = 128;
+ cm_event.ord = 128;
if (cm_id->event_handler)
cm_id->event_handler(cm_id, &cm_event);
--
2.4.3
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2195/2195] Staging: rdma: amso1100: Fix multiple assignments on single line.
Multiple assignments should be avoided.
For example:
cm_event.ird = cm_event.ord = 128;
Should be:
cm_event.ird = 128;
cm_event.ord = 128;
Signed-off-by: Weston Silbaugh
---
drivers/staging/rdma/amso1100/c2_ae.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rdma/amso1100/c2_ae.c
b/drivers/staging/rdma/amso1100/c2_ae.c
index eb7a92b..20d98b7 100644
--- a/drivers/staging/rdma/amso1100/c2_ae.c
+++ b/drivers/staging/rdma/amso1100/c2_ae.c
@@ -173,7 +173,8 @@ void c2_ae_event(struct c2_dev *c2dev, u32 mq_index)
resource_user_context =
(void *) (unsigned long) wr->ae.ae_generic.user_context;
- status = cm_event.status = c2_convert_cm_status(c2_wr_get_result(wr));
+ status = c2_convert_cm_status(c2_wr_get_result(wr));
+ cm_event.status = c2_convert_cm_status(c2_wr_get_result(wr));
pr_debug("event received c2_dev=%p, event_id=%d, "
"resource_indicator=%d, user_context=%p, status = %d\n",
@@ -294,7 +295,8 @@ void c2_ae_event(struct c2_dev *c2dev, u32 mq_index)
* Until ird/ord negotiation via MPAv2 support is added, send
* max supported values
*/
- cm_event.ird = cm_event.ord = 128;
+ cm_event.ird = 128;
+ cm_event.ord = 128;
if (cm_id->event_handler)
cm_id->event_handler(cm_id, &cm_event);
--
2.4.3
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/3] staging: hfi1: driver: Use setup_timer
Use the timer API function setup_timer instead of init_timer, removing
the structure field assignments.
@timer@
expression e1,e2,e3,fn_ptr;
@@
-init_timer(&e1);
+setup_timer(&e1, fn_ptr, e2);
... when != fn_ptr = e3
-e1.function = fn_ptr;
-e1.data = e2;
Signed-off-by: Muhammad Falak R Wani
---
v2 changes
->make subject line more specific
drivers/staging/rdma/hfi1/driver.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/driver.c
b/drivers/staging/rdma/hfi1/driver.c
index c0a5900..ef4e0c5 100644
--- a/drivers/staging/rdma/hfi1/driver.c
+++ b/drivers/staging/rdma/hfi1/driver.c
@@ -1062,9 +1062,9 @@ void hfi1_set_led_override(struct hfi1_pportdata *ppd,
unsigned int val)
*/
if (atomic_inc_return(&ppd->led_override_timer_active) == 1) {
/* Need to start timer */
- init_timer(&ppd->led_override_timer);
- ppd->led_override_timer.function = run_led_override;
- ppd->led_override_timer.data = (unsigned long) ppd;
+ setup_timer(&ppd->led_override_timer, run_led_override,
+ (unsigned long)ppd);
+
ppd->led_override_timer.expires = jiffies + 1;
add_timer(&ppd->led_override_timer);
} else {
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 3/3] staging: hfi1: sdma: Use setup_timer
Use the timer API function setup_timer instead of init_timer, removing the structure field assignments. Signed-off-by: Muhammad Falak R Wani --- v2 changes ->make subject line more specific drivers/staging/rdma/hfi1/sdma.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rdma/hfi1/sdma.c b/drivers/staging/rdma/hfi1/sdma.c index 63ab721..16d93ff 100644 --- a/drivers/staging/rdma/hfi1/sdma.c +++ b/drivers/staging/rdma/hfi1/sdma.c @@ -1094,10 +1094,8 @@ int sdma_init(struct hfi1_devdata *dd, u8 port) sde->progress_check_head = 0; - init_timer(&sde->err_progress_check_timer); - sde->err_progress_check_timer.function = - sdma_err_progress_check; - sde->err_progress_check_timer.data = (unsigned long)sde; + setup_timer(&sde->err_progress_check_timer, + sdma_err_progress_check, (unsigned long)sde); sde->descq = dma_zalloc_coherent( &dd->pcidev->dev, -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/3] staging: rdma: hfi1: chip: Use setup_timer
Use the timer API function setup_timer instead of init_timer, removing
the structure field assignments.
@timer@
expression e1,e2,e3,fn_ptr;
@@
-init_timer(&e1);
+setup_timer(&e1, fn_ptr, e2);
... when != fn_ptr = e3
-e1.function = fn_ptr;
-e1.data = e2;
Signed-off-by: Muhammad Falak R Wani
---
v2 changes
-> change subject line to be more specific
mfrw
drivers/staging/rdma/hfi1/chip.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rdma/hfi1/chip.c b/drivers/staging/rdma/hfi1/chip.c
index 46ebc38..c403957 100644
--- a/drivers/staging/rdma/hfi1/chip.c
+++ b/drivers/staging/rdma/hfi1/chip.c
@@ -2215,9 +2215,7 @@ static void update_rcverr_timer(unsigned long opaque)
static int init_rcverr(struct hfi1_devdata *dd)
{
- init_timer(&dd->rcverr_timer);
- dd->rcverr_timer.function = update_rcverr_timer;
- dd->rcverr_timer.data = (unsigned long) dd;
+ setup_timer(&dd->rcverr_timer, update_rcverr_timer, (unsigned long)dd);
/* Assume the hardware counter has been reset */
dd->rcv_ovfl_cnt = 0;
return mod_timer(&dd->rcverr_timer, jiffies + HZ * RCVERR_CHECK_TIME);
@@ -8156,9 +8154,8 @@ static int init_cntrs(struct hfi1_devdata *dd)
struct hfi1_pportdata *ppd;
/* set up the stats timer; the add_timer is done at the end */
- init_timer(&dd->synth_stats_timer);
- dd->synth_stats_timer.function = update_synth_timer;
- dd->synth_stats_timer.data = (unsigned long) dd;
+ setup_timer(&dd->synth_stats_timer, update_synth_timer,
+ (unsigned long)dd);
/***/
/* per device counters */
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Create a common verbs transport library
Thanks, we'll look into it today On Fri, Oct 23, 2015 at 11:49 PM, Dennis Dalessandro wrote: > On Thu, Oct 15, 2015 at 05:15:38PM +0300, Moni Shoua wrote: >>> >>> I'm thinking perhaps we'll post some stuff to GitHub and you folks can >>> take >>> a look. We can do some back and forth before even posting patches to the >>> list. I'll check into the logistics and share the details soon? >> >> >> This will be great. Just send us the ref. >> If you'd like we can have an online meeting to have an initial talk. >> From my experience this can be very useful to align all on the >> subject. > > > I have created a branch on a GitHub repo. You can find it at: > https://github.com/weiny2/linux-kernel/tree/rdmavt > > This is a starting point to get the ball rolling. I have a few more patches > to further refine the skeleton rdmavt module. I should be able to post those > early next week. At that point we will have a more clear idea of what the > API between the drivers and rdmavt will need to look like for hfi1 and qib. > We will look for your feedback on how soft roce is going to fit in as well. > > > -Denny > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 2/4 v2] staging: ipath: ipath_init_chip: Use setup_timer
Use of the timer API function setup_timer instead of init_timer, removing
the structure field assignments, and make the codeflow more readable.
The simplified sematic patch used is :-
@timer@
expression e1,e2,e3,fn_ptr;
@@
-init_timer(&e1);
+setup_timer(&e1, fn_ptr, e2);
... when != fn_ptr = e3
-e1.function = fn_ptr;
-e1.data = e2;
Signed-off-by: Muhammad Falak R Wani
---
v2 changes:
-> Change the subject line to a be more specific
mfrw
drivers/staging/rdma/ipath/ipath_init_chip.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rdma/ipath/ipath_init_chip.c
b/drivers/staging/rdma/ipath/ipath_init_chip.c
index 4aea99c..a5eea19 100644
--- a/drivers/staging/rdma/ipath/ipath_init_chip.c
+++ b/drivers/staging/rdma/ipath/ipath_init_chip.c
@@ -950,9 +950,8 @@ int ipath_init_chip(struct ipath_devdata *dd, int reinit)
* set up stats retrieval timer, even if we had errors
* in last portion of setup
*/
- init_timer(&dd->ipath_stats_timer);
- dd->ipath_stats_timer.function = ipath_get_faststats;
- dd->ipath_stats_timer.data = (unsigned long) dd;
+ setup_timer(&dd->ipath_stats_timer, ipath_get_faststats,
+ (unsigned long)dd);
/* every 5 seconds; */
dd->ipath_stats_timer.expires = jiffies + 5 * HZ;
/* takes ~16 seconds to overflow at full IB 4x bandwdith */
@@ -965,9 +964,8 @@ int ipath_init_chip(struct ipath_devdata *dd, int reinit)
ret = setup_sdma(dd);
/* Set up HoL state */
- init_timer(&dd->ipath_hol_timer);
- dd->ipath_hol_timer.function = ipath_hol_event;
- dd->ipath_hol_timer.data = (unsigned long)dd;
+ setup_timer(&dd->ipath_hol_timer, ipath_hol_event, (unsigned long)dd);
+
dd->ipath_hol_state = IPATH_HOL_UP;
done:
@@ -988,11 +986,9 @@ done:
* to an alternate if necessary and possible
*/
if (!reinit) {
- init_timer(&dd->ipath_intrchk_timer);
- dd->ipath_intrchk_timer.function =
- verify_interrupt;
- dd->ipath_intrchk_timer.data =
- (unsigned long) dd;
+ setup_timer(&dd->ipath_intrchk_timer,
+ verify_interrupt,
+ (unsigned long)dd);
}
dd->ipath_intrchk_timer.expires = jiffies + HZ/2;
add_timer(&dd->ipath_intrchk_timer);
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 4/4 v2] staging: ipath: ipath_verbs: Use setup_timer
Use the timer API function setup_timer instead of init_timer, removing the structure field assignments. Signed-off-by: Muhammad Falak R Wani --- v2 changes: -> Change the subject line to a be more specific mfrw drivers/staging/rdma/ipath/ipath_verbs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rdma/ipath/ipath_verbs.c b/drivers/staging/rdma/ipath/ipath_verbs.c index 40f7f05..fa8d02b 100644 --- a/drivers/staging/rdma/ipath/ipath_verbs.c +++ b/drivers/staging/rdma/ipath/ipath_verbs.c @@ -1956,9 +1956,8 @@ static int enable_timer(struct ipath_devdata *dd) dd->ipath_gpio_mask); } - init_timer(&dd->verbs_timer); - dd->verbs_timer.function = __verbs_timer; - dd->verbs_timer.data = (unsigned long)dd; + setup_timer(&dd->verbs_timer, __verbs_timer, (unsigned long)dd); + dd->verbs_timer.expires = jiffies + 1; add_timer(&dd->verbs_timer); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 3/4 v2] staging: ipath: ipath_sdma: Use setup_timer
Use the timer API function setup_timer instead of init_timer, removing the structure field assignments. Signed-off-by: Muhammad Falak R Wani --- v2 changes: -> Change the subject line to a be more specific mfrw drivers/staging/rdma/ipath/ipath_sdma.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rdma/ipath/ipath_sdma.c b/drivers/staging/rdma/ipath/ipath_sdma.c index 17a5177..1ffc06a 100644 --- a/drivers/staging/rdma/ipath/ipath_sdma.c +++ b/drivers/staging/rdma/ipath/ipath_sdma.c @@ -400,9 +400,9 @@ static int alloc_sdma(struct ipath_devdata *dd) } dd->ipath_sdma_head_dma[0] = 0; - init_timer(&dd->ipath_sdma_vl15_timer); - dd->ipath_sdma_vl15_timer.function = vl15_watchdog_timeout; - dd->ipath_sdma_vl15_timer.data = (unsigned long)dd; + setup_timer(&dd->ipath_sdma_vl15_timer, vl15_watchdog_timeout, + (unsigned long)dd); + atomic_set(&dd->ipath_sdma_vl15_count, 0); goto done; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer
Use the timer API function setup_timer instead of init_timer, removing
the structure field assignments.
The simplified semantic patch used is :-
@timer@
expression e1,e2,e3,fn_ptr;
@@
-init_timer(&e1);
+setup_timer(&e1, fn_ptr, e2);
... when != fn_ptr = e3
-e1.function = fn_ptr;
-e1.data = e2;
Signed-off-by: Muhammad Falak R Wani
---
v2 changes:
-> Change the subject line to a be more specific
-> Add details about coccinelle in the commit log
mfrw
drivers/staging/rdma/ipath/ipath_driver.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rdma/ipath/ipath_driver.c
b/drivers/staging/rdma/ipath/ipath_driver.c
index 46d9898..577704a 100644
--- a/drivers/staging/rdma/ipath/ipath_driver.c
+++ b/drivers/staging/rdma/ipath/ipath_driver.c
@@ -2307,10 +2307,9 @@ void ipath_set_led_override(struct ipath_devdata *dd,
unsigned int val)
*/
if (atomic_inc_return(&dd->ipath_led_override_timer_active) == 1) {
/* Need to start timer */
- init_timer(&dd->ipath_led_override_timer);
- dd->ipath_led_override_timer.function =
-ipath_run_led_override;
- dd->ipath_led_override_timer.data = (unsigned long) dd;
+ setup_timer(&dd->ipath_led_override_timer,
+ ipath_run_led_override, (unsigned long)dd);
+
dd->ipath_led_override_timer.expires = jiffies + 1;
add_timer(&dd->ipath_led_override_timer);
} else
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 2/2] staging: IB/ipath: remove sched.h header
On Sat, Oct 24, 2015 at 07:05:32PM -0700, Greg Kroah-Hartman wrote: > On Sun, Oct 18, 2015 at 09:57:09PM +0800, Geliang Tang wrote: > > sched.h header in ipath_*.c is now unnecessary, since I have added > > sched.h in ipath_kernel.h. So remove it. > > Overall, it's best to split this type of thing out, don't "hide" .h > includes in another .h file, so I'm not going to take this patch, sorry. Oh nevermind, your 1/2 patch made this make more sense, sorry for the noise... -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 2/2] staging: IB/ipath: remove sched.h header
On Sun, Oct 18, 2015 at 09:57:09PM +0800, Geliang Tang wrote: > sched.h header in ipath_*.c is now unnecessary, since I have added > sched.h in ipath_kernel.h. So remove it. Overall, it's best to split this type of thing out, don't "hide" .h includes in another .h file, so I'm not going to take this patch, sorry. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/3] staging: rdma: hfi1: Use setup_timer
On Sat, Oct 24, 2015 at 07:58:05AM +0530, Muhammad Falak R Wani wrote: > Use the timer API function setup_timer instead of init_timer, removing > the structure field assignments. > > > > @timer@ > expression e1,e2,e3,fn_ptr; > @@ > -init_timer(&e1); > +setup_timer(&e1, fn_ptr, e2); > ... when != fn_ptr = e3 > -e1.function = fn_ptr; > -e1.data = e2; > > > > Signed-off-by: Muhammad Falak R Wani > --- > drivers/staging/rdma/hfi1/chip.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) Again, 3 patches, all with the same subject, not good :( -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 07/22] staging/rdma/hfi1: Fix sparse error in sdma.h file
On Thu, Oct 22, 2015 at 01:01:25PM +0300, Dan Carpenter wrote: > On Wed, Oct 21, 2015 at 04:29:35PM +, Weiny, Ira wrote: > > > > > > On Mon, Oct 19, 2015 at 10:11:22PM -0400, ira.we...@intel.com wrote: > > > > From: Niranjana Vishwanathapura > > > > > > > > Use NULL instead of 0 for pointer argument to fix the sparse error. > > > > > > > > Reviewed-by: Mike Marciniszyn > > > > Reviewed-by: Mitko Haralanov > > > > Reviewed-by: Dennis Dalessandro > > > > Signed-off-by: Niranjana Vishwanathapura > > > > > > > > Signed-off-by: Ira Weiny > > > > > > This should have just been folded in with the previous patch. Don't > > > introduce > > > problems and fix them in the patchset. > > > > My bad, I will fix in v3. > > I don't think it's worth redoing the patchset over because it's just a > Sparse warning, not a bug. But for the future. No, please redo, the other problems in this series warrent a new series. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4] staging: rdma: ipath: Use setup_timer
On Sat, Oct 24, 2015 at 07:49:28AM +0530, Muhammad Falak R Wani wrote: > Use the timer API function setup_timer instead of init_timer, removing > the structure field assignments. > > > > @timer@ > expression e1,e2,e3,fn_ptr; > @@ > -init_timer(&e1); > +setup_timer(&e1, fn_ptr, e2); > ... when != fn_ptr = e3 > -e1.function = fn_ptr; > -e1.data = e2; > > > > Signed-off-by: Muhammad Falak R Wani > --- > drivers/staging/rdma/ipath/ipath_driver.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) You sent me 4 patches all with the same subject :( Please fix this up and resend. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
