drivers/staging/rdma/hfi1/sdma.c:740: bad if test ?

[David Binderman]

Hello there,

drivers/staging/rdma/hfi1/sdma.c:740:17: warning: logical ‘and’ of mutually 
exclusive tests is always false [-Wlogical-op]

Source code is

    if (count < 64 && count> 32768)
    return SDMA_DESCQ_CNT;

Maybe better code

    if (count < 64 || count> 32768)
    return SDMA_DESCQ_CNT;


Regards

David Binderman

  --
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

infiniband/ulp/srpt/ib_srpt.c:1082: bug report

[David Binderman]

Hello there,

[linux-4.0-rc6/drivers/infiniband/ulp/srpt/ib_srpt.c:1082] -> 
[linux-4.0-rc6/drivers/infiniband/ulp/srpt/ib_srpt.c:1098]: (warning) Possible 
null pointer dereference: ch - otherwise it is redundant to check it against 
null.

    struct ib_device *dev = ch->sport->sdev->device;

...

   BUG_ON(!ch);

Suggest move init of dev until *after* ch has been sanity checked against NULL.

Regards

David Binderman

  --
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html