Re: [PATCH] IB/srpt: Suppress a compiler warning
On 3/30/2015 1:37 PM, Bart Van Assche wrote: Remove a BUG_ON(!ch) statement because it is superfluous - if the ch pointer would be NULL then the assignment in the first line of srpt_map_sg_to_ib_sge() would trigger a kernel oops anyway. This patch suppresses the following compiler warning: Possible null pointer dereference: ch - otherwise it is redundant to check it against null. Reported-by: David Binderman dcb...@hotmail.com Signed-off-by: Bart Van Assche bart.vanass...@sandisk.com --- drivers/infiniband/ulp/srpt/ib_srpt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c index 6e0a477..4e74fc8 100644 --- a/drivers/infiniband/ulp/srpt/ib_srpt.c +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c @@ -1095,7 +1095,6 @@ static int srpt_map_sg_to_ib_sge(struct srpt_rdma_ch *ch, int count, nrdma; int i, j, k; - BUG_ON(!ch); BUG_ON(!ioctx); cmd = ioctx-cmd; dir = cmd-data_direction; Acked-by: Sagi Grimberg sa...@mellanox.com -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] IB/srpt: Suppress a compiler warning
Remove a BUG_ON(!ch) statement because it is superfluous - if the ch pointer would be NULL then the assignment in the first line of srpt_map_sg_to_ib_sge() would trigger a kernel oops anyway. This patch suppresses the following compiler warning: Possible null pointer dereference: ch - otherwise it is redundant to check it against null. Reported-by: David Binderman dcb...@hotmail.com Signed-off-by: Bart Van Assche bart.vanass...@sandisk.com --- drivers/infiniband/ulp/srpt/ib_srpt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c index 6e0a477..4e74fc8 100644 --- a/drivers/infiniband/ulp/srpt/ib_srpt.c +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c @@ -1095,7 +1095,6 @@ static int srpt_map_sg_to_ib_sge(struct srpt_rdma_ch *ch, int count, nrdma; int i, j, k; - BUG_ON(!ch); BUG_ON(!ioctx); cmd = ioctx-cmd; dir = cmd-data_direction; -- 2.1.4 -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
