Re: [PATCH] opensm: make loopback console compile on by default.
On Sun, 24 Jul 2011 05:08:59 -0700 Alex Netes ale...@mellanox.com wrote: Hi Ira, One small issue bellow. [snip] diff --git a/config/osmvsel.m4 b/config/osmvsel.m4 index 2c91f63..87335e3 100644 --- a/config/osmvsel.m4 +++ b/config/osmvsel.m4 @@ -178,28 +178,50 @@ fi # --- END OPENIB_APP_OSMV_CHECK_HEADER --- ]) dnl OPENIB_APP_OSMV_CHECK_HEADER -dnl Check if they want the socket console +dnl Check for socket console support AC_DEFUN([OPENIB_OSM_CONSOLE_SOCKET_SEL], [ # --- BEGIN OPENIB_OSM_CONSOLE_SOCKET_SEL --- +dnl Console over a loopback socket is default if libwrap is available +AC_ARG_ENABLE(console-loopback, +[ --enable-console-loopback Enable a console socket on the loopback interface, requires tcp_wrappers (default yes)], +[case $enableval in + yes) console_loopback=yes ;; + no) console_loopback=no ;; + esac], + console_loopback=yes) + +if test $console_loopback = yes; then +AC_CHECK_LIB(wrap, request_init, [], [console_loopback=no]) I think it's better to print a warning in case -lwrap is missing. Specially when you try to compile with --enable-console-socket and the configure fails telling you that it requires --enable-console-loopback which is on by default. So I suggest something like: +AC_CHECK_LIB(wrap, request_init, [], [console_loopback=no + AC_MSG_WARN(libwrap is missing. console_loopback=no)]) Ok, v3 is on it's way, Ira +fi +if test $console_loopback = yes; then + AC_DEFINE(ENABLE_OSM_CONSOLE_LOOPBACK, + 1, + [Define as 1 if you want to enable a loopback console]) +fi + dnl Console over a socket connection AC_ARG_ENABLE(console-socket, -[ --enable-console-socket Enable a console socket, requires tcp_wrappers (default no)], +[ --enable-console-socket Enable a console socket, requires --enable-console-loopback (default no)], [case $enableval in yes) console_socket=yes ;; no) console_socket=no ;; esac], console_socket=no) if test $console_socket = yes; then - AC_CHECK_LIB(wrap, request_init, [], - AC_MSG_ERROR([request_init() not found. console-socket requires libwrap.])) + if test $console_loopback = no; then +AC_MSG_ERROR([--enable-console-socket requires --enable-console-loopback]) + fi AC_DEFINE(ENABLE_OSM_CONSOLE_SOCKET, 1, [Define as 1 if you want to enable a console on a socket connection]) fi + # --- END OPENIB_OSM_CONSOLE_SOCKET_SEL --- ]) dnl OPENIB_OSM_CONSOLE_SOCKET_SEL + + dnl Check if they want the PerfMgr AC_DEFUN([OPENIB_OSM_PERF_MGR_SEL], [ # --- BEGIN OPENIB_OSM_PERF_MGR_SEL --- diff --git a/include/opensm/osm_console_io.h b/include/opensm/osm_console_io.h index b51cbf7..7bf1313 100644 --- a/include/opensm/osm_console_io.h +++ b/include/opensm/osm_console_io.h @@ -45,8 +45,12 @@ #define OSM_DISABLE_CONSOLE off #define OSM_LOCAL_CONSOLElocal +#ifdef ENABLE_OSM_CONSOLE_SOCKET #define OSM_REMOTE_CONSOLE socket +#endif +#ifdef ENABLE_OSM_CONSOLE_LOOPBACK #define OSM_LOOPBACK_CONSOLE loopback +#endif #define OSM_CONSOLE_NAME OSM Console #define OSM_DEFAULT_CONSOLE OSM_DISABLE_CONSOLE @@ -81,7 +85,7 @@ int osm_console_init(osm_subn_opt_t * opt, osm_console_t * p_oct, osm_log_t * p_ void osm_console_exit(osm_console_t * p_oct, osm_log_t * p_log); int is_console_enabled(osm_subn_opt_t *p_opt); -#ifdef ENABLE_OSM_CONSOLE_SOCKET +#ifdef ENABLE_OSM_CONSOLE_LOOPBACK int cio_open(osm_console_t * p_oct, int new_fd, osm_log_t * p_log); int cio_close(osm_console_t * p_oct, osm_log_t * p_log); int is_authorized(osm_console_t * p_oct); diff --git a/man/opensm.8.in b/man/opensm.8.in index f360739..042bee3 100644 --- a/man/opensm.8.in +++ b/man/opensm.8.in @@ -266,10 +266,13 @@ SMPs. Without -maxsmps, OpenSM defaults to a maximum of 4 outstanding SMPs. .TP -\fB\-console [off | local | socket | loopback]\fR -This option brings up the OpenSM console (default off). -Note that the socket and loopback options will only be available -if OpenSM was built with --enable-console-socket. +\fB\-console [off | local | loopback | socket]\fR +This option brings up the OpenSM console (default off). Note, loopback and +socket open a socket which can be connected to WITHOUT CREDENTIALS. Loopback +is safer if access to your SM host is controlled. tcp_wrappers +(hosts.[allow|deny]) is used with loopback and socket. loopback and socket +will only be available if OpenSM was built with --enable-console-loopback +(default yes) and --enable-console-socket (default no) respectively. .TP \fB\-console-port\fR port Specify an alternate telnet port for the socket console (default 1). diff --git a/opensm/main.c b/opensm/main.c index 798cb20..51c8291 100644 ---
Re: [PATCH] opensm: make loopback console compile on by default.
Hi Ira, One small issue bellow. On 18:17 Wed 13 Jul , Ira Weiny wrote: On Mon, 11 Jul 2011 10:54:42 -0700 Alex Netes ale...@mellanox.com wrote: Hi Ira, On 10:23 Mon 11 Jul , Weiny, Ira K. wrote: On Jul 10, 2011, at 2:14 AM, Alex Netes wrote: Hi Ira, On 15:54 Wed 06 Jul , Ira Weiny wrote: The console is very useful for debugging and should be available in opensm.conf as an option. Generic socket is still an option which is off for security reasons. Signed-off-by: Ira Weiny wei...@llnl.gov --- I was digging a little in a history and one concern that was issued while socket support was introduced is that it requires libwrap devel package, so any one who lacks this package, opensm compilation will fail. My intention was to disable console_looback if libwrap was not available. But as I look at the configure.in I think there may be a bug in that logic. I don't have a system without libwrap readily available so give me some time to fix this. I think though, that lack libwrap support is the only reason that socket support wasn't included by default in the compilation. Because the security threat by using sockets can be easily managed by opensm configuration. So what do you say regarding enabling all socket support during compilation, unless libwrap is unavailable? My fear here is that anyone who configures console socket without properly setting up wrappers will open a huge security hole in their system. By defaulting the compilation to loopback we limit the amount of access which can be configured accidentally. Years ago, Sasha and I discussed a secure console (using libssh). In the end he perfered using ssh directly such as: 17:55:42 ssh hypei telnet localhost 1 Password: Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. OpenSM $ This is where I was heading with this patch. I fixed the check for libwrap. New patch below. Ira Subject: [PATCH V2] opensm: make loopback console compile on by default. The console is very useful for debugging and should be available in opensm.conf as an option. Generic socket is still an option which is off for security reasons. Changes in V2: fix disable loopback when libwrap is not found fix compile when loopback not enabled clean up man page entry Signed-off-by: Ira Weiny wei...@llnl.gov --- config/osmvsel.m4 | 30 ++ include/opensm/osm_console_io.h |6 +- man/opensm.8.in | 11 +++ opensm/main.c | 13 + opensm/osm_console.c|6 +++--- opensm/osm_console_io.c | 23 ++- opensm/osm_subnet.c |9 +++-- 7 files changed, 75 insertions(+), 23 deletions(-) diff --git a/config/osmvsel.m4 b/config/osmvsel.m4 index 2c91f63..87335e3 100644 --- a/config/osmvsel.m4 +++ b/config/osmvsel.m4 @@ -178,28 +178,50 @@ fi # --- END OPENIB_APP_OSMV_CHECK_HEADER --- ]) dnl OPENIB_APP_OSMV_CHECK_HEADER -dnl Check if they want the socket console +dnl Check for socket console support AC_DEFUN([OPENIB_OSM_CONSOLE_SOCKET_SEL], [ # --- BEGIN OPENIB_OSM_CONSOLE_SOCKET_SEL --- +dnl Console over a loopback socket is default if libwrap is available +AC_ARG_ENABLE(console-loopback, +[ --enable-console-loopback Enable a console socket on the loopback interface, requires tcp_wrappers (default yes)], +[case $enableval in + yes) console_loopback=yes ;; + no) console_loopback=no ;; + esac], + console_loopback=yes) + +if test $console_loopback = yes; then +AC_CHECK_LIB(wrap, request_init, [], [console_loopback=no]) I think it's better to print a warning in case -lwrap is missing. Specially when you try to compile with --enable-console-socket and the configure fails telling you that it requires --enable-console-loopback which is on by default. So I suggest something like: +AC_CHECK_LIB(wrap, request_init, [], [console_loopback=no + AC_MSG_WARN(libwrap is missing. console_loopback=no)]) +fi +if test $console_loopback = yes; then + AC_DEFINE(ENABLE_OSM_CONSOLE_LOOPBACK, + 1, + [Define as 1 if you want to enable a loopback console]) +fi + dnl Console over a socket connection AC_ARG_ENABLE(console-socket, -[ --enable-console-socket Enable a console socket, requires tcp_wrappers (default no)], +[ --enable-console-socket Enable a console socket, requires --enable-console-loopback (default no)], [case $enableval in yes) console_socket=yes ;; no) console_socket=no ;; esac], console_socket=no) if test $console_socket = yes; then - AC_CHECK_LIB(wrap, request_init, [], - AC_MSG_ERROR([request_init() not found. console-socket requires
Re: [PATCH] opensm: make loopback console compile on by default.
On Jul 10, 2011, at 2:14 AM, Alex Netes wrote: Hi Ira, On 15:54 Wed 06 Jul , Ira Weiny wrote: The console is very useful for debugging and should be available in opensm.conf as an option. Generic socket is still an option which is off for security reasons. Signed-off-by: Ira Weiny wei...@llnl.gov --- I was digging a little in a history and one concern that was issued while socket support was introduced is that it requires libwrap devel package, so any one who lacks this package, opensm compilation will fail. My intention was to disable console_looback if libwrap was not available. But as I look at the configure.in I think there may be a bug in that logic. I don't have a system without libwrap readily available so give me some time to fix this. Ira -- Alex -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] opensm: make loopback console compile on by default.
Hi Ira, On 15:54 Wed 06 Jul , Ira Weiny wrote: The console is very useful for debugging and should be available in opensm.conf as an option. Generic socket is still an option which is off for security reasons. Signed-off-by: Ira Weiny wei...@llnl.gov --- I was digging a little in a history and one concern that was issued while socket support was introduced is that it requires libwrap devel package, so any one who lacks this package, opensm compilation will fail. -- Alex -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] opensm: make loopback console compile on by default.
The console is very useful for debugging and should be available in opensm.conf as an option. Generic socket is still an option which is off for security reasons. Signed-off-by: Ira Weiny wei...@llnl.gov --- config/osmvsel.m4 | 28 include/opensm/osm_console_io.h |6 +- man/opensm.8.in |8 +--- opensm/main.c | 13 + opensm/osm_console.c|6 +++--- opensm/osm_console_io.c | 19 ++- opensm/osm_subnet.c |9 +++-- 7 files changed, 67 insertions(+), 22 deletions(-) diff --git a/config/osmvsel.m4 b/config/osmvsel.m4 index 2c91f63..4a0c5ab 100644 --- a/config/osmvsel.m4 +++ b/config/osmvsel.m4 @@ -178,28 +178,48 @@ fi # --- END OPENIB_APP_OSMV_CHECK_HEADER --- ]) dnl OPENIB_APP_OSMV_CHECK_HEADER -dnl Check if they want the socket console +dnl Check for socket console support AC_DEFUN([OPENIB_OSM_CONSOLE_SOCKET_SEL], [ # --- BEGIN OPENIB_OSM_CONSOLE_SOCKET_SEL --- +dnl Console over a loopback socket is default if libwrap is available +AC_ARG_ENABLE(console-loopback, +[ --enable-console-loopback Enable a console socket on the loopback interface, requires tcp_wrappers (default yes)], +[case $enableval in + yes) console_loopback=yes ;; + no) console_loopback=no ;; + esac], + console_loopback=yes) + +if test $console_loopback = yes; then +AC_CHECK_LIB(wrap, request_init, [], [console_loopback=no]) + AC_DEFINE(ENABLE_OSM_CONSOLE_LOOPBACK, + 1, + [Define as 1 if you want to enable a loopback console]) +fi + dnl Console over a socket connection AC_ARG_ENABLE(console-socket, -[ --enable-console-socket Enable a console socket, requires tcp_wrappers (default no)], +[ --enable-console-socket Enable a console socket, requires --enable-console-loopback (default no)], [case $enableval in yes) console_socket=yes ;; no) console_socket=no ;; esac], console_socket=no) if test $console_socket = yes; then - AC_CHECK_LIB(wrap, request_init, [], - AC_MSG_ERROR([request_init() not found. console-socket requires libwrap.])) + if test $console_loopback = no; then +AC_MSG_ERROR([--enable-console-socket requires --enable-console-loopback]) + fi AC_DEFINE(ENABLE_OSM_CONSOLE_SOCKET, 1, [Define as 1 if you want to enable a console on a socket connection]) fi + # --- END OPENIB_OSM_CONSOLE_SOCKET_SEL --- ]) dnl OPENIB_OSM_CONSOLE_SOCKET_SEL + + dnl Check if they want the PerfMgr AC_DEFUN([OPENIB_OSM_PERF_MGR_SEL], [ # --- BEGIN OPENIB_OSM_PERF_MGR_SEL --- diff --git a/include/opensm/osm_console_io.h b/include/opensm/osm_console_io.h index b51cbf7..7bf1313 100644 --- a/include/opensm/osm_console_io.h +++ b/include/opensm/osm_console_io.h @@ -45,8 +45,12 @@ #define OSM_DISABLE_CONSOLE off #define OSM_LOCAL_CONSOLElocal +#ifdef ENABLE_OSM_CONSOLE_SOCKET #define OSM_REMOTE_CONSOLE socket +#endif +#ifdef ENABLE_OSM_CONSOLE_LOOPBACK #define OSM_LOOPBACK_CONSOLE loopback +#endif #define OSM_CONSOLE_NAME OSM Console #define OSM_DEFAULT_CONSOLE OSM_DISABLE_CONSOLE @@ -81,7 +85,7 @@ int osm_console_init(osm_subn_opt_t * opt, osm_console_t * p_oct, osm_log_t * p_ void osm_console_exit(osm_console_t * p_oct, osm_log_t * p_log); int is_console_enabled(osm_subn_opt_t *p_opt); -#ifdef ENABLE_OSM_CONSOLE_SOCKET +#ifdef ENABLE_OSM_CONSOLE_LOOPBACK int cio_open(osm_console_t * p_oct, int new_fd, osm_log_t * p_log); int cio_close(osm_console_t * p_oct, osm_log_t * p_log); int is_authorized(osm_console_t * p_oct); diff --git a/man/opensm.8.in b/man/opensm.8.in index f360739..eac004d 100644 --- a/man/opensm.8.in +++ b/man/opensm.8.in @@ -267,9 +267,11 @@ Without -maxsmps, OpenSM defaults to a maximum of 4 outstanding SMPs. .TP \fB\-console [off | local | socket | loopback]\fR -This option brings up the OpenSM console (default off). -Note that the socket and loopback options will only be available -if OpenSM was built with --enable-console-socket. +This option brings up the OpenSM console (default off). Note that loopback and +socket open a socket which can be connected to WITHOUT CREDENTIALS. Loopback +is safer if access to your SM host is controlled. hosts.[allow|deny] can be +used for some control with socket. Note that the socket option will only be +available if OpenSM was built with --enable-console-socket. .TP \fB\-console-port\fR port Specify an alternate telnet port for the socket console (default 1). diff --git a/opensm/main.c b/opensm/main.c index 798cb20..51c8291 100644 --- a/opensm/main.c +++ b/opensm/main.c @@ -270,11 +270,14 @@ static void show_usage(void) Without --maxsmps, OpenSM defaults to a maximum of\n 4 outstanding SMPs.\n\n); printf(--console, -q [off|local +#ifdef ENABLE_OSM_CONSOLE_LOOPBACK + |loopback +#endif
