Re: [PATCH 0/2] InfiniBand-iSER: Refactoring for two function implementations
On Sun, 2015-12-27 at 13:36 +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfr...@users.sourceforge.net> > Date: Sun, 27 Dec 2015 13:12:10 +0100 > Subject: [PATCH 0/2] InfiniBand-iSER: Refactoring for two function > implementations > > I suggest to return directly instead of using the jump label "err" > in two functions (which are working without clean-up there). > > Markus Elfring (2): > One jump label less in iser_reg_sig_mr() > One jump label less in isert_reg_sig_mr() > > drivers/infiniband/ulp/iser/iser_memory.c | 5 ++--- > drivers/infiniband/ulp/isert/ib_isert.c | 7 +++ > 2 files changed, 5 insertions(+), 7 deletions(-) > Doug, are you going to pick these two minor patches up, or shall I..? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/2] InfiniBand-iSER: Refactoring for two function implementations
From: Markus Elfring <elfr...@users.sourceforge.net> Date: Sun, 27 Dec 2015 13:12:10 +0100 Subject: [PATCH 0/2] InfiniBand-iSER: Refactoring for two function implementations I suggest to return directly instead of using the jump label "err" in two functions (which are working without clean-up there). Markus Elfring (2): One jump label less in iser_reg_sig_mr() One jump label less in isert_reg_sig_mr() drivers/infiniband/ulp/iser/iser_memory.c | 5 ++--- drivers/infiniband/ulp/isert/ib_isert.c | 7 +++ 2 files changed, 5 insertions(+), 7 deletions(-) -- 2.6.3 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] InfiniBand-iSER: Refactoring for two function implementations
On Sun, Dec 27, 2015 at 01:36:30PM +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfr...@users.sourceforge.net> > Date: Sun, 27 Dec 2015 13:12:10 +0100 > Subject: [PATCH 0/2] InfiniBand-iSER: Refactoring for two function > implementations Just a note for the future submissions (no need to respin), we are using different subject line: InfiniBand-iSER: --> IB/iser: > > I suggest to return directly instead of using the jump label "err" > in two functions (which are working without clean-up there). > > Markus Elfring (2): > One jump label less in iser_reg_sig_mr() > One jump label less in isert_reg_sig_mr() > > drivers/infiniband/ulp/iser/iser_memory.c | 5 ++--- > drivers/infiniband/ulp/isert/ib_isert.c | 7 +++ > 2 files changed, 5 insertions(+), 7 deletions(-) > > -- > 2.6.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/2] InfiniBand-iSER: Refactoring for two function implementations
On Sun, Dec 27, 2015 at 01:36:30PM +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfr...@users.sourceforge.net> > Date: Sun, 27 Dec 2015 13:12:10 +0100 > Subject: [PATCH 0/2] InfiniBand-iSER: Refactoring for two function > implementations > > I suggest to return directly instead of using the jump label "err" > in two functions (which are working without clean-up there). > > Markus Elfring (2): > One jump label less in iser_reg_sig_mr() > One jump label less in isert_reg_sig_mr() Looks good, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> > > drivers/infiniband/ulp/iser/iser_memory.c | 5 ++--- > drivers/infiniband/ulp/isert/ib_isert.c | 7 +++ > 2 files changed, 5 insertions(+), 7 deletions(-) > > -- > 2.6.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
