RE: [PATCH 02/20] IB/core: Cache device attributes for use by upper level drivers

2015-01-14 Thread Weiny, Ira 
 
 On 1/12/2015 7:10 PM, ira.we...@intel.com wrote:
  From: Ira Weiny ira.we...@intel.com
 
 Please avoid empty change-logs, e.g one liner will perfectly do here.

Done.

  b/include/rdma/ib_verbs.h index 0d74f1d..86fc90f 100644
  --- a/include/rdma/ib_verbs.h
  +++ b/include/rdma/ib_verbs.h
  @@ -1675,6 +1675,7 @@ struct ib_device {
  u32  local_dma_lkey;
  u8   node_type;
  u8   phys_port_cnt;
  +   struct ib_device_attrattributes;
 I think cached_dev_attrs will be better name.

Done for the entire series.

--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 02/20] IB/core: Cache device attributes for use by upper level drivers

2015-01-13 Thread Or Gerlitz 

On 1/12/2015 7:10 PM, ira.we...@intel.com wrote:

From: Ira Weiny ira.we...@intel.com


Please avoid empty change-logs, e.g one liner will perfectly do here.

Signed-off-by: Ira Weiny ira.we...@intel.com
---
  drivers/infiniband/core/device.c |2 ++
  include/rdma/ib_verbs.h  |1 +
  2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
index 18c1ece..3a6afde 100644
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
@@ -294,6 +294,8 @@ int ib_register_device(struct ib_device *device,
spin_lock_init(device-event_handler_lock);
spin_lock_init(device-client_data_lock);
  
+	device-query_device(device, device-attributes);

+
ret = read_port_table_lengths(device);
if (ret) {
printk(KERN_WARNING Couldn't create table lengths cache for device 
%s\n,
diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
index 0d74f1d..86fc90f 100644
--- a/include/rdma/ib_verbs.h
+++ b/include/rdma/ib_verbs.h
@@ -1675,6 +1675,7 @@ struct ib_device {
u32  local_dma_lkey;
u8   node_type;
u8   phys_port_cnt;
+   struct ib_device_attrattributes;

I think cached_dev_attrs will be better name.

--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 02/20] IB/core: Cache device attributes for use by upper level drivers

2015-01-12 Thread ira . weiny 
From: Ira Weiny ira.we...@intel.com

Signed-off-by: Ira Weiny ira.we...@intel.com
---
 drivers/infiniband/core/device.c |2 ++
 include/rdma/ib_verbs.h  |1 +
 2 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
index 18c1ece..3a6afde 100644
--- a/drivers/infiniband/core/device.c
+++ b/drivers/infiniband/core/device.c
@@ -294,6 +294,8 @@ int ib_register_device(struct ib_device *device,
spin_lock_init(device-event_handler_lock);
spin_lock_init(device-client_data_lock);
 
+   device-query_device(device, device-attributes);
+
ret = read_port_table_lengths(device);
if (ret) {
printk(KERN_WARNING Couldn't create table lengths cache for 
device %s\n,
diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
index 0d74f1d..86fc90f 100644
--- a/include/rdma/ib_verbs.h
+++ b/include/rdma/ib_verbs.h
@@ -1675,6 +1675,7 @@ struct ib_device {
u32  local_dma_lkey;
u8   node_type;
u8   phys_port_cnt;
+   struct ib_device_attrattributes;
 };
 
 struct ib_client {
-- 
1.7.1

--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html