Re: [PATCH v2 01/36] IB/rdmavt: Create module framework and handle driver registration
On Mon, Dec 28, 2015 at 12:59:45PM -0800, Dennis Dalessandro wrote: > This patch introduces the basics for a new module called rdma_vt. This new > driver is a software implementation of the InfiniBand verbs and aims to > replace the multiple implementations that exist and duplicate each others' > code. > > While the call to actually register the device with the IB core happens in > rdma_vt, most of the work is still done in the drivers themselves. This > will be changing in a follow on patch this is just laying the groundwork > for this infrastructure. > > Reviewed-by: Ira Weiny > Reviewed-by: Mike Marciniszyn > Signed-off-by: Dennis Dalessandro > --- > Changes since v1: > remove rdmavt specific driver version > move copyright above license text > > MAINTAINERS |6 ++ > drivers/infiniband/Kconfig|2 + > drivers/infiniband/Makefile |1 > drivers/infiniband/sw/Makefile|1 > drivers/infiniband/sw/rdmavt/Kconfig |6 ++ > drivers/infiniband/sw/rdmavt/Makefile | 10 > drivers/infiniband/sw/rdmavt/vt.c | 83 > + > drivers/infiniband/sw/rdmavt/vt.h | 53 + > include/rdma/rdma_vt.h| 70 > 9 files changed, 232 insertions(+), 0 deletions(-) > create mode 100644 drivers/infiniband/sw/Makefile > create mode 100644 drivers/infiniband/sw/rdmavt/Kconfig > create mode 100644 drivers/infiniband/sw/rdmavt/Makefile > create mode 100644 drivers/infiniband/sw/rdmavt/vt.c > create mode 100644 drivers/infiniband/sw/rdmavt/vt.h > create mode 100644 include/rdma/rdma_vt.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index 69c8a9c..37fc192 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -8880,6 +8880,12 @@ L: rds-de...@oss.oracle.com (moderated for > non-subscribers) > S: Supported > F: net/rds/ > > +RDMAVT - RDMA verbs software > +M: Dennis Dalessandro > +L: linux-rdma@vger.kernel.org > +S: Supported > +F: drivers/infiniband/sw/rdmavt > + > READ-COPY UPDATE (RCU) > M: "Paul E. McKenney" > M: Josh Triplett > diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig > index aa26f3c..1b00bb8 100644 > --- a/drivers/infiniband/Kconfig > +++ b/drivers/infiniband/Kconfig > @@ -72,4 +72,6 @@ source "drivers/infiniband/ulp/srpt/Kconfig" > source "drivers/infiniband/ulp/iser/Kconfig" > source "drivers/infiniband/ulp/isert/Kconfig" > > +source "drivers/infiniband/sw/rdmavt/Kconfig" > + > endif # INFINIBAND > diff --git a/drivers/infiniband/Makefile b/drivers/infiniband/Makefile > index dc21836..fad0b44 100644 > --- a/drivers/infiniband/Makefile > +++ b/drivers/infiniband/Makefile > @@ -1,3 +1,4 @@ > obj-$(CONFIG_INFINIBAND) += core/ > obj-$(CONFIG_INFINIBAND) += hw/ > obj-$(CONFIG_INFINIBAND) += ulp/ > +obj-$(CONFIG_INFINIBAND) += sw/ > diff --git a/drivers/infiniband/sw/Makefile b/drivers/infiniband/sw/Makefile > new file mode 100644 > index 000..988b6a0 > --- /dev/null > +++ b/drivers/infiniband/sw/Makefile > @@ -0,0 +1 @@ > +obj-$(CONFIG_INFINIBAND_RDMAVT) += rdmavt/ > diff --git a/drivers/infiniband/sw/rdmavt/Kconfig > b/drivers/infiniband/sw/rdmavt/Kconfig > new file mode 100644 > index 000..11aa6a3 > --- /dev/null > +++ b/drivers/infiniband/sw/rdmavt/Kconfig > @@ -0,0 +1,6 @@ > +config INFINIBAND_RDMAVT > + tristate "RDMA verbs transport library" > + depends on 64BIT > + default m > + ---help--- > + This is a common software verbs provider for RDMA networks. > diff --git a/drivers/infiniband/sw/rdmavt/Makefile > b/drivers/infiniband/sw/rdmavt/Makefile > new file mode 100644 > index 000..98a664d > --- /dev/null > +++ b/drivers/infiniband/sw/rdmavt/Makefile > @@ -0,0 +1,10 @@ > +# > +# rdmavt driver > +# > +# > +# > +# Called from the kernel module build system. > +# > +obj-$(CONFIG_INFINIBAND_RDMAVT) += rdmavt.o > + > +rdmavt-y := vt.o > diff --git a/drivers/infiniband/sw/rdmavt/vt.c > b/drivers/infiniband/sw/rdmavt/vt.c > new file mode 100644 > index 000..aa325db > --- /dev/null > +++ b/drivers/infiniband/sw/rdmavt/vt.c > @@ -0,0 +1,83 @@ > +/* > + * Copyright(c) 2015 Intel Corporation. > + * > + * This file is provided under a dual BSD/GPLv2 license. When using or > + * redistributing this file, you may do so under either license. > + * > + * GPL LICENSE SUMMARY > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of version 2 of the GNU General Public License as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. > + * > + * BSD LICENSE > + * > + * Redistribution and
[PATCH v2 01/36] IB/rdmavt: Create module framework and handle driver registration
This patch introduces the basics for a new module called rdma_vt. This new driver is a software implementation of the InfiniBand verbs and aims to replace the multiple implementations that exist and duplicate each others' code. While the call to actually register the device with the IB core happens in rdma_vt, most of the work is still done in the drivers themselves. This will be changing in a follow on patch this is just laying the groundwork for this infrastructure. Reviewed-by: Ira Weiny Reviewed-by: Mike Marciniszyn Signed-off-by: Dennis Dalessandro --- Changes since v1: remove rdmavt specific driver version move copyright above license text MAINTAINERS |6 ++ drivers/infiniband/Kconfig|2 + drivers/infiniband/Makefile |1 drivers/infiniband/sw/Makefile|1 drivers/infiniband/sw/rdmavt/Kconfig |6 ++ drivers/infiniband/sw/rdmavt/Makefile | 10 drivers/infiniband/sw/rdmavt/vt.c | 83 + drivers/infiniband/sw/rdmavt/vt.h | 53 + include/rdma/rdma_vt.h| 70 9 files changed, 232 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/sw/Makefile create mode 100644 drivers/infiniband/sw/rdmavt/Kconfig create mode 100644 drivers/infiniband/sw/rdmavt/Makefile create mode 100644 drivers/infiniband/sw/rdmavt/vt.c create mode 100644 drivers/infiniband/sw/rdmavt/vt.h create mode 100644 include/rdma/rdma_vt.h diff --git a/MAINTAINERS b/MAINTAINERS index 69c8a9c..37fc192 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8880,6 +8880,12 @@ L: rds-de...@oss.oracle.com (moderated for non-subscribers) S: Supported F: net/rds/ +RDMAVT - RDMA verbs software +M: Dennis Dalessandro +L: linux-rdma@vger.kernel.org +S: Supported +F: drivers/infiniband/sw/rdmavt + READ-COPY UPDATE (RCU) M: "Paul E. McKenney" M: Josh Triplett diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig index aa26f3c..1b00bb8 100644 --- a/drivers/infiniband/Kconfig +++ b/drivers/infiniband/Kconfig @@ -72,4 +72,6 @@ source "drivers/infiniband/ulp/srpt/Kconfig" source "drivers/infiniband/ulp/iser/Kconfig" source "drivers/infiniband/ulp/isert/Kconfig" +source "drivers/infiniband/sw/rdmavt/Kconfig" + endif # INFINIBAND diff --git a/drivers/infiniband/Makefile b/drivers/infiniband/Makefile index dc21836..fad0b44 100644 --- a/drivers/infiniband/Makefile +++ b/drivers/infiniband/Makefile @@ -1,3 +1,4 @@ obj-$(CONFIG_INFINIBAND) += core/ obj-$(CONFIG_INFINIBAND) += hw/ obj-$(CONFIG_INFINIBAND) += ulp/ +obj-$(CONFIG_INFINIBAND) += sw/ diff --git a/drivers/infiniband/sw/Makefile b/drivers/infiniband/sw/Makefile new file mode 100644 index 000..988b6a0 --- /dev/null +++ b/drivers/infiniband/sw/Makefile @@ -0,0 +1 @@ +obj-$(CONFIG_INFINIBAND_RDMAVT)+= rdmavt/ diff --git a/drivers/infiniband/sw/rdmavt/Kconfig b/drivers/infiniband/sw/rdmavt/Kconfig new file mode 100644 index 000..11aa6a3 --- /dev/null +++ b/drivers/infiniband/sw/rdmavt/Kconfig @@ -0,0 +1,6 @@ +config INFINIBAND_RDMAVT + tristate "RDMA verbs transport library" + depends on 64BIT + default m + ---help--- + This is a common software verbs provider for RDMA networks. diff --git a/drivers/infiniband/sw/rdmavt/Makefile b/drivers/infiniband/sw/rdmavt/Makefile new file mode 100644 index 000..98a664d --- /dev/null +++ b/drivers/infiniband/sw/rdmavt/Makefile @@ -0,0 +1,10 @@ +# +# rdmavt driver +# +# +# +# Called from the kernel module build system. +# +obj-$(CONFIG_INFINIBAND_RDMAVT) += rdmavt.o + +rdmavt-y := vt.o diff --git a/drivers/infiniband/sw/rdmavt/vt.c b/drivers/infiniband/sw/rdmavt/vt.c new file mode 100644 index 000..aa325db --- /dev/null +++ b/drivers/infiniband/sw/rdmavt/vt.c @@ -0,0 +1,83 @@ +/* + * Copyright(c) 2015 Intel Corporation. + * + * This file is provided under a dual BSD/GPLv2 license. When using or + * redistributing this file, you may do so under either license. + * + * GPL LICENSE SUMMARY + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of version 2 of the GNU General Public License as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * General Public License for more details. + * + * BSD LICENSE + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * + * - Redistributions of source code must retain the above copyright + *notice, this list of conditions and the following disclaimer. + * - Redistributions in binar
