Re: [ewg] [PATCH] ipoib: Fix lockup of the tx queue
On Thu, 2010-03-11 at 13:38 -0800, Roland Dreier wrote: good debugging, applied thanks. I do worry (as Moni mentioned) that this doesn't explain why you would get send failures in this case, but the patch itself is well-explained and looks obviously correct so I think we should apply it. Well, after more testing it seems there may still be a problem. I haven't isolated it yet though. I could definitely use help reviewing the code changes. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ewg] [PATCH] ipoib: Fix lockup of the tx queue
Sorry, I was referring to my patch not Eli's. On Thu, 2010-03-11 at 13:41 -0800, Ralph Campbell wrote: On Thu, 2010-03-11 at 13:38 -0800, Roland Dreier wrote: good debugging, applied thanks. I do worry (as Moni mentioned) that this doesn't explain why you would get send failures in this case, but the patch itself is well-explained and looks obviously correct so I think we should apply it. Well, after more testing it seems there may still be a problem. I haven't isolated it yet though. I could definitely use help reviewing the code changes. ___ ewg mailing list e...@lists.openfabrics.org http://lists.openfabrics.org/cgi-bin/mailman/listinfo/ewg -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ewg] [PATCH] ipoib: Fix lockup of the tx queue
Sorry, I was referring to my patch not Eli's. Heh, I never would have said anything about your patch was obvious. I skimmed yours once but I do want to read it more carefully. Did you ever say what test case you are using to provoke the problem you're fixing? -- Roland Dreier rola...@cisco.com For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [ewg] [PATCH] ipoib: Fix lockup of the tx queue
On Thu, 2010-03-11 at 13:52 -0800, Roland Dreier wrote: Sorry, I was referring to my patch not Eli's. Heh, I never would have said anything about your patch was obvious. I skimmed yours once but I do want to read it more carefully. Did you ever say what test case you are using to provoke the problem you're fixing? I think I did but it is just UDP stress tests in general. Throwing in some link failures and switching between connected and datagram modes helps too. netperf, qperf, etc. should work. Anything which causes the connected mode QP to fail should exercise the fix too. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
