[infiniband-diags] fix libibnetdisc corner case when user tries to re-cache a loaded cache

[Al Chu]

Hey Sasha,

Noticed this corner case.  If I load a ibnetdiscover cache, then try to
re-cache it, the cache doesn't store things properly b/c I didn't
reconstruct one fabric data structure properly.  This fixes that bug.

Al

-- 
Albert Chu
ch...@llnl.gov
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory
---BeginMessage---

Signed-off-by: Albert Chu ch...@llnl.gov
---
 .../libibnetdisc/src/ibnetdisc_cache.c |4 
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/infiniband-diags/libibnetdisc/src/ibnetdisc_cache.c 
b/infiniband-diags/libibnetdisc/src/ibnetdisc_cache.c
index d94b85a..9cd5981 100644
--- a/infiniband-diags/libibnetdisc/src/ibnetdisc_cache.c
+++ b/infiniband-diags/libibnetdisc/src/ibnetdisc_cache.c
@@ -501,6 +501,10 @@ static int _fill_port(ibnd_fabric_cache_t * fabric_cache, 
ibnd_node_t * node,
 
node-ports[port_cache-port-portnum] = port_cache-port;
 
+   /* achu: needed if user wishes to re-cache a loaded fabric.
+* Otherwise, mostly unnecessary to do this.
+*/
+   add_to_portguid_hash(port_cache-port, fabric_cache-fabric-portstbl);
return 0;
 }
 
-- 
1.5.4.5

---End Message---

Re: [infiniband-diags] fix libibnetdisc corner case when user tries to re-cache a loaded cache

[Sasha Khapyorsky]

On 10:24 Fri 09 Apr , Al Chu wrote:
 Hey Sasha,
 
 Noticed this corner case.  If I load a ibnetdiscover cache, then try to
 re-cache it, the cache doesn't store things properly b/c I didn't
 reconstruct one fabric data structure properly.  This fixes that bug.
 
 Al
 
 -- 
 Albert Chu
 ch...@llnl.gov
 Computer Scientist
 High Performance Systems Division
 Lawrence Livermore National Laboratory

 Date: Fri, 9 Apr 2010 10:12:47 -0700
 From: Albert Chu ch...@llnl.gov
 Subject: [PATCH] fix libibnetdisc corner case when user tries to re-cache
  a
   loaded cache
 Message-Id: 1270833600.17987.15.ca...@auk31.llnl.gov
 Mime-Version: 1.0
 Content-Transfer-Encoding: 7bit
 
 
 Signed-off-by: Albert Chu ch...@llnl.gov

Applied. Thanks.

Sasha
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html