Re: [PATCH v2 07/22] staging/rdma/hfi1: Fix sparse error in sdma.h file

2015-10-25 Thread gre...@linuxfoundation.org 
On Thu, Oct 22, 2015 at 01:01:25PM +0300, Dan Carpenter wrote:
> On Wed, Oct 21, 2015 at 04:29:35PM +, Weiny, Ira wrote:
> > > 
> > > On Mon, Oct 19, 2015 at 10:11:22PM -0400, ira.we...@intel.com wrote:
> > > > From: Niranjana Vishwanathapura 
> > > >
> > > > Use NULL instead of 0 for pointer argument to fix the sparse error.
> > > >
> > > > Reviewed-by: Mike Marciniszyn 
> > > > Reviewed-by: Mitko Haralanov 
> > > > Reviewed-by: Dennis Dalessandro 
> > > > Signed-off-by: Niranjana Vishwanathapura
> > > > 
> > > > Signed-off-by: Ira Weiny 
> > > 
> > > This should have just been folded in with the previous patch.  Don't 
> > > introduce
> > > problems and fix them in the patchset.
> > 
> > My bad, I will fix in v3.
> 
> I don't think it's worth redoing the patchset over because it's just a
> Sparse warning, not a bug.  But for the future.

No, please redo, the other problems in this series warrent a new series.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 07/22] staging/rdma/hfi1: Fix sparse error in sdma.h file

2015-10-22 Thread Dan Carpenter 
On Wed, Oct 21, 2015 at 04:29:35PM +, Weiny, Ira wrote:
> > 
> > On Mon, Oct 19, 2015 at 10:11:22PM -0400, ira.we...@intel.com wrote:
> > > From: Niranjana Vishwanathapura 
> > >
> > > Use NULL instead of 0 for pointer argument to fix the sparse error.
> > >
> > > Reviewed-by: Mike Marciniszyn 
> > > Reviewed-by: Mitko Haralanov 
> > > Reviewed-by: Dennis Dalessandro 
> > > Signed-off-by: Niranjana Vishwanathapura
> > > 
> > > Signed-off-by: Ira Weiny 
> > 
> > This should have just been folded in with the previous patch.  Don't 
> > introduce
> > problems and fix them in the patchset.
> 
> My bad, I will fix in v3.

I don't think it's worth redoing the patchset over because it's just a
Sparse warning, not a bug.  But for the future.

regards,
dan carpenter



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 07/22] staging/rdma/hfi1: Fix sparse error in sdma.h file

2015-10-21 Thread Dan Carpenter 
On Mon, Oct 19, 2015 at 10:11:22PM -0400, ira.we...@intel.com wrote:
> From: Niranjana Vishwanathapura 
> 
> Use NULL instead of 0 for pointer argument to fix the sparse error.
> 
> Reviewed-by: Mike Marciniszyn 
> Reviewed-by: Mitko Haralanov 
> Reviewed-by: Dennis Dalessandro 
> Signed-off-by: Niranjana Vishwanathapura 
> Signed-off-by: Ira Weiny 

This should have just been folded in with the previous patch.  Don't
introduce problems and fix them in the patchset.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v2 07/22] staging/rdma/hfi1: Fix sparse error in sdma.h file

2015-10-21 Thread Weiny, Ira 
> 
> On Mon, Oct 19, 2015 at 10:11:22PM -0400, ira.we...@intel.com wrote:
> > From: Niranjana Vishwanathapura 
> >
> > Use NULL instead of 0 for pointer argument to fix the sparse error.
> >
> > Reviewed-by: Mike Marciniszyn 
> > Reviewed-by: Mitko Haralanov 
> > Reviewed-by: Dennis Dalessandro 
> > Signed-off-by: Niranjana Vishwanathapura
> > 
> > Signed-off-by: Ira Weiny 
> 
> This should have just been folded in with the previous patch.  Don't introduce
> problems and fix them in the patchset.

My bad, I will fix in v3.

Ira

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html