Re: [PATCH V2] IB/mad: Remove improper use of BUG_ON
On 6/25/2015 6:23 PM, Weiny, Ira wrote:
On 6/25/2015 4:52 PM, ira.we...@intel.com wrote:
From: Ira Weiny
We recently added BUG_ON's which were inappropriate for a condition
which should never happen. Change these to be WARN_ON_ONCE as a
debugging aid.
Fixes: 4cd7c9479aff ('IB/mad: Add support for additional MAD info
to/from drivers')
Signed-off-by: Ira Weiny
remove the blank line,
Is there some documentation on this stuff?
I don't know
This does not mention anything about white space.
https://www.kernel.org/doc/Documentation/SubmittingPatches
I don't mind following the proper conventions if I knew what they were.
so look around a bit... e.g on networking patches and see that no blank
lines.. it's add sort of small eye damaging for someone looking on
kernel logs.
Or.
Ira
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH V2] IB/mad: Remove improper use of BUG_ON
> On 6/25/2015 4:52 PM, ira.we...@intel.com wrote:
> > From: Ira Weiny
> >
> > We recently added BUG_ON's which were inappropriate for a condition
> > which should never happen. Change these to be WARN_ON_ONCE as a
> debugging aid.
> >
> > Fixes: 4cd7c9479aff ('IB/mad: Add support for additional MAD info
> > to/from drivers')
> >
> > Signed-off-by: Ira Weiny
>
> remove the blank line,
Is there some documentation on this stuff?
This does not mention anything about white space.
https://www.kernel.org/doc/Documentation/SubmittingPatches
I don't mind following the proper conventions if I knew what they were.
Ira
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2] IB/mad: Remove improper use of BUG_ON
On 6/25/2015 4:52 PM, ira.we...@intel.com wrote:
From: Ira Weiny
We recently added BUG_ON's which were inappropriate for a condition which
should never happen. Change these to be WARN_ON_ONCE as a debugging aid.
Fixes: 4cd7c9479aff ('IB/mad: Add support for additional MAD info to/from
drivers')
Signed-off-by: Ira Weiny
remove the blank line,
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
