Re: [PATCH 0/5] SRP initiator patches for kernel 3.17
On Thu, 2014-07-03 at 15:44 +0200, Bart Van Assche wrote: This patch series consists of the following five patches, of which three are bug fixes and two are performance optimizations: 0001-scsi_transport_srp-Fix-fast_io_fail_tmo-dev_loss_tmo.patch 0002-IB-srp-Fix-deadlock-between-host-removal-and-multipa.patch 0003-IB-srp-Fix-residual-handling.patch 0004-IB-srp-Use-P_Key-cache-for-P_Key-lookups.patch 0005-IB-srp-Optimize-completion-queue-polling.patch These are SCSI patches (well at least 1/5 is), so please cc linux-scsi. James
Re: [PATCH 0/5] SRP initiator patches for kernel 3.17
(CC-ing linux-scsi) On 07/03/14 15:44, Bart Van Assche wrote: This patch series consists of the following five patches, of which three are bug fixes and two are performance optimizations: 0001-scsi_transport_srp-Fix-fast_io_fail_tmo-dev_loss_tmo.patch 0002-IB-srp-Fix-deadlock-between-host-removal-and-multipa.patch 0003-IB-srp-Fix-residual-handling.patch 0004-IB-srp-Use-P_Key-cache-for-P_Key-lookups.patch 0005-IB-srp-Optimize-completion-queue-polling.patch -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html . -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] SRP initiator patches for kernel 3.17
(CC'ing linux-scsi)
On 07/03/14 15:45, Bart Van Assche wrote: If scsi_remove_host() is called
while an rport is in the blocked
state then scsi_remove_host() will only finish if the rport is
unblocked from inside a timer function. Make sure that an rport
only enters the blocked state if a timer will be started that
will unblock it. This avoids that unloading the ib_srp kernel
module after having disconnected the initiator from the target
system results in a deadlock if both the fast_io_fail_tmo and
dev_loss_tmo parameters have been set to off.
Signed-off-by: Bart Van Assche bvanass...@acm.org
Cc: James Bottomley jbottom...@parallels.com
Cc: Sagi Grimberg sa...@mellanox.com
Cc: Sebastian Parschauer sebastian.rie...@profitbricks.com
Cc: David Dillow d...@thedillows.org
Cc: sta...@vger.kernel.org
---
drivers/scsi/scsi_transport_srp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_transport_srp.c
b/drivers/scsi/scsi_transport_srp.c
index 13e8983..a0c5bfd 100644
--- a/drivers/scsi/scsi_transport_srp.c
+++ b/drivers/scsi/scsi_transport_srp.c
@@ -473,7 +473,8 @@ static void __srp_start_tl_fail_timers(struct srp_rport
*rport)
if (delay 0)
queue_delayed_work(system_long_wq, rport-reconnect_work,
1UL * delay * HZ);
- if (srp_rport_set_state(rport, SRP_RPORT_BLOCKED) == 0) {
+ if ((fast_io_fail_tmo = 0 || dev_loss_tmo = 0)
+ srp_rport_set_state(rport, SRP_RPORT_BLOCKED) == 0) {
pr_debug(%s new state: %d\n, dev_name(shost-shost_gendev),
rport-state);
scsi_target_block(shost-shost_gendev);
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] SRP initiator patches for kernel 3.17
On 7/3/2014 5:17 PM, Bart Van Assche wrote: This patch series consists of the following five patches, of which three are bug fixes and two are performance optimizations: 0001-scsi_transport_srp-Fix-fast_io_fail_tmo-dev_loss_tmo.patch 0002-IB-srp-Fix-deadlock-between-host-removal-and-multipa.patch 0003-IB-srp-Fix-residual-handling.patch 0004-IB-srp-Use-P_Key-cache-for-P_Key-lookups.patch 0005-IB-srp-Optimize-completion-queue-polling.patch -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html . Hey Bart, The series looks good, You can add to the series: Reviewed-by: Sagi Grimberg sa...@mellanox.com Specifically to patches #1, #4, #5 you can add: Tested-by: Sagi Grimberg sa...@mellanox.com Sagi. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] SRP initiator patches for kernel 3.17
On Thu, 2014-07-03 at 15:44 +0200, Bart Van Assche wrote: This patch series consists of the following five patches, of which three are bug fixes and two are performance optimizations: 0001-scsi_transport_srp-Fix-fast_io_fail_tmo-dev_loss_tmo.patch 0002-IB-srp-Fix-deadlock-between-host-removal-and-multipa.patch 0003-IB-srp-Fix-residual-handling.patch 0004-IB-srp-Use-P_Key-cache-for-P_Key-lookups.patch 0005-IB-srp-Optimize-completion-queue-polling.patch All except the last can be Acked-by: David Dillow d...@thedillows.org or feel free to s/Acked/Reviewed/ -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
