Re: [PATCH for-next 08/10] iser-target: Support the remote invalidation exception
On 11/16/2015 6:37 PM, Sagi Grimberg wrote:
struct isert_conn *conn;
@@ -209,6 +210,7 @@ struct isert_conn {
struct work_struct release_work;
struct ib_recv_wr beacon;
boollogout_posted;
+ boolsnd_w_inv;
};
We've gone into this aspect few times in the past... my preference
is to use bit flags so the code would look like
conn->flags |= ISER_CONN_SEND_W_INV
or
if (conn->flags & ISER_CONN_LOGOUT_POSTED)
And you didn't want to go that way... but you did used
bit-fields in other areas of the driver, right?
Lets use some sort of BF-ing (bit fields or bit flags) all over the place
and not introduce new booleans everywhere we go.
Doing this over and over makes our fast path structures to grow and
maybe start crossing cache-lines (did you check that?)
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH for-next 08/10] iser-target: Support the remote invalidation exception
On 11/17/2015 11:50 AM, Sagi Grimberg wrote: same comment as the one I posted for the initiator patch, check for IB_DEVICE_MEM_MGT_EXTENSIONS SEND_WITH_INV doesn't have anything to do with IB_DEVICE_MEM_MGT_EXTENSIONS does it? What is the relations between the device capability to do FRWR and invalidating a remote rkey? I am not sure. I expect you as the author and leader for this series to dig into IBTA BMME annex and come with answers... Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH for-next 08/10] iser-target: Support the remote invalidation exception
On 11/16/2015 6:37 PM, Sagi Grimberg wrote: We'll use remote invalidate, according to negotiation result during connection establishment. If the initiator declared that it supports the remote invalidate exception then the target will use IB_WR_SEND_WITH_INV with the correct rkey for the response. same comment as the one I posted for the initiator patch, check for IB_DEVICE_MEM_MGT_EXTENSIONS Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH for-next 08/10] iser-target: Support the remote invalidation exception
On 17/11/2015 10:09, Or Gerlitz wrote: On 11/16/2015 6:37 PM, Sagi Grimberg wrote: We'll use remote invalidate, according to negotiation result during connection establishment. If the initiator declared that it supports the remote invalidate exception then the target will use IB_WR_SEND_WITH_INV with the correct rkey for the response. same comment as the one I posted for the initiator patch, check for IB_DEVICE_MEM_MGT_EXTENSIONS SEND_WITH_INV doesn't have anything to do with IB_DEVICE_MEM_MGT_EXTENSIONS does it? What is the relations between the device capability to do FRWR and invalidating a remote rkey? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH for-next 08/10] iser-target: Support the remote invalidation exception
On 17/11/2015 12:14, Christoph Hellwig wrote: On Tue, Nov 17, 2015 at 11:50:15AM +0200, Sagi Grimberg wrote: On 17/11/2015 10:09, Or Gerlitz wrote: On 11/16/2015 6:37 PM, Sagi Grimberg wrote: We'll use remote invalidate, according to negotiation result during connection establishment. If the initiator declared that it supports the remote invalidate exception then the target will use IB_WR_SEND_WITH_INV with the correct rkey for the response. same comment as the one I posted for the initiator patch, check for IB_DEVICE_MEM_MGT_EXTENSIONS SEND_WITH_INV doesn't have anything to do with IB_DEVICE_MEM_MGT_EXTENSIONS does it? What is the relations between the device capability to do FRWR and invalidating a remote rkey? Both FRs and SEND_WITH_INV are part of the base memory management extensions and also required for iWarp. Thanks for clarifying. I'll add the check. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
