RE: message size, was Re: merge struct ib_device_attr into struct ib_device

2015-09-23 Thread Steve Wise 


> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Tuesday, September 22, 2015 6:08 PM
> 
> > How do we change the message size limits?  Reviewing w/o it being
> > inline is painful for the (many) reviewers...
> 
> I've increased it.

Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: message size, was Re: merge struct ib_device_attr into struct ib_device

2015-09-23 Thread Yann Droneaud 
Hi,

Le mardi 22 septembre 2015 à 23:55 +0200, 'Christoph Hellwig' a écrit :
> On Tue, Sep 22, 2015 at 04:06:17PM -0500, Steve Wise wrote:
> > Can you create a series of smaller patches that will fit on the
> > list?
> > That would make it easier for everyone to review/comment. 
> 
> I don't see how that is possible, as it's a flag day change.
> 

Perhaps you could change ib_query_device() to use the ib_device_attr
from struct ib_device so that ulp doesn't have to be modified at the
same time the drivers. Then further patches can update the users of
ib_query_device(), one at a time. And the last patch would remove
ib_query_device().

Regards.

-- 
Yann Droneaud

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

message size, was Re: merge struct ib_device_attr into struct ib_device

2015-09-22 Thread 'Christoph Hellwig' 
On Tue, Sep 22, 2015 at 04:06:17PM -0500, Steve Wise wrote:
> Can you create a series of smaller patches that will fit on the list?
> That would make it easier for everyone to review/comment. 

I don't see how that is possible, as it's a flag day change.

But maybe we really need to bump up the message size limits for linux-rdma,
I'm pretty sure linux-kernel and linux-scsi handle attachments of this
size just fine.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: message size, was Re: merge struct ib_device_attr into struct ib_device

2015-09-22 Thread David Miller 
From: "Steve Wise" 
Date: Tue, 22 Sep 2015 17:15:15 -0500

> How do we change the message size limits?  Reviewing w/o it being
> inline is painful for the (many) reviewers...

I've increased it.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html