Re: mlx4 - query regarding PF VF functionality division
I see, by the nature of the mlx4 SRIOV architecture under which there's no dedicated/separated PF vs VF driver, this is indeed a non-trivial task, need to think how to make it easier for you Thanks for considering. It would be really helpful. I actually appreciate the mlx4 architecture wherein 3 separate drivers are part of 1 integrated code base which I think is really difficult to accomplish. I mean the dedicated driver, VF driver, PF driver are all part of single code base which i think is good. The only thing is when one wants to understand these pieces (VF or PF) separately, it takes some effort(as in my case) For e.g there is this flow: mlx4_en_get-qp()-mlx4_register_mac()-mlx4_slave_cmd() after this the wrapper function gets called be it either for master(PF) or for slave(VF) Till now I was assuming that this makes sense only for the slave(VF) because register_mac is supposed to be called by VF. But from the code even the PF makes the call. So i was somewhat confused. It would be of immense help if I could understand this somehow.. On Thu, Jun 26, 2014 at 2:13 AM, Or Gerlitz or.gerl...@gmail.com wrote: On Tue, Jun 24, 2014 at 4:42 PM, Bob Biloxi iambobbil...@gmail.com wrote: Not really, but let's take EIM approach, what's your goal/mission? Let's say I am going through code to understand only the PF related functionality without bothering about VF, what are the things I need to keep in mind. I see, by the nature of the mlx4 SRIOV architecture under which there's no dedicated/separated PF vs VF driver, this is indeed a non-trivial task, need to think how to make it easier for you Or. I mean do i need to : a. Go through all the files in mlx4 b. If the code is not specifically under mlx4_is_master, I still need to understand it because it is also part of PF driver c. I can ignore the logic which executes if mlx4_is_master is false, because that would be the VF code Thanks for the help!! On Mon, Jun 23, 2014 at 5:30 PM, Or Gerlitz or.gerl...@gmail.com wrote: On Mon, Jun 23, 2014 at 12:33 PM, Bob Biloxi iambobbil...@gmail.com wrote: [...] Is there any way we can clearly separate the files that are used by PF vs the files that are used by VF in the (drivers/net/ethernet/mlx4 sub-directory)? [...] Not really, but let's take EIM approach, what's your goal/mission? Or. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: mlx4 - query regarding PF VF functionality division
On Tue, Jun 24, 2014 at 4:42 PM, Bob Biloxi iambobbil...@gmail.com wrote: Not really, but let's take EIM approach, what's your goal/mission? Let's say I am going through code to understand only the PF related functionality without bothering about VF, what are the things I need to keep in mind. I see, by the nature of the mlx4 SRIOV architecture under which there's no dedicated/separated PF vs VF driver, this is indeed a non-trivial task, need to think how to make it easier for you Or. I mean do i need to : a. Go through all the files in mlx4 b. If the code is not specifically under mlx4_is_master, I still need to understand it because it is also part of PF driver c. I can ignore the logic which executes if mlx4_is_master is false, because that would be the VF code Thanks for the help!! On Mon, Jun 23, 2014 at 5:30 PM, Or Gerlitz or.gerl...@gmail.com wrote: On Mon, Jun 23, 2014 at 12:33 PM, Bob Biloxi iambobbil...@gmail.com wrote: [...] Is there any way we can clearly separate the files that are used by PF vs the files that are used by VF in the (drivers/net/ethernet/mlx4 sub-directory)? [...] Not really, but let's take EIM approach, what's your goal/mission? Or. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: mlx4 - query regarding PF VF functionality division
Not really, but let's take EIM approach, what's your goal/mission? Let's say I am going through code to understand only the PF related functionality without bothering about VF, what are the things I need to keep in mind. I mean do i need to : a. Go through all the files in mlx4 b. If the code is not specifically under mlx4_is_master, I still need to understand it because it is also part of PF driver c. I can ignore the logic which executes if mlx4_is_master is false, because that would be the VF code Thanks for the help!! On Mon, Jun 23, 2014 at 5:30 PM, Or Gerlitz or.gerl...@gmail.com wrote: On Mon, Jun 23, 2014 at 12:33 PM, Bob Biloxi iambobbil...@gmail.com wrote: [...] Is there any way we can clearly separate the files that are used by PF vs the files that are used by VF in the (drivers/net/ethernet/mlx4 sub-directory)? [...] Not really, but let's take EIM approach, what's your goal/mission? Or. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
mlx4 - query regarding PF VF functionality division
Hi All, I was going through the Mellanox driver (mlx4) and then I had difficulty understanding which portion of code corresponds to the one executed by the PF(Physical Function Driver) and which portion of code by (Virtual Function Driver) in the SRIOV mode. My confusion is because, I was of the understanding that the QPs, CQs (and their creation, state mgmt commands) etc are to be performed by the virtual function driver(VF driver). And the role of the physical function driver(PF driver) is to just take care of the resource_tracker.c and ICM allocation. But of late, I think I may have understood wrong. This is because there is code that is specifically executed when mlx4_is_master is true/false( indicating PF or VF). And then, there is code which is not surrounded by this test, which indicates it is executed in both cases(PF driver as well as VF driver). Is my understanding correct? If yes, then are the QPs, CQs and ethernet tx, rx related functionality is executed both by master and slave? Is there any way we can clearly separate the files that are used by PF vs the files that are used by VF in the (drivers/net/ethernet/mlx4 sub-directory)? I would be really thankful and really appreciate all the help/clarification I can get in understanding this. Thank you so much. Best Regards, Bob -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: mlx4 - query regarding PF VF functionality division
On Mon, Jun 23, 2014 at 12:33 PM, Bob Biloxi iambobbil...@gmail.com wrote: [...] Is there any way we can clearly separate the files that are used by PF vs the files that are used by VF in the (drivers/net/ethernet/mlx4 sub-directory)? [...] Not really, but let's take EIM approach, what's your goal/mission? Or. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
