Re: osm_vl15intf.c: fixing use-after-free coredump

2010-10-25 Thread Sasha Khapyorsky
On 13:04 Mon 11 Oct , Yevgeny Kliteynik wrote:
 p_madw is freed if responce is not expected.
 
 Signed-off-by: Yevgeny Kliteynik klit...@dev.mellanox.co.il

Applied. Thanks.

Sasha
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


osm_vl15intf.c: fixing use-after-free coredump

2010-10-11 Thread Yevgeny Kliteynik
p_madw is freed if responce is not expected.

Signed-off-by: Yevgeny Kliteynik klit...@dev.mellanox.co.il
---
 opensm/opensm/osm_vl15intf.c |5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/opensm/opensm/osm_vl15intf.c b/opensm/opensm/osm_vl15intf.c
index bb2c0c6..c845597 100644
--- a/opensm/opensm/osm_vl15intf.c
+++ b/opensm/opensm/osm_vl15intf.c
@@ -57,13 +57,14 @@
 static void vl15_send_mad(osm_vl15_t * p_vl, osm_madw_t * p_madw)
 {
ib_api_status_t status;
+   boolean_t resp_expected = p_madw-resp_expected;

/*
   Non-response-expected mads are not throttled on the wire
   since we can have no confirmation that they arrived
   at their destination.
 */
-   if (p_madw-resp_expected == TRUE)
+   if (resp_expected)
/*
   Note that other threads may not see the response MAD
   arrive before send() even returns.
@@ -103,7 +104,7 @@ static void vl15_send_mad(osm_vl15_t * p_vl, osm_madw_t * 
p_madw)
   qp0_mads_outstanding will be decremented by send error callback
   (called by osm_vendor_send() */
cl_atomic_dec(p_vl-p_stats-qp0_mads_sent);
-   if (!p_madw-resp_expected)
+   if (!resp_expected)
cl_atomic_dec(p_vl-p_stats-qp0_unicasts_sent);
 }

-- 
1.6.2.4

--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html