Re: [PATCH 1/2] [RFC] arm64: renesas: Move SoC Kconfig symbols to drivers/soc/renesas/
On Thu, Oct 11, 2018 at 10:55:07AM +0200, Geert Uytterhoeven wrote: > For consistency with other vendors, which have a single Kconfig symbol > in arch/arm64/Kconfig.platforms. > > Signed-off-by: Geert Uytterhoeven > --- > Note that drivers/clk/ is included before drivers/soc/. Hence when > COMPILE_TEST=y, questions will be asked about clock drivers before they > can be auto-selected by SoC support. > > Question: Should we introduce a family-specific Kconfig symbol for R-Car > Gen3 (ARCH_RCAR_GEN1), which could be used for enabling s/1/3/? > RST_RCAR? Given that it would be consistent with R-Car Gen 1 and 2, that seems like a good idea to me. > --- > arch/arm64/Kconfig.platforms | 54 > drivers/soc/renesas/Kconfig | 81 ++-- > 2 files changed, 68 insertions(+), 67 deletions(-) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index fecdfc70828c2ac3..e7f1659064f82790 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -165,60 +165,6 @@ config ARCH_RENESAS > help > This enables support for the ARMv8 based Renesas SoCs. > > -config ARCH_R8A774A1 > - bool "Renesas RZ/G2M SoC Platform" > - depends on ARCH_RENESAS > - help > - This enables support for the Renesas RZ/G2M SoC. > - > -config ARCH_R8A774C0 > - bool "Renesas RZ/G2E SoC Platform" > - depends on ARCH_RENESAS > - help > - This enables support for the Renesas RZ/G2E SoC. > - > -config ARCH_R8A7795 > - bool "Renesas R-Car H3 SoC Platform" > - depends on ARCH_RENESAS > - help > - This enables support for the Renesas R-Car H3 SoC. > - > -config ARCH_R8A7796 > - bool "Renesas R-Car M3-W SoC Platform" > - depends on ARCH_RENESAS > - help > - This enables support for the Renesas R-Car M3-W SoC. > - > -config ARCH_R8A77965 > - bool "Renesas R-Car M3-N SoC Platform" > - depends on ARCH_RENESAS > - help > - This enables support for the Renesas R-Car M3-N SoC. > - > -config ARCH_R8A77970 > - bool "Renesas R-Car V3M SoC Platform" > - depends on ARCH_RENESAS > - help > - This enables support for the Renesas R-Car V3M SoC. > - > -config ARCH_R8A77980 > - bool "Renesas R-Car V3H SoC Platform" > - depends on ARCH_RENESAS > - help > - This enables support for the Renesas R-Car V3H SoC. > - > -config ARCH_R8A77990 > - bool "Renesas R-Car E3 SoC Platform" > - depends on ARCH_RENESAS > - help > - This enables support for the Renesas R-Car E3 SoC. > - > -config ARCH_R8A77995 > - bool "Renesas R-Car D3 SoC Platform" > - depends on ARCH_RENESAS > - help > - This enables support for the Renesas R-Car D3 SoC. > - > config ARCH_ROCKCHIP > bool "Rockchip Platforms" > select ARCH_HAS_RESET_CONTROLLER > diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig > index 407f02c80e8b721c..0ab62024fd20be56 100644 > --- a/drivers/soc/renesas/Kconfig > +++ b/drivers/soc/renesas/Kconfig > @@ -3,30 +3,85 @@ config SOC_RENESAS > bool "Renesas SoC driver support" if COMPILE_TEST && !ARCH_RENESAS > default y if ARCH_RENESAS > select SOC_BUS > - select RST_RCAR if ARCH_RCAR_GEN1 || ARCH_RCAR_GEN2 || \ > -ARCH_R8A774A1 || ARCH_R8A774C0 || ARCH_R8A7795 || \ > -ARCH_R8A7796 || ARCH_R8A77965 || ARCH_R8A77970 || \ > -ARCH_R8A77980 || ARCH_R8A77990 || ARCH_R8A77995 > + select RST_RCAR if ARCH_RCAR_GEN1 || ARCH_RCAR_GEN2 > select SYSC_R8A7743 if ARCH_R8A7743 || ARCH_R8A7744 > select SYSC_R8A7745 if ARCH_R8A7745 > select SYSC_R8A77470 if ARCH_R8A77470 > - select SYSC_R8A774A1 if ARCH_R8A774A1 > - select SYSC_R8A774C0 if ARCH_R8A774C0 > select SYSC_R8A7779 if ARCH_R8A7779 > select SYSC_R8A7790 if ARCH_R8A7790 > select SYSC_R8A7791 if ARCH_R8A7791 || ARCH_R8A7793 > select SYSC_R8A7792 if ARCH_R8A7792 > select SYSC_R8A7794 if ARCH_R8A7794 > - select SYSC_R8A7795 if ARCH_R8A7795 > - select SYSC_R8A7796 if ARCH_R8A7796 > - select SYSC_R8A77965 if ARCH_R8A77965 > - select SYSC_R8A77970 if ARCH_R8A77970 > - select SYSC_R8A77980 if ARCH_R8A77980 > - select SYSC_R8A77990 if ARCH_R8A77990 > - select SYSC_R8A77995 if ARCH_R8A77995 > > if SOC_RENESAS > > +if ARM64 > + > +config ARCH_R8A774A1 > + bool "Renesas RZ/G2M SoC Platform" > + select RST_RCAR > + select SYSC_R8A774A1 > + help > + This enables support for the Renesas RZ/G2M SoC. > + > +config ARCH_R8A774C0 > + bool "Renesas RZ/G2E SoC Platform" > + select RST_RCAR > + select SYSC_R8A774C0 > + help > + This enables support for the Renesas RZ/G2E SoC. > + > +config ARCH_R8A7795 > + bool "Renesas R-Car H3 SoC Platform" > + select RST_RCAR > + select SYSC_R8A7795 > + help >
RE: [PATCH] pinctrl: renesas: fix platform_no_drv_owner.cocci warnings
On 10 October 2018 17:03 kbuild test robot wrote:
> drivers/pinctrl/pinctrl-rzn1.c:935:3-8: No need to set .owner here. The core
> will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> Fixes: 4e53b5004745 ("pinctrl: renesas: Renesas RZ/N1 pinctrl driver")
> CC: Phil Edworthy
> Signed-off-by: kbuild test robot
Reviewed-by: Phil Edworthy
> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-
> drivers.git sh-pfc-for-v4.20
> head: ef26d96023a4c34b1bcc4294f570df2b63a1b952
> commit: 4e53b5004745ef26a37bca4933b2d3ea71313f2a [24/25] pinctrl:
> renesas: Renesas RZ/N1 pinctrl driver
>
> pinctrl-rzn1.c |1 -
> 1 file changed, 1 deletion(-)
>
> --- a/drivers/pinctrl/pinctrl-rzn1.c
> +++ b/drivers/pinctrl/pinctrl-rzn1.c
> @@ -932,7 +932,6 @@ static struct platform_driver rzn1_pinct
> .remove = rzn1_pinctrl_remove,
> .driver = {
> .name = "rzn1-pinctrl",
> - .owner = THIS_MODULE,
> .of_match_table = rzn1_pinctrl_match,
> },
> };
[PATCH 1/2] [RFC] arm64: renesas: Move SoC Kconfig symbols to drivers/soc/renesas/
For consistency with other vendors, which have a single Kconfig symbol in arch/arm64/Kconfig.platforms. Signed-off-by: Geert Uytterhoeven --- Note that drivers/clk/ is included before drivers/soc/. Hence when COMPILE_TEST=y, questions will be asked about clock drivers before they can be auto-selected by SoC support. Question: Should we introduce a family-specific Kconfig symbol for R-Car Gen3 (ARCH_RCAR_GEN1), which could be used for enabling RST_RCAR? --- arch/arm64/Kconfig.platforms | 54 drivers/soc/renesas/Kconfig | 81 ++-- 2 files changed, 68 insertions(+), 67 deletions(-) diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index fecdfc70828c2ac3..e7f1659064f82790 100644 --- a/arch/arm64/Kconfig.platforms +++ b/arch/arm64/Kconfig.platforms @@ -165,60 +165,6 @@ config ARCH_RENESAS help This enables support for the ARMv8 based Renesas SoCs. -config ARCH_R8A774A1 - bool "Renesas RZ/G2M SoC Platform" - depends on ARCH_RENESAS - help - This enables support for the Renesas RZ/G2M SoC. - -config ARCH_R8A774C0 - bool "Renesas RZ/G2E SoC Platform" - depends on ARCH_RENESAS - help - This enables support for the Renesas RZ/G2E SoC. - -config ARCH_R8A7795 - bool "Renesas R-Car H3 SoC Platform" - depends on ARCH_RENESAS - help - This enables support for the Renesas R-Car H3 SoC. - -config ARCH_R8A7796 - bool "Renesas R-Car M3-W SoC Platform" - depends on ARCH_RENESAS - help - This enables support for the Renesas R-Car M3-W SoC. - -config ARCH_R8A77965 - bool "Renesas R-Car M3-N SoC Platform" - depends on ARCH_RENESAS - help - This enables support for the Renesas R-Car M3-N SoC. - -config ARCH_R8A77970 - bool "Renesas R-Car V3M SoC Platform" - depends on ARCH_RENESAS - help - This enables support for the Renesas R-Car V3M SoC. - -config ARCH_R8A77980 - bool "Renesas R-Car V3H SoC Platform" - depends on ARCH_RENESAS - help - This enables support for the Renesas R-Car V3H SoC. - -config ARCH_R8A77990 - bool "Renesas R-Car E3 SoC Platform" - depends on ARCH_RENESAS - help - This enables support for the Renesas R-Car E3 SoC. - -config ARCH_R8A77995 - bool "Renesas R-Car D3 SoC Platform" - depends on ARCH_RENESAS - help - This enables support for the Renesas R-Car D3 SoC. - config ARCH_ROCKCHIP bool "Rockchip Platforms" select ARCH_HAS_RESET_CONTROLLER diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig index 407f02c80e8b721c..0ab62024fd20be56 100644 --- a/drivers/soc/renesas/Kconfig +++ b/drivers/soc/renesas/Kconfig @@ -3,30 +3,85 @@ config SOC_RENESAS bool "Renesas SoC driver support" if COMPILE_TEST && !ARCH_RENESAS default y if ARCH_RENESAS select SOC_BUS - select RST_RCAR if ARCH_RCAR_GEN1 || ARCH_RCAR_GEN2 || \ - ARCH_R8A774A1 || ARCH_R8A774C0 || ARCH_R8A7795 || \ - ARCH_R8A7796 || ARCH_R8A77965 || ARCH_R8A77970 || \ - ARCH_R8A77980 || ARCH_R8A77990 || ARCH_R8A77995 + select RST_RCAR if ARCH_RCAR_GEN1 || ARCH_RCAR_GEN2 select SYSC_R8A7743 if ARCH_R8A7743 || ARCH_R8A7744 select SYSC_R8A7745 if ARCH_R8A7745 select SYSC_R8A77470 if ARCH_R8A77470 - select SYSC_R8A774A1 if ARCH_R8A774A1 - select SYSC_R8A774C0 if ARCH_R8A774C0 select SYSC_R8A7779 if ARCH_R8A7779 select SYSC_R8A7790 if ARCH_R8A7790 select SYSC_R8A7791 if ARCH_R8A7791 || ARCH_R8A7793 select SYSC_R8A7792 if ARCH_R8A7792 select SYSC_R8A7794 if ARCH_R8A7794 - select SYSC_R8A7795 if ARCH_R8A7795 - select SYSC_R8A7796 if ARCH_R8A7796 - select SYSC_R8A77965 if ARCH_R8A77965 - select SYSC_R8A77970 if ARCH_R8A77970 - select SYSC_R8A77980 if ARCH_R8A77980 - select SYSC_R8A77990 if ARCH_R8A77990 - select SYSC_R8A77995 if ARCH_R8A77995 if SOC_RENESAS +if ARM64 + +config ARCH_R8A774A1 + bool "Renesas RZ/G2M SoC Platform" + select RST_RCAR + select SYSC_R8A774A1 + help + This enables support for the Renesas RZ/G2M SoC. + +config ARCH_R8A774C0 + bool "Renesas RZ/G2E SoC Platform" + select RST_RCAR + select SYSC_R8A774C0 + help + This enables support for the Renesas RZ/G2E SoC. + +config ARCH_R8A7795 + bool "Renesas R-Car H3 SoC Platform" + select RST_RCAR + select SYSC_R8A7795 + help + This enables support for the Renesas R-Car H3 SoC. + +config ARCH_R8A7796 + bool "Renesas R-Car M3-W SoC Platform" + select RST_RCAR + select SYSC_R8A7796 + help + This enables support for the Renesas R-Car M3-W SoC. + +config ARCH_R8A77965 +
[PATCH 2/2] [RFC] ARM: shmobile: Move SoC Kconfig symbols to drivers/soc/renesas/
For consistency with arm64, where vendors have a single Kconfig symbol in arch/arm64/Kconfig.platforms. Signed-off-by: Geert Uytterhoeven --- Note that drivers/clk/ is included before drivers/soc/. Hence when COMPILE_TEST=y, questions will be asked about clock drivers before they can be auto-selected by SoC support. Question: Should the family-specific Kconfig symbols be moved, too? Not much would be left in arch/arm/mach-shmobile/Kconfig, though. --- arch/arm/mach-shmobile/Kconfig | 101 --- drivers/soc/renesas/Kconfig| 120 ++--- 2 files changed, 112 insertions(+), 109 deletions(-) diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig index b100c26a858f9015..50267ad76f990f11 100644 --- a/arch/arm/mach-shmobile/Kconfig +++ b/arch/arm/mach-shmobile/Kconfig @@ -36,104 +36,3 @@ menuconfig ARCH_RENESAS select PINCTRL select SOC_BUS select ZONE_DMA if ARM_LPAE - -if ARCH_RENESAS - -#comment "Renesas ARM SoCs System Type" - -config ARCH_EMEV2 - bool "Emma Mobile EV2" - select SYS_SUPPORTS_EM_STI - -config ARCH_R7S72100 - bool "RZ/A1H (R7S72100)" - select PM - select PM_GENERIC_DOMAINS - select SYS_SUPPORTS_SH_MTU2 - select RENESAS_OSTM - -config ARCH_R7S9210 - bool "RZ/A2 (R7S9210)" - select PM - select PM_GENERIC_DOMAINS - select RENESAS_OSTM - -config ARCH_R8A73A4 - bool "R-Mobile APE6 (R8A73A40)" - select ARCH_RMOBILE - select ARM_ERRATA_798181 if SMP - select HAVE_ARM_ARCH_TIMER - select RENESAS_IRQC - -config ARCH_R8A7740 - bool "R-Mobile A1 (R8A77400)" - select ARCH_RMOBILE - select RENESAS_INTC_IRQPIN - -config ARCH_R8A7743 - bool "RZ/G1M (R8A77430)" - select ARCH_RCAR_GEN2 - select ARM_ERRATA_798181 if SMP - -config ARCH_R8A7744 - bool "RZ/G1N (R8A77440)" - select ARCH_RCAR_GEN2 - select ARM_ERRATA_798181 if SMP - -config ARCH_R8A7745 - bool "RZ/G1E (R8A77450)" - select ARCH_RCAR_GEN2 - -config ARCH_R8A77470 - bool "RZ/G1C (R8A77470)" - select ARCH_RCAR_GEN2 - -config ARCH_R8A7778 - bool "R-Car M1A (R8A77781)" - select ARCH_RCAR_GEN1 - -config ARCH_R8A7779 - bool "R-Car H1 (R8A77790)" - select ARCH_RCAR_GEN1 - -config ARCH_R8A7790 - bool "R-Car H2 (R8A77900)" - select ARCH_RCAR_GEN2 - select ARM_ERRATA_798181 if SMP - select I2C - -config ARCH_R8A7791 - bool "R-Car M2-W (R8A77910)" - select ARCH_RCAR_GEN2 - select ARM_ERRATA_798181 if SMP - select I2C - -config ARCH_R8A7792 - bool "R-Car V2H (R8A77920)" - select ARCH_RCAR_GEN2 - select ARM_ERRATA_798181 if SMP - -config ARCH_R8A7793 - bool "R-Car M2-N (R8A7793)" - select ARCH_RCAR_GEN2 - select ARM_ERRATA_798181 if SMP - select I2C - -config ARCH_R8A7794 - bool "R-Car E2 (R8A77940)" - select ARCH_RCAR_GEN2 - -config ARCH_R9A06G032 - bool "RZ/N1D (R9A06G032)" - select ARCH_RZN1 - -config ARCH_RZN1 - bool "RZ/N1 (R9A06G0xx) Family" - select ARM_AMBA - select CPU_V7 - -config ARCH_SH73A0 - bool "SH-Mobile AG5 (R8A73A00)" - select ARCH_RMOBILE - select RENESAS_INTC_IRQPIN -endif diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig index 0ab62024fd20be56..5089c65b544909c2 100644 --- a/drivers/soc/renesas/Kconfig +++ b/drivers/soc/renesas/Kconfig @@ -4,17 +4,121 @@ config SOC_RENESAS default y if ARCH_RENESAS select SOC_BUS select RST_RCAR if ARCH_RCAR_GEN1 || ARCH_RCAR_GEN2 - select SYSC_R8A7743 if ARCH_R8A7743 || ARCH_R8A7744 - select SYSC_R8A7745 if ARCH_R8A7745 - select SYSC_R8A77470 if ARCH_R8A77470 - select SYSC_R8A7779 if ARCH_R8A7779 - select SYSC_R8A7790 if ARCH_R8A7790 - select SYSC_R8A7791 if ARCH_R8A7791 || ARCH_R8A7793 - select SYSC_R8A7792 if ARCH_R8A7792 - select SYSC_R8A7794 if ARCH_R8A7794 if SOC_RENESAS +if ARM + +#comment "Renesas ARM SoCs System Type" + +config ARCH_EMEV2 + bool "Emma Mobile EV2" + select SYS_SUPPORTS_EM_STI + +config ARCH_R7S72100 + bool "RZ/A1H (R7S72100)" + select PM + select PM_GENERIC_DOMAINS + select SYS_SUPPORTS_SH_MTU2 + select RENESAS_OSTM + +config ARCH_R7S9210 + bool "RZ/A2 (R7S9210)" + select PM + select PM_GENERIC_DOMAINS + select RENESAS_OSTM + +config ARCH_R8A73A4 + bool "R-Mobile APE6 (R8A73A40)" + select ARCH_RMOBILE + select ARM_ERRATA_798181 if SMP + select HAVE_ARM_ARCH_TIMER + select RENESAS_IRQC + +config ARCH_R8A7740 + bool "R-Mobile A1 (R8A77400)" + select ARCH_RMOBILE + select RENESAS_INTC_IRQPIN + +config ARCH_R8A7743 + bool "RZ/G1M (R8A77430)" + select ARCH_RCAR_GEN2 + select ARM_ERRATA_798181 if SMP +
[PATCH/RFC 0/2] arm: renesas: Move SoC Kconfig symbols to drivers/soc/renesas/
Hi all, As pointed out by Arnd[*], there are lots of SoC-specific Kconfig symbols in the Renesas section of arch/arm64/Kconfig.platforms, while other vendors expose a single Kconfig symbol there. Hence this patch series moves them to drivers/soc/renesas/Kconfig, reducing the footprint and associated amount of churn in arch/arm64/Kconfig.platforms, while preserving the benefits for users of automatic selection of e.g. clock and pinctrl drivers. As my OCD just loves consistency, the second patch does the same for arm32 SoCs. Note that e.g. drivers/clk/ is included before drivers/soc/. Hence when COMPILE_TEST=y and ARCH_RENESAS=n, questions will be asked about clock drivers before they can be auto-selected by the corresponding SoC-specific Kconfig symbols. Of course this will trigger some defconfig updates later... Thanks for your comments! [*] https://www.spinics.net/lists/arm-kernel/msg679390.html Geert Uytterhoeven (2): [RFC] arm64: renesas: Move SoC Kconfig symbols to drivers/soc/renesas/ [RFC] ARM: shmobile: Move SoC Kconfig symbols to drivers/soc/renesas/ arch/arm/mach-shmobile/Kconfig | 101 - arch/arm64/Kconfig.platforms | 54 - drivers/soc/renesas/Kconfig| 201 + 3 files changed, 180 insertions(+), 176 deletions(-) -- 2.17.1
Re: [PATCH] drm/rcar-du: Convert drm_atomic_helper_suspend/resume()
On Mon, Oct 08, 2018 at 09:57:52PM +0530, Souptick Joarder wrote:
> Hi Laurent,
> On Mon, Oct 1, 2018 at 6:12 PM Noralf Trønnes wrote:
> >
> >
> > Den 01.10.2018 13.56, skrev Laurent Pinchart:
> > > Hi Daniel,
> > >
> > > On Monday, 1 October 2018 09:52:20 EEST Daniel Vetter wrote:
> > >> On Fri, Sep 28, 2018 at 06:30:35PM +0300, Laurent Pinchart wrote:
> > >>> On Friday, 28 September 2018 18:05:18 EEST Laurent Pinchart wrote:
> > On Thursday, 27 September 2018 09:34:18 EEST Souptick Joarder wrote:
> > > On Tue, Sep 18, 2018 at 10:05 PM Souptick Joarder wrote:
> > >> convert drm_atomic_helper_suspend/resume() to use
> > >> drm_mode_config_helper_suspend/resume().
> > >>
> > >> remove suspend_state field from the rcar_du_device
> > >> structure as it is no more required.
> > >>
> > >> With this conversion, also drm_fbdev_cma_set_suspend_unlocked()
> > >> will left with no consumer. So this function can be removed.
> > >>
> > >> Signed-off-by: Souptick Joarder
> > > Laurent, any comment on this patch ??
> > Sorry for the delay, and thanks for pinging me.
> >
> > Reviewed-by: Laurent Pinchart
> >
> > Should I apply this to my tree or do you plan to merge it through
> > drm-misc
> > as it touches drm_fb_cma_helper.c ?
> > >>> I just realized that the same patch got supplied by Noralf Trønnes
> > >>> nearly
> > >>> a
> > >>> year ago, and was later superseded by
> > >>> https://patchwork.freedesktop.org/patch/247861/. I think we should thus
> > >>> apply Noralf's patches instead (once he sends v4 out).
> > >> I don't think Noralf is still actively working on this, he's busy with
> > >> the
> > >> fbdev emulation stuff. Probably better if you pick up one of the existing
> > >> ones, than waiting another year or so :-)
> > > Isn't https://patchwork.freedesktop.org/patch/247861/ part of the fbdev
> > > emulation stuff ? That patch series is from less than a month ago, so I
> > > thought it was actively developed.
> > >
> > > Let's ask him. Noralf, any comment ? :-)
> >
> > I see now that I've caused some confusion here.
> >
> > I did some refactoring of the fbdev stuff in the CMA helper last year.
> > In the last series of that work there is this patch:
> >
> > [v3,07/11] drm/rcar-du: Use drm_mode_config_helper_suspend/resume()
> > https://patchwork.freedesktop.org/patch/192414/
> >
> > During Christmas I got the idea that maybe it was possible to use a dumb
> > buffer to do generic fbdev emulation. That work took me 6 months before a
> > solution using a general internal DRM client was hammered out. By the
> > time I started to convert drivers I had forgotten about that patch.
> >
> > When I wrote the patch (#247861) to convert rcar to the generic fbdev, I
> > just bundled up the suspend/resume change with the fbdev conversion.
> > Laurent and Sam commented on that bundling, so I said that I would split
> > it up in the next version.
> >
> > All that being said, I think that this patch should be applied and I'll
> > just rebase the rcar fbdev conversion patch on top of that.
> > It's the easiest for me at least :-)
> >
> Any conclusion on this patch ? :-)
Laurent should pick it up and apply to his rcar-du tree I think. We can
also stuff it into drm-misc as a fallback.
-Daniel
>
> ers/gpu/drm/drm_fb_cma_helper.c | 18 --
> > >> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 21 ++---
> > >> drivers/gpu/drm/rcar-du/rcar_du_drv.h | 1 -
> > >> include/drm/drm_fb_cma_helper.h | 2 --
> > >> 4 files changed, 2 insertions(+), 40 deletions(-)
> > >>
> > >> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c
> > >> b/drivers/gpu/drm/drm_fb_cma_helper.c index 47e0e2f..96efc88 100644
> > >> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> > >> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> > >> @@ -224,21 +224,3 @@ void drm_fbdev_cma_hotplug_event(struct
> > >> drm_fbdev_cma *fbdev_cma)
> > >>
> > >> drm_fb_helper_hotplug_event(_cma->fb_helper);
> > >>
> > >> }
> > >> EXPORT_SYMBOL_GPL(drm_fbdev_cma_hotplug_event);
> > >>
> > >> -
> > >> -/**
> > >> - * drm_fbdev_cma_set_suspend_unlocked - wrapper around
> > >> - *
> > >> drm_fb_helper_set_suspend_unlocked
> > >> - * @fbdev_cma: The drm_fbdev_cma struct, may be NULL
> > >> - * @state: desired state, zero to resume, non-zero to suspend
> > >> - *
> > >> - * Calls drm_fb_helper_set_suspend, which is a wrapper around
> > >> - * fb_set_suspend implemented by fbdev core.
> > >> - */
> > >> -void drm_fbdev_cma_set_suspend_unlocked(struct drm_fbdev_cma
> > >> *fbdev_cma,
> > >> - bool state)
> > >> -{
> > >> - if (fbdev_cma)
> > >> -
> > >> drm_fb_helper_set_suspend_unlocked(_cma->fb_helper,
> > >> -
Re: [PATCH v2] arm64: dts: renesas: r8a77980: add thermal support
Hi Geert,
On 2018-10-11 09:02:22 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Thu, Oct 11, 2018 at 12:11 AM Niklas Söderlund
> wrote:
> > On 2018-10-10 22:18:11 +0300, Sergei Shtylyov wrote:
> > > Describe THS/CIVM in the R8A77980 device trees.
> > >
> > > Signed-off-by: Sergei Shtylyov
>
> > > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> > > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> > > @@ -330,6 +330,19 @@
> > > #power-domain-cells = <1>;
> > > };
> > >
> > > + tsc: thermal@e6198000 {
> > > + compatible = "renesas,r8a77980-thermal";
> > > + reg = <0 0xe6198000 0 0x100>,
> > > + <0 0xe61a 0 0x100>;
> > > + interrupts = ,
> > > + ,
> > > + ;
> > > + clocks = < CPG_MOD 522>;
> > > + power-domains = < R8A77980_PD_ALWAYS_ON>;
> > > + resets = < 522>;
> > > + #thermal-sensor-cells = <1>;
> >
> > The status property is missing but as you told me in v1 it should not
> > matter. I will leave it for Simon to decide if he wants it to keep it
> > consistent with other SoC or if we should remove it from the other dtsi
> > files. In any case with or without the status property.
>
> Forgot to review commit c79661eb5060e2bf ("arm64: dts: renesas: Remove
> unneeded status from thermal nodes")? ;-)
Not only that also reviewing using the context from v4.19-rc1 which of
course is not correct for dtsi patches, thanks for enlightening me :-)
--
Regards,
Niklas Söderlund
Re: [PATCH v2] arm64: dts: renesas: r8a77980: add thermal support
Hi Niklas,
On Thu, Oct 11, 2018 at 12:11 AM Niklas Söderlund
wrote:
> On 2018-10-10 22:18:11 +0300, Sergei Shtylyov wrote:
> > Describe THS/CIVM in the R8A77980 device trees.
> >
> > Signed-off-by: Sergei Shtylyov
> > --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> > +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> > @@ -330,6 +330,19 @@
> > #power-domain-cells = <1>;
> > };
> >
> > + tsc: thermal@e6198000 {
> > + compatible = "renesas,r8a77980-thermal";
> > + reg = <0 0xe6198000 0 0x100>,
> > + <0 0xe61a 0 0x100>;
> > + interrupts = ,
> > + ,
> > + ;
> > + clocks = < CPG_MOD 522>;
> > + power-domains = < R8A77980_PD_ALWAYS_ON>;
> > + resets = < 522>;
> > + #thermal-sensor-cells = <1>;
>
> The status property is missing but as you told me in v1 it should not
> matter. I will leave it for Simon to decide if he wants it to keep it
> consistent with other SoC or if we should remove it from the other dtsi
> files. In any case with or without the status property.
Forgot to review commit c79661eb5060e2bf ("arm64: dts: renesas: Remove
unneeded status from thermal nodes")? ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
