Re: [GIT/RFC PULL LTSI-4.14] Renesas SoCs and Drivers to v4.17
Hi Geert,
On Tuesday, 31 July 2018 16:48:48 EEST Geert Uytterhoeven wrote:
> On Wed, Jul 11, 2018 at 11:16 PM Laurent Pinchart wrote:
> > On Thursday, 5 July 2018 13:55:00 EEST Geert Uytterhoeven wrote:
> >> On Thu, Jun 14, 2018 at 1:36 PM Simon Horman wrote:
> >>> This series is comprised of backports to v4.14 of the following
> >
> >>> components from their standard as of v4.16 to that of v4.17:
> > [snip]
> >
> >> I subjected it to the same testing I do for each renesas-drivers
> >> release.
> >
> >> Regressions from v4.14.48:
> > [snip]
> >
> >> - Koelsch, Salvator-X (R-Car M3-W), Salvator-XS (R-Car H3 ES2.0):
> >> +rcar-du feb0.display: no connector for encoder
> >>
> >> /soc/lvds@feb9, skipping
> >>
> >> Laurent: do you know what's missing?
> >
> > That message is printed when no connector node is linked in DT through OF
> > graph to the encoder DT node output port. That's expected in this case as
> > we have an LVDS encoder, but not connected panel. However,
> > rcar_du_encoders_init_one() should return before printing that message due
> > to
> >
> > if (!of_device_is_available(entity)) {
> > dev_dbg(rcdu->dev,
> > "connected entity %pOF is disabled, skipping\n",
> > entity);
> > return -ENODEV;
> > }
> >
> > as the LVDS encoder nodes in DT should be disabled.
>
> The LVDS encoder nodes were enabled in the following commits:
> - e5c3f4707f3956a2 ("ARM: dts: r8a7791: Convert to new LVDS DT bindings"),
> for Koelsch and Porter, but none of them has a connected panel?
> - 15a1ff30d8f9bd83 ("ARM: dts: r8a7790: Convert to new LVDS DT bindings"),
> for both LVDS instances on Lager, but the second one doesn't have a panel
> connected?
>
> edb0c3affe5214a2 ("ARM: dts: r8a7793: Convert to new LVDS DT bindings")
> for Gose did it right, though.
You're right, disabling the LVDS encoders there would make sense. I'll submit
a patch to fix that.
--
Regards,
Laurent Pinchart
Re: [GIT/RFC PULL LTSI-4.14] Renesas SoCs and Drivers to v4.17
Hi Laurent,
On Wed, Jul 11, 2018 at 11:16 PM Laurent Pinchart
wrote:
> On Thursday, 5 July 2018 13:55:00 EEST Geert Uytterhoeven wrote:
> > On Thu, Jun 14, 2018 at 1:36 PM Simon Horman wrote:
> > > This series is comprised of backports to v4.14 of the following
> > > components from their standard as of v4.16 to that of v4.17:
>
> [snip]
>
> > I subjected it to the same testing I do for each renesas-drivers release.
> >
> > Regressions from v4.14.48:
>
> [snip]
>
> > - Koelsch, Salvator-X (R-Car M3-W), Salvator-XS (R-Car H3 ES2.0):
> >
> > +rcar-du feb0.display: no connector for encoder
> > /soc/lvds@feb9, skipping
> >
> > Laurent: do you know what's missing?
>
> That message is printed when no connector node is linked in DT through OF
> graph to the encoder DT node output port. That's expected in this case as we
> have an LVDS encoder, but not connected panel. However,
> rcar_du_encoders_init_one() should return before printing that message due to
>
> if (!of_device_is_available(entity)) {
> dev_dbg(rcdu->dev,
> "connected entity %pOF is disabled, skipping\n",
> entity);
> return -ENODEV;
> }
>
> as the LVDS encoder nodes in DT should be disabled.
The LVDS encoder nodes were enabled in the following commits:
- e5c3f4707f3956a2 ("ARM: dts: r8a7791: Convert to new LVDS DT bindings"),
for Koelsch and Porter, but none of them has a connected panel?
- 15a1ff30d8f9bd83 ("ARM: dts: r8a7790: Convert to new LVDS DT bindings"),
for both LVDS instances on Lager, but the second one doesn't have a panel
connected?
edb0c3affe5214a2 ("ARM: dts: r8a7793: Convert to new LVDS DT bindings")
for Gose did it right, though.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [GIT/RFC PULL LTSI-4.14] Renesas SoCs and Drivers to v4.17
Hi Geert,
On Thursday, 5 July 2018 13:55:00 EEST Geert Uytterhoeven wrote:
> On Thu, Jun 14, 2018 at 1:36 PM Simon Horman wrote:
> > This series is comprised of backports to v4.14 of the following
> > components from their standard as of v4.16 to that of v4.17:
[snip]
> I subjected it to the same testing I do for each renesas-drivers release.
>
> Regressions from v4.14.48:
[snip]
> - Koelsch, Salvator-X (R-Car M3-W), Salvator-XS (R-Car H3 ES2.0):
>
> +rcar-du feb0.display: no connector for encoder
> /soc/lvds@feb9, skipping
>
> Laurent: do you know what's missing?
That message is printed when no connector node is linked in DT through OF
graph to the encoder DT node output port. That's expected in this case as we
have an LVDS encoder, but not connected panel. However,
rcar_du_encoders_init_one() should return before printing that message due to
if (!of_device_is_available(entity)) {
dev_dbg(rcdu->dev,
"connected entity %pOF is disabled, skipping\n",
entity);
return -ENODEV;
}
as the LVDS encoder nodes in DT should be disabled.
--
Regards,
Laurent Pinchart
Re: [GIT/RFC PULL LTSI-4.14] Renesas SoCs and Drivers to v4.17
On Thu, Jul 05, 2018 at 12:55:00PM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > CC Laurent, Wolfram, Greg. Thanks for the feedback Geert. I'll look at implementing your suggestions.
Re: [GIT/RFC PULL LTSI-4.14] Renesas SoCs and Drivers to v4.17
Hi Simon,
CC Laurent, Wolfram, Greg.
On Thu, Jun 14, 2018 at 1:36 PM Simon Horman wrote:
> This series is comprised of backports to v4.14 of the following
> components from their standard as of v4.16 to that of v4.17:
> * at24
> * cpg
> * dw-hdmi
> * gen3
> * gpio-rcar
> * i2c-rcar
> * i2c-sh-mobile
> * ipmmu-vmsa
> * irq-renesas-irqc
> * m25p80
> * mach-shmobile
> * pci-rcar-gen2
> * pcie-rcar
> * phy-micrel
> * ravb
> * rcar-can
> * rcar-dmac
> * rcar-du
> * rcar-snd
> * rcar-thermal
> * rcar-vin
> * renesas-sdhi
> * renesas-soc-id
> * sata-rcar
> * sh-drivers
> * sh-eth
> * sh-flctl
> * sh-mmcif
> * sh-mobile-ceu-camera
> * sh-msiof
> * sh-pfc
> * sh-sci
> * smsc911x
> * sysc
> * usb3-peri
> * usbhs
> * vsp1
> * watchdog
> * xhci-plat
> * xhci-rcar
>
> And limited backport of the following to provide dependencies for the above:
> * drm-tilcdc-compat
> * of-overlay
>
> This is intended as part of a dry-run for backporting components used by
> Renesas SoCs from v4.15, v4.16, v4.17 and beyond to v4.14.
>
> In posting this work I am not implying anything about
> decisions on the base of the LTSI release will be.
>
> There are 381 patches.
>
> This is based on similar backports of components to their standard as of
> v4.16, posted as "[GIT/RFC PULL LTSI-4.14] Renesas SoCs and Drivers to v4.16"
> and tagged as backport/v4.14.48/snapshot-to-v4.16-flattened.
>
> As this work is for informational purposes I do not expect these patches
> to be imported to quilt by Greg at this time. However, if you would like to
> do so and rebasing would help please feel free to ask me to do so.
>
>
> The following changes since commit 6485613bce7106b963ce9a9dd8b6d434c26b1bfd:
>
> tty: serial: sh-sci: Add default for number of ports for compile-testing
> (2018-06-14 10:31:17 +0200)
>
> are available in the git repository at:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-backport.git
> tags/backport/v4.14.48/snapshot-to-v4.17-flattened
Thank you!
I subjected it to the same testing I do for each renesas-drivers release.
Regressions from v4.14.48:
- Armadillo800EVA: rtc-s35390a is no longer detected
-i2c-gpio i2c-2: using pins 208 (SDA) and 91 (SCL)
-rtc-s35390a 0-0030: clock needs to be set
-rtc-s35390a 0-0030: rtc core: registered rtc-s35390a as rtc0
-rtc-s35390a 0-0030: setting system clock to 2000-01-01
00:59:36 UTC (946688376)
+hctosys: unable to open rtc device (rtc0)
Commit 8a3e7dbfff3e7ecf ("ARM: dts: armadillo800eva: Convert to named
i2c-gpio bindings") refers to the following two commits, that haven't
been backported yet:
7d29f509d2cfd807 dt-bindings: i2c: i2c-gpio: Add support for named gpios
05c74778858d7d99 i2c: gpio: Add support for named gpios in DT
However, the second one depends on:
b2e6392f8133 i2c: gpio: Convert to use descriptors
f926dfc112bc6cf4 gpio: Make it possible for consumers to
enforce open drain
7bb75029ef348386 i2c: gpio: Enforce open drain through gpiolib
b9ab0517efc0111b i2c: gpio: Local vars in probe
So you need to backport those, too.
In addition, you want the bugfix for 7bb75029ef348386 in v4.18-rc3:
12b731dd46d9ee64 i2c: gpio: initialize SCL to HIGH again
and (untested):
326345f995a83e32 MIPS: pb44: Fix i2c-gpio GPIO descriptor table
f59c303b59b7404e ARM: Fix i2c-gpio GPIO descriptor tables
d82e99a6f9b38cb1 ARM: sa1100: simpad: Correct I2C GPIO offsets
The alternative is to drop 8a3e7dbfff3e7ecf. And all other commits
using "sda-gpios" and "scl-gpios":
7c7e63e46cd82723 ("ARM: dts: lager: Convert to named i2c-gpio bindings
32ece1c70f53ed4c ("ARM: dts: koelsch: Convert to named i2c-gpio bindings
43f0cad95985dc0b ("ARM: dts: alt: Convert to named i2c-gpio bindings
a892ce4316028a72 ("ARM: dts: lager: use demuxer for IIC2/I2C2
fcf4d437ff187c69 ("ARM: dts: koelsch: use demuxer for I2C2
834871be58b3a223 ("ARM: dts: koelsch: use demuxer for I2C4
d24106e3ef0bb765 ("ARM: dts: porter: use demuxer for I2C2
84ae7ad42449c06a ("ARM: dts: alt: use demuxer for I2C1
239ed9e9f50e7f04 ("ARM: dts: silk: use demuxer for I2C1
07599c77e3701606 ("ARM: dts: gose: use demuxer for I2C2
d156ad234e1f92a5 ("ARM: dts: gose: use demuxer for I2C4
Note that I didn't notice any ill effects on Koelsch (e.g. the ADV7180
is still detected). Presumably i2c-demux-pinctrl can handle the
missing i2c-gpio instances.
- Koelsch, Salvator-X (R-Car M3-W), Salvator-XS (R-Car H3 ES2.0):
+rcar-du feb0.display: no connector for encoder
/soc/lvds@feb9, skipping
Laurent: do you know what's missing?
Other failures (no regressions from v4.14.48):
- Salvator-XS: No network after s2ram wakeup:
+nfs: server 192.168.97.29 not responding, still trying
v4.14.28 already had commit 4df57c45f762d43f ("arm64:
[GIT/RFC PULL LTSI-4.14] Renesas SoCs and Drivers to v4.17
Hi, ** This series is for informational purposes only! ** This series is comprised of backports to v4.14 of the following components from their standard as of v4.16 to that of v4.17: * at24 * cpg * dw-hdmi * gen3 * gpio-rcar * i2c-rcar * i2c-sh-mobile * ipmmu-vmsa * irq-renesas-irqc * m25p80 * mach-shmobile * pci-rcar-gen2 * pcie-rcar * phy-micrel * ravb * rcar-can * rcar-dmac * rcar-du * rcar-snd * rcar-thermal * rcar-vin * renesas-sdhi * renesas-soc-id * sata-rcar * sh-drivers * sh-eth * sh-flctl * sh-mmcif * sh-mobile-ceu-camera * sh-msiof * sh-pfc * sh-sci * smsc911x * sysc * usb3-peri * usbhs * vsp1 * watchdog * xhci-plat * xhci-rcar And limited backport of the following to provide dependencies for the above: * drm-tilcdc-compat * of-overlay This is intended as part of a dry-run for backporting components used by Renesas SoCs from v4.15, v4.16, v4.17 and beyond to v4.14. In posting this work I am not implying anything about decisions on the base of the LTSI release will be. There are 381 patches. This is based on similar backports of components to their standard as of v4.16, posted as "[GIT/RFC PULL LTSI-4.14] Renesas SoCs and Drivers to v4.16" and tagged as backport/v4.14.48/snapshot-to-v4.16-flattened. As this work is for informational purposes I do not expect these patches to be imported to quilt by Greg at this time. However, if you would like to do so and rebasing would help please feel free to ask me to do so. The following changes since commit 6485613bce7106b963ce9a9dd8b6d434c26b1bfd: tty: serial: sh-sci: Add default for number of ports for compile-testing (2018-06-14 10:31:17 +0200) are available in the git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas-backport.git tags/backport/v4.14.48/snapshot-to-v4.17-flattened for you to fetch changes up to 3e69ed4311e31be8084d65159d65a6973616c18f: serial: sh-sci: Document r8a77470 bindings (2018-06-14 10:58:52 +0200) LTSI-v4.14 Preparation for Renesas SoCs (to v4.17) Base: * v4.14.48 * Similar backport of components for Renesas SoCs to v4.16 Backports of the following components to their standard as of v4.17: * at24 * cpg * dw-hdmi * gen3 * gpio-rcar * i2c-rcar * i2c-sh-mobile * ipmmu-vmsa * irq-renesas-irqc * m25p80 * mach-shmobile * pci-rcar-gen2 * pcie-rcar * phy-micrel * ravb * rcar-can * rcar-dmac * rcar-du * rcar-snd * rcar-thermal * rcar-vin * renesas-sdhi * renesas-soc-id * sata-rcar * sh-drivers * sh-eth * sh-flctl * sh-mmcif * sh-mobile-ceu-camera * sh-msiof * sh-pfc * sh-sci * smsc911x * sysc * usb3-peri * usbhs * vsp1 * watchdog * xhci-plat * xhci-rcar Limited backport of the following to provide dependencies for the above: * drm-tilcdc-compat * of-overlay Amit Kucheria (3): arm64: defconfig: Enable the APCS IPC driver on Qualcomm platforms arm64: defconfig: enable thermal sensor on QCOM platforms arm64: defconfig: enable more cpufreq governors Ard Biesheuvel (2): arm64: defconfig: add newly added accelerated crypto modules arm64: defconfig: add support for Socionext SynQuacer based platforms Arnd Bergmann (2): ASoC: rsnd: mark PM functions __maybe_unused media: renesas-ceu: mark PM functions as __maybe_unused Biju Das (9): dt-bindings: iommu: ipmmu-vmsa: Add device tree support for r8a774[35] ARM: dts: r8a7743: Add IPMMU DT nodes ARM: dts: r8a7745: Add IPMMU DT nodes ARM: dts: r8a7743: Add VSP support ARM: dts: r8a7745: Add VSP support dt-bindings: PCI: rcar: Add device tree support for r8a7743 dt-bindings: net: renesas-ravb: Add support for r8a77470 SoC dt-bindings: rcar-dmac: Document r8a77470 support serial: sh-sci: Document r8a77470 bindings Colin Ian King (1): PCI: rcar-gen2: Remove duplicated bit-wise or of RCAR_PCI_INT_SIGRETABORT Davidlohr Bueso (1): irqchip/gic: Update supports_deactivate static key to modern api Dien Pham (4): arm64: dts: renesas: r8a7795: Add OPPs table for cpu devices arm64: dts: renesas: r8a7796: Add OPPs table for cpu devices arm64: dts: renesas: r8a7796: Update OPPs to support CA53 dfs arm64: dts: renesas: r8a7795: Update OPPs to support CA53 dfs Dinh Nguyen (1): arm64: defconfig: enable stmmac ethernet to defconfig Fabrizio Castro (15): clk: renesas: r8a7743: Add rwdt clock clk: renesas: r8a7745: Add rwdt clock clk: renesas: r8a7790: Add rwdt clock clk: renesas: r8a7791/r8a7793: Add rwdt clock clk: renesas: r8a7794: Add rwdt clock ARM: dts: iwg20m: Enable cmt0 ARM: dts: iwg22m: Enable cmt0 ARM: shmobile: Add watchdog support ARM: shmobile: rcar-gen2: Add watchdog support dt-bindings: pwm: rcar: Document r8a774[35] PWM bindings dt-bindings: pwm: renesas-tpu: Document r8a774[35] support soc: renesas: rcar-rst:
