Re: [PATCH] arm64: dts: salvator-common: Add PWM-2 channel

[Geert Uytterhoeven]

Hi Hoan,

On Wed, Aug 29, 2018 at 11:33 AM Nguyen An Hoan  wrote:
> From: Hoan Nguyen An 
>
> Add PWM-2 channel(CN28 - pin30) support for Salvator-X

Thanks for your patch!

Please explain why this is useful. Usually we do not enable random functionality
on expansion connectors.

In this case, this even has an (undocumented) impact on on-board devices,
as the signal is also connected to the BD9571MWV PMIC.
(Perhaps that was the actual intention of this patch? ;-) If yes,
please explain)

Thanks!

Gr{oetje,eeting}s,

Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCH] arm64: dts: salvator-common: Add PWM-2 channel

[Nguyen An Hoan]

From: Hoan Nguyen An 

Add PWM-2 channel(CN28 - pin30) support for Salvator-X

Signed-off-by: Hoan Nguyen An 
---
 arch/arm64/boot/dts/renesas/salvator-common.dtsi | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi 
b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index 7d3d866..1234f91 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -572,6 +572,11 @@
function = "pwm1";
};
 
+   pwm2_pins: pwm2 {
+   groups = "pwm2_a";
+   function = "pwm2";
+   };  
+   
scif1_pins: scif1 {
groups = "scif1_data_a", "scif1_ctrl";
function = "scif1";
@@ -669,6 +674,12 @@
status = "okay";
 };
 
+&pwm2 {
+   pinctrl-0 = <&pwm2_pins>;
+   pinctrl-names = "default";
+   status = "okay";
+};
+
 &rcar_sound {
pinctrl-0 = <&sound_pins &sound_clk_pins>;
pinctrl-names = "default";
-- 
2.7.4