Re: [PATCH] drm/bridge: adv7511: add support for the 2nd chip

[Archit Taneja]

Hi,

On 9/2/2016 2:13 AM, Sergei Shtylyov wrote:

The Renesas Wheat board has 2 ADV7513 chips on the same I2C bus, however
the ADV751x driver only supports 1 chip as  it tries to assign the packet/
EDID/CEC  memory I2C devices  to the fixed I2C addresses. Assign these I2C
addresses at the fixed offsets (derived from the programming guide) from
the  main register map address  instead...

Signed-off-by: Sergei Shtylyov 

---
The patch is against David Airlie's 'linux.git' repo's 'drm-next' branch.

  drivers/gpu/drm/bridge/adv7511/adv7511_drv.c |   12 ++--
  1 file changed, 6 insertions(+), 6 deletions(-)

Index: linux/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
===
--- linux.orig/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ linux/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -922,15 +922,13 @@ static int adv7511_parse_dt(struct devic
return 0;
  }

-static const int edid_i2c_addr = 0x7e;
-static const int packet_i2c_addr = 0x70;
-static const int cec_i2c_addr = 0x78;
-
  static int adv7511_probe(struct i2c_client *i2c, const struct i2c_device_id 
*id)
  {
struct adv7511_link_config link_config;
struct adv7511 *adv7511;
struct device *dev = >dev;
+   unsigned int main_i2c_addr = i2c->addr << 1;
+   unsigned int edid_i2c_addr = main_i2c_addr + 4;
unsigned int val;
int ret;

@@ -991,8 +989,10 @@ static int adv7511_probe(struct i2c_clie

regmap_write(adv7511->regmap, ADV7511_REG_EDID_I2C_ADDR, edid_i2c_addr);
regmap_write(adv7511->regmap, ADV7511_REG_PACKET_I2C_ADDR,
-packet_i2c_addr);
-   regmap_write(adv7511->regmap, ADV7511_REG_CEC_I2C_ADDR, cec_i2c_addr);
+main_i2c_addr - 0xa);
+   regmap_write(adv7511->regmap, ADV7511_REG_CEC_I2C_ADDR,
+main_i2c_addr - 2);


The adv7533.c part of the driver uses cec_i2c_addr to create a another
dummy i2c device for CEC. Could you update this patch to derive the
cec address from the main i2c address for the ADV7533 part too?

Thanks,
Archit


+
adv7511_packet_disable(adv7511, 0x);

adv7511->i2c_main = i2c;

___
dri-devel mailing list
dri-de...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel



--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[PATCH] drm/bridge: adv7511: add support for the 2nd chip

[Sergei Shtylyov]

The Renesas Wheat board has 2 ADV7513 chips on the same I2C bus, however
the ADV751x driver only supports 1 chip as  it tries to assign the packet/
EDID/CEC  memory I2C devices  to the fixed I2C addresses. Assign these I2C
addresses at the fixed offsets (derived from the programming guide) from
the  main register map address  instead...

Signed-off-by: Sergei Shtylyov 

---
The patch is against David Airlie's 'linux.git' repo's 'drm-next' branch.

 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c |   12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

Index: linux/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
===
--- linux.orig/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ linux/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -922,15 +922,13 @@ static int adv7511_parse_dt(struct devic
return 0;
 }
 
-static const int edid_i2c_addr = 0x7e;
-static const int packet_i2c_addr = 0x70;
-static const int cec_i2c_addr = 0x78;
-
 static int adv7511_probe(struct i2c_client *i2c, const struct i2c_device_id 
*id)
 {
struct adv7511_link_config link_config;
struct adv7511 *adv7511;
struct device *dev = >dev;
+   unsigned int main_i2c_addr = i2c->addr << 1;
+   unsigned int edid_i2c_addr = main_i2c_addr + 4;
unsigned int val;
int ret;
 
@@ -991,8 +989,10 @@ static int adv7511_probe(struct i2c_clie
 
regmap_write(adv7511->regmap, ADV7511_REG_EDID_I2C_ADDR, edid_i2c_addr);
regmap_write(adv7511->regmap, ADV7511_REG_PACKET_I2C_ADDR,
-packet_i2c_addr);
-   regmap_write(adv7511->regmap, ADV7511_REG_CEC_I2C_ADDR, cec_i2c_addr);
+main_i2c_addr - 0xa);
+   regmap_write(adv7511->regmap, ADV7511_REG_CEC_I2C_ADDR,
+main_i2c_addr - 2);
+
adv7511_packet_disable(adv7511, 0x);
 
adv7511->i2c_main = i2c;