Re: [PATCH] mmc: tmio: make a cast explicit

2016-06-03 Thread Ulf Hansson 
On 27 May 2016 at 14:10, Wolfram Sang  wrote:
> From: Wolfram Sang 
>
> Sparse complains about the implicit cast. Making it explicit is indeed
> better coding style.
>
> Signed-off-by: Wolfram Sang 

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/tmio_mmc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h
> index 7d1174c789219a..5f2919ceced12d 100644
> --- a/drivers/mmc/host/tmio_mmc.h
> +++ b/drivers/mmc/host/tmio_mmc.h
> @@ -265,7 +265,7 @@ static inline void sd_ctrl_write16_rep(struct 
> tmio_mmc_host *host, int addr,
>
>  static inline void sd_ctrl_write32_as_16_and_16(struct tmio_mmc_host *host, 
> int addr, u32 val)
>  {
> -   writew(val, host->ctl + (addr << host->bus_shift));
> +   writew(val & 0x, host->ctl + (addr << host->bus_shift));
> writew(val >> 16, host->ctl + ((addr + 2) << host->bus_shift));
>  }
>
> --
> 2.8.1
>

[PATCH] mmc: tmio: make a cast explicit

2016-05-27 Thread Wolfram Sang 
From: Wolfram Sang 

Sparse complains about the implicit cast. Making it explicit is indeed
better coding style.

Signed-off-by: Wolfram Sang 
---
 drivers/mmc/host/tmio_mmc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h
index 7d1174c789219a..5f2919ceced12d 100644
--- a/drivers/mmc/host/tmio_mmc.h
+++ b/drivers/mmc/host/tmio_mmc.h
@@ -265,7 +265,7 @@ static inline void sd_ctrl_write16_rep(struct tmio_mmc_host 
*host, int addr,
 
 static inline void sd_ctrl_write32_as_16_and_16(struct tmio_mmc_host *host, 
int addr, u32 val)
 {
-   writew(val, host->ctl + (addr << host->bus_shift));
+   writew(val & 0x, host->ctl + (addr << host->bus_shift));
writew(val >> 16, host->ctl + ((addr + 2) << host->bus_shift));
 }
 
-- 
2.8.1