Re: [PATCH] pinctrl: sh-pfc: r8a7792: add missing pinmux data

[Geert Uytterhoeven]

Hi Sergei,

On Thu, Aug 4, 2016 at 3:39 PM, Sergei Shtylyov
 wrote:
> On 08/04/2016 11:04 AM, Linus Walleij wrote:
>
>>> The patch I've based my R8A7792 PFC work on had some VIN pinmux data
>>> missing
>>> and I  just  noticed that while adding the VIN pin groups...
>>>
>>> Signed-off-by: Sergei Shtylyov 

Thank you!

>> This looks like a fix that should go in ASAP?
>
>It would be enough if it gets queued before the patch adding VIN pin
> groups.

As the original "pinctrl: sh-pfc: Add R8A7792 PFC support" isn't in the
pinctrl tree yet, I'll fold your fix into that one.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH] pinctrl: sh-pfc: r8a7792: add missing pinmux data

[Sergei Shtylyov]

On 08/04/2016 11:04 AM, Linus Walleij wrote:


The patch I've based my R8A7792 PFC work on had some VIN pinmux data missing
and I  just  noticed that while adding the VIN pin groups...

Signed-off-by: Sergei Shtylyov 


This looks like a fix that should go in ASAP?


   It would be enough if it gets queued before the patch adding VIN pin groups.

[...]


Yours,
Linus Walleij


MBR, Sergei

Re: [PATCH] pinctrl: sh-pfc: r8a7792: add missing pinmux data

[Linus Walleij]

On Fri, Jul 22, 2016 at 3:51 PM, Sergei Shtylyov
 wrote:

> The patch I've based my R8A7792 PFC work on had some VIN pinmux data missing
> and I  just  noticed that while adding the VIN pin groups...
>
> Signed-off-by: Sergei Shtylyov 

This looks like a fix that should go in ASAP?

Geert, do you want me to apply this directly for fixes with
your ACK?

Yours,
Linus Walleij

[PATCH] pinctrl: sh-pfc: r8a7792: add missing pinmux data

[Sergei Shtylyov]

The patch I've based my R8A7792 PFC work on had some VIN pinmux data missing
and I  just  noticed that while adding the VIN pin groups...

Signed-off-by: Sergei Shtylyov 

---
The patch is against the 'devel' branch of Linus Walleij's 'linux-pinctrl.git'
repo plus my 5 R8A7792 PFC patches  posted before...

 drivers/pinctrl/sh-pfc/pfc-r8a7792.c |3 +++
 1 file changed, 3 insertions(+)

Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7792.c
===
--- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pfc-r8a7792.c
+++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7792.c
@@ -622,6 +622,7 @@ static const u16 pinmux_data[] = {
PINMUX_IPSR_GPSR(IP4_10_9, VI0_D18_R2),
PINMUX_IPSR_MSEL(IP4_10_9, VI1_D14_G6_Y6, SEL_VI1_0),
PINMUX_IPSR_GPSR(IP4_12_11, VI4_D4_C4),
+   PINMUX_IPSR_GPSR(IP4_12_11, VI0_D19_R3),
PINMUX_IPSR_MSEL(IP4_12_11, VI1_D15_G7_Y7, SEL_VI1_0),
PINMUX_IPSR_GPSR(IP4_14_13, VI4_D5_C5),
PINMUX_IPSR_GPSR(IP4_14_13, VI0_D20_R4),
@@ -633,6 +634,8 @@ static const u16 pinmux_data[] = {
PINMUX_IPSR_GPSR(IP4_18_17, VI0_D22_R6),
PINMUX_IPSR_GPSR(IP4_18_17, VI2_D14_Y6),
PINMUX_IPSR_GPSR(IP4_20_19, VI4_D8_Y0),
+   PINMUX_IPSR_GPSR(IP4_20_19, VI0_D23_R7),
+   PINMUX_IPSR_GPSR(IP4_20_19, VI2_D15_Y7),
PINMUX_IPSR_GPSR(IP4_21, VI4_D9_Y1),
PINMUX_IPSR_GPSR(IP4_21, VI3_D12_Y4),
PINMUX_IPSR_GPSR(IP4_22, VI4_D10_Y2),