Re: [PATCH 05/22] ARM: dts: r8a7744-iwg20m: Add eMMC support
Hi Biju,
On Fri, Nov 30, 2018 at 11:43 AM Biju Das wrote:
> > Subject: Re: [PATCH 05/22] ARM: dts: r8a7744-iwg20m: Add eMMC support
> >
> > On Tue, Nov 27, 2018 at 1:05 PM Biju Das wrote:
> > > Add eMMC support for iWave RZ/G1N Qseven System On Module.
> > >
> > > Signed-off-by: Biju Das
> >
> > Reviewed-by: Geert Uytterhoeven
> >
> > I assume the PCB is the same for RZ/G1M and RZ/G1N, so perhaps this can
> > be factored out in a common .dtsi file, like we did for Salvator-X(S)?
>
> SoM is different between RZ/G1M and RZ/G1N in terms of memory and PCie/SATA.
>
> The only common part in SoM is eMMC,SDHI0 and QSPI flash. So it doesn't make
> sense to factored it out.
>
> What do you think?
OK, then it's fine for me.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
RE: [PATCH 05/22] ARM: dts: r8a7744-iwg20m: Add eMMC support
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH 05/22] ARM: dts: r8a7744-iwg20m: Add eMMC support > > On Tue, Nov 27, 2018 at 1:05 PM Biju Das wrote: > > Add eMMC support for iWave RZ/G1N Qseven System On Module. > > > > Signed-off-by: Biju Das > > Reviewed-by: Geert Uytterhoeven > > I assume the PCB is the same for RZ/G1M and RZ/G1N, so perhaps this can > be factored out in a common .dtsi file, like we did for Salvator-X(S)? SoM is different between RZ/G1M and RZ/G1N in terms of memory and PCie/SATA. The only common part in SoM is eMMC,SDHI0 and QSPI flash. So it doesn't make sense to factored it out. What do you think? Regards, Biju Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Re: [PATCH 05/22] ARM: dts: r8a7744-iwg20m: Add eMMC support
On Tue, Nov 27, 2018 at 1:05 PM Biju Das wrote:
> Add eMMC support for iWave RZ/G1N Qseven System On Module.
>
> Signed-off-by: Biju Das
Reviewed-by: Geert Uytterhoeven
I assume the PCB is the same for RZ/G1M and RZ/G1N, so perhaps this
can be factored out in a common .dtsi file, like we did for Salvator-X(S)?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH 05/22] ARM: dts: r8a7744-iwg20m: Add eMMC support
On Tue, Nov 27, 2018 at 11:56:18AM +, Biju Das wrote: > Add eMMC support for iWave RZ/G1N Qseven System On Module. > > Signed-off-by: Biju Das Thanks, This looks fine to me but I will wait to see if there are other reviews before applying. Reviewed-by: Simon Horman
[PATCH 05/22] ARM: dts: r8a7744-iwg20m: Add eMMC support
Add eMMC support for iWave RZ/G1N Qseven System On Module.
Signed-off-by: Biju Das
---
arch/arm/boot/dts/r8a7744-iwg20m.dtsi | 17 +
1 file changed, 17 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7744-iwg20m.dtsi
b/arch/arm/boot/dts/r8a7744-iwg20m.dtsi
index 6166ae0..1e57b1f 100644
--- a/arch/arm/boot/dts/r8a7744-iwg20m.dtsi
+++ b/arch/arm/boot/dts/r8a7744-iwg20m.dtsi
@@ -29,3 +29,20 @@
_clk {
clock-frequency = <2000>;
};
+
+ {
+ mmcif0_pins: mmc {
+ groups = "mmc_data8_b", "mmc_ctrl";
+ function = "mmc";
+ };
+};
+
+ {
+ pinctrl-0 = <_pins>;
+ pinctrl-names = "default";
+
+ vmmc-supply = <_3p3v>;
+ bus-width = <8>;
+ non-removable;
+ status = "okay";
+};
--
2.7.4
