Re: [PATCH 06/16] drm/rcar-du: removed optional dummy crtc mode_fixup function.

[Laurent Pinchart]

Hi Carlos,

Thank you for the patch.

On Tuesday 16 February 2016 14:18:00 Carlos Palminha wrote:
> This patch set nukes all the dummy crtc mode_fixup implementations.
> (made on top of Daniel topic/drm-misc branch)
> 
> Signed-off-by: Carlos Palminha 

Reviewed-by: Laurent Pinchart 

> ---
>  drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 9 -
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
> b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c index 4ec80ae..627abc80 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
> @@ -468,14 +468,6 @@ static void rcar_du_crtc_disable(struct drm_crtc *crtc)
> rcrtc->outputs = 0;
>  }
> 
> -static bool rcar_du_crtc_mode_fixup(struct drm_crtc *crtc,
> - const struct drm_display_mode *mode,
> - struct drm_display_mode *adjusted_mode)
> -{
> - /* TODO Fixup modes */
> - return true;
> -}
> -
>  static void rcar_du_crtc_atomic_begin(struct drm_crtc *crtc,
> struct drm_crtc_state *old_crtc_state)
>  {
> @@ -502,7 +494,6 @@ static void rcar_du_crtc_atomic_flush(struct drm_crtc
> *crtc, }
> 
>  static const struct drm_crtc_helper_funcs crtc_helper_funcs = {
> - .mode_fixup = rcar_du_crtc_mode_fixup,
>   .disable = rcar_du_crtc_disable,
>   .enable = rcar_du_crtc_enable,
>   .atomic_begin = rcar_du_crtc_atomic_begin,

-- 
Regards,

Laurent Pinchart

[PATCH 06/16] drm/rcar-du: removed optional dummy crtc mode_fixup function.

[Carlos Palminha]

This patch set nukes all the dummy crtc mode_fixup implementations.
(made on top of Daniel topic/drm-misc branch)

Signed-off-by: Carlos Palminha 
---
 drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 9 -
 1 file changed, 9 deletions(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c 
b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
index 4ec80ae..627abc80 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
@@ -468,14 +468,6 @@ static void rcar_du_crtc_disable(struct drm_crtc *crtc)
rcrtc->outputs = 0;
 }
 
-static bool rcar_du_crtc_mode_fixup(struct drm_crtc *crtc,
-   const struct drm_display_mode *mode,
-   struct drm_display_mode *adjusted_mode)
-{
-   /* TODO Fixup modes */
-   return true;
-}
-
 static void rcar_du_crtc_atomic_begin(struct drm_crtc *crtc,
  struct drm_crtc_state *old_crtc_state)
 {
@@ -502,7 +494,6 @@ static void rcar_du_crtc_atomic_flush(struct drm_crtc *crtc,
 }
 
 static const struct drm_crtc_helper_funcs crtc_helper_funcs = {
-   .mode_fixup = rcar_du_crtc_mode_fixup,
.disable = rcar_du_crtc_disable,
.enable = rcar_du_crtc_enable,
.atomic_begin = rcar_du_crtc_atomic_begin,
-- 
2.5.0