Re: [PATCH 08/22] ARM: dts: r8a7744: Add USB-DMAC and HSUSB device nodes

[Geert Uytterhoeven]

On Tue, Nov 27, 2018 at 1:05 PM Biju Das  wrote:
> Add usb dmac and hsusb device nodes on RZ/G1N SoC dtsi.
>
> Signed-off-by: Biju Das 

Reviewed-by: Geert Uytterhoeven 

Gr{oetje,eeting}s,

Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH 08/22] ARM: dts: r8a7744: Add USB-DMAC and HSUSB device nodes

[Simon Horman]

On Tue, Nov 27, 2018 at 11:56:21AM +, Biju Das wrote:
> Add usb dmac and hsusb device nodes on RZ/G1N SoC dtsi.
> 
> Signed-off-by: Biju Das 

Thanks,

This looks fine to me but I will wait to see if there are other reviews
before applying.

Reviewed-by: Simon Horman 

[PATCH 08/22] ARM: dts: r8a7744: Add USB-DMAC and HSUSB device nodes

[Biju Das]

Add usb dmac and hsusb device nodes on RZ/G1N SoC dtsi.

Signed-off-by: Biju Das 
---
 arch/arm/boot/dts/r8a7744.dtsi | 42 +-
 1 file changed, 41 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/r8a7744.dtsi b/arch/arm/boot/dts/r8a7744.dtsi
index 3549ee1..118a596 100644
--- a/arch/arm/boot/dts/r8a7744.dtsi
+++ b/arch/arm/boot/dts/r8a7744.dtsi
@@ -463,8 +463,20 @@
};
 
hsusb: usb@e659 {
+   compatible = "renesas,usbhs-r8a7744",
+"renesas,rcar-gen2-usbhs";
reg = <0 0xe659 0 0x100>;
-   /* placeholder */
+   interrupts = ;
+   clocks = < CPG_MOD 704>;
+   dmas = <_dmac0 0>, <_dmac0 1>,
+  <_dmac1 0>, <_dmac1 1>;
+   dma-names = "ch0", "ch1", "ch2", "ch3";
+   power-domains = < R8A7744_PD_ALWAYS_ON>;
+   resets = < 704>;
+   renesas,buswait = <4>;
+   phys = < 1>;
+   phy-names = "usb";
+   status = "disabled";
};
 
usbphy: usb-phy@e6590100 {
@@ -489,6 +501,34 @@
};
};
 
+   usb_dmac0: dma-controller@e65a {
+   compatible = "renesas,r8a7744-usb-dmac",
+"renesas,usb-dmac";
+   reg = <0 0xe65a 0 0x100>;
+   interrupts = ;
+   interrupt-names = "ch0", "ch1";
+   clocks = < CPG_MOD 330>;
+   power-domains = < R8A7744_PD_ALWAYS_ON>;
+   resets = < 330>;
+   #dma-cells = <1>;
+   dma-channels = <2>;
+   };
+
+   usb_dmac1: dma-controller@e65b {
+   compatible = "renesas,r8a7744-usb-dmac",
+"renesas,usb-dmac";
+   reg = <0 0xe65b 0 0x100>;
+   interrupts = ;
+   interrupt-names = "ch0", "ch1";
+   clocks = < CPG_MOD 331>;
+   power-domains = < R8A7744_PD_ALWAYS_ON>;
+   resets = < 331>;
+   #dma-cells = <1>;
+   dma-channels = <2>;
+   };
+
dmac0: dma-controller@e670 {
compatible = "renesas,dmac-r8a7744",
 "renesas,rcar-dmac";
-- 
2.7.4