Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add MMC support

2018-04-24 Thread Simon Horman 
On Fri, Apr 20, 2018 at 10:06:03PM +0300, Sergei Shtylyov wrote:
> On 04/20/2018 12:58 PM, Simon Horman wrote:
> 
> >> Define the generic R8A77980 part of the MMC0 (SDHI2) device node.
> >>
> >> Signed-off-by: Sergei Shtylyov 
> >>
> >> ---
> >>  arch/arm64/boot/dts/renesas/r8a77980.dtsi |   12 
> >>  1 file changed, 12 insertions(+)
> >>
> >> Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> >> ===
> >> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> >> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> >> @@ -371,6 +371,18 @@
> >>dma-channels = <16>;
> >>};
> >>  
> >> +  mmc0: mmc@ee14 {
> > 
> > Please use sdhi2: sd@ee14 for consistency with other SoCs
> > (I refereed to the r8a7795).
> 
>Mmm... note that this controller has MMC signals (8 data bits, DS, no 
> CD/WP),
> see manual v0.55. I think it's more correct to call it MMC0 (trken from the
> manual as well)...

Ok, point taken. I've applied this. But in general I would like the
dtsi files to be consistent where it makes sense.

Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add MMC support

2018-04-20 Thread Sergei Shtylyov 
On 04/20/2018 12:58 PM, Simon Horman wrote:

>> Define the generic R8A77980 part of the MMC0 (SDHI2) device node.
>>
>> Signed-off-by: Sergei Shtylyov 
>>
>> ---
>>  arch/arm64/boot/dts/renesas/r8a77980.dtsi |   12 
>>  1 file changed, 12 insertions(+)
>>
>> Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> ===
>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> @@ -371,6 +371,18 @@
>>  dma-channels = <16>;
>>  };
>>  
>> +mmc0: mmc@ee14 {
> 
> Please use sdhi2: sd@ee14 for consistency with other SoCs
> (I refereed to the r8a7795).

   Mmm... note that this controller has MMC signals (8 data bits, DS, no CD/WP),
see manual v0.55. I think it's more correct to call it MMC0 (trken from the
manual as well)...

MBR, Sergei

Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add MMC support

2018-04-20 Thread Simon Horman 
On Sat, Apr 14, 2018 at 10:27:04PM +0300, Sergei Shtylyov wrote:
> Define the generic R8A77980 part of the MMC0 (SDHI2) device node.
> 
> Signed-off-by: Sergei Shtylyov 
> 
> ---
>  arch/arm64/boot/dts/renesas/r8a77980.dtsi |   12 
>  1 file changed, 12 insertions(+)
> 
> Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> ===
> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
> @@ -371,6 +371,18 @@
>   dma-channels = <16>;
>   };
>  
> + mmc0: mmc@ee14 {

Please use sdhi2: sd@ee14 for consistency with other SoCs
(I refereed to the r8a7795).

> + compatible = "renesas,sdhi-r8a77980",
> +  "renesas,rcar-gen3-sdhi";
> + reg = <0 0xee14 0 0x2000>;
> + interrupts = ;
> + clocks = <&cpg CPG_MOD 314>;
> + power-domains = <&sysc 32>;
> + resets = <&cpg 314>;
> + max-frequency = <2>;
> + status = "disabled";
> + };
> +
>   gic: interrupt-controller@f101 {
>   compatible = "arm,gic-400";
>   #interrupt-cells = <3>;
>

[PATCH 1/2] arm64: dts: renesas: r8a77980: add MMC support

2018-04-14 Thread Sergei Shtylyov 
Define the generic R8A77980 part of the MMC0 (SDHI2) device node.

Signed-off-by: Sergei Shtylyov 

---
 arch/arm64/boot/dts/renesas/r8a77980.dtsi |   12 
 1 file changed, 12 insertions(+)

Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
===
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
+++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
@@ -371,6 +371,18 @@
dma-channels = <16>;
};
 
+   mmc0: mmc@ee14 {
+   compatible = "renesas,sdhi-r8a77980",
+"renesas,rcar-gen3-sdhi";
+   reg = <0 0xee14 0 0x2000>;
+   interrupts = ;
+   clocks = <&cpg CPG_MOD 314>;
+   power-domains = <&sysc 32>;
+   resets = <&cpg 314>;
+   max-frequency = <2>;
+   status = "disabled";
+   };
+
gic: interrupt-controller@f101 {
compatible = "arm,gic-400";
#interrupt-cells = <3>;