Re: [PATCH 1/2] pinctrl: sh-pfc: r8a7794: add SSI pin groups

2016-02-18 Thread Sergei Shtylyov

Hello.

On 2/18/2016 10:52 AM, Geert Uytterhoeven wrote:


--- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
+++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
@@ -1,9 +1,9 @@
   /*
* r8a7794 processor support - PFC hardware block.
*
- * Copyright (C) 2014 Renesas Electronics Corporation
+ * Copyright (C) 2014-2015 Renesas Electronics Corporation
* Copyright (C) 2015 Renesas Solutions Corp.
- * Copyright (C) 2015 Cogent  Embedded, Inc., 
+ * Copyright (C) 2015-2016 Cogent  Embedded, Inc.,



Geert, could you turn the double space into single?


Sure, done.


   Thank you! Overlooked it. :-/


Gr{oetje,eeting}s,

 Geert


MBR, Sergei



Re: [PATCH 1/2] pinctrl: sh-pfc: r8a7794: add SSI pin groups

2016-02-17 Thread Geert Uytterhoeven
Hi Sergei,

On Wed, Feb 17, 2016 at 11:08 PM, Sergei Shtylyov
 wrote:
>> --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
>> +++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
>> @@ -1,9 +1,9 @@
>>   /*
>>* r8a7794 processor support - PFC hardware block.
>>*
>> - * Copyright (C) 2014 Renesas Electronics Corporation
>> + * Copyright (C) 2014-2015 Renesas Electronics Corporation
>>* Copyright (C) 2015 Renesas Solutions Corp.
>> - * Copyright (C) 2015 Cogent  Embedded, Inc., 
>> + * Copyright (C) 2015-2016 Cogent  Embedded, Inc.,
>> 
>
>
>Geert, could you turn the double space into single?

Sure, done.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


Re: [PATCH 1/2] pinctrl: sh-pfc: r8a7794: add SSI pin groups

2016-02-17 Thread Sergei Shtylyov

On 02/11/2016 01:38 AM, Sergei Shtylyov wrote:


From: Ryo Kataoka 

Add the SSI pin groups to the R8A7794 PFC driver.

[Sergei: fixed inconsistent alternate pin group naming, split SSI5/6 pin
groups into data/control ones, moved SSI7 data B group to its proper place,
fixed  pin names in  the comments to *_pins[], extended Cogent Embedded's
copyright, added the changelog, renamed the patch.]

Signed-off-by: Ryo Kataoka 
Signed-off-by: Sergei Shtylyov 

---
  drivers/pinctrl/sh-pfc/pfc-r8a7794.c |  315 
++-
  1 file changed, 313 insertions(+), 2 deletions(-)

Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
===
--- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
+++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
@@ -1,9 +1,9 @@
  /*
   * r8a7794 processor support - PFC hardware block.
   *
- * Copyright (C) 2014 Renesas Electronics Corporation
+ * Copyright (C) 2014-2015 Renesas Electronics Corporation
   * Copyright (C) 2015 Renesas Solutions Corp.
- * Copyright (C) 2015 Cogent  Embedded, Inc., 
+ * Copyright (C) 2015-2016 Cogent  Embedded, Inc., 


   Geert, could you turn the double space into single?

MBR, Sergei



Re: [PATCH 1/2] pinctrl: sh-pfc: r8a7794: add SSI pin groups

2016-02-15 Thread Linus Walleij
On Wed, Feb 10, 2016 at 11:38 PM, Sergei Shtylyov
 wrote:

> From: Ryo Kataoka 
>
> Add the SSI pin groups to the R8A7794 PFC driver.
>
> [Sergei: fixed inconsistent alternate pin group naming, split SSI5/6 pin
> groups into data/control ones, moved SSI7 data B group to its proper place,
> fixed  pin names in  the comments to *_pins[], extended Cogent Embedded's
> copyright, added the changelog, renamed the patch.]
>
> Signed-off-by: Ryo Kataoka 
> Signed-off-by: Sergei Shtylyov 

These look fine to me, Acked-by for both.

Geert, will you & Laurent review and queue this please.

Yours,
Linus Walleij


[PATCH 1/2] pinctrl: sh-pfc: r8a7794: add SSI pin groups

2016-02-10 Thread Sergei Shtylyov
From: Ryo Kataoka 

Add the SSI pin groups to the R8A7794 PFC driver.

[Sergei: fixed inconsistent alternate pin group naming, split SSI5/6 pin
groups into data/control ones, moved SSI7 data B group to its proper place,
fixed  pin names in  the comments to *_pins[], extended Cogent Embedded's
copyright, added the changelog, renamed the patch.]

Signed-off-by: Ryo Kataoka 
Signed-off-by: Sergei Shtylyov 

---
 drivers/pinctrl/sh-pfc/pfc-r8a7794.c |  315 ++-
 1 file changed, 313 insertions(+), 2 deletions(-)

Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
===
--- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
+++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7794.c
@@ -1,9 +1,9 @@
 /*
  * r8a7794 processor support - PFC hardware block.
  *
- * Copyright (C) 2014 Renesas Electronics Corporation
+ * Copyright (C) 2014-2015 Renesas Electronics Corporation
  * Copyright (C) 2015 Renesas Solutions Corp.
- * Copyright (C) 2015 Cogent  Embedded, Inc., 
+ * Copyright (C) 2015-2016 Cogent  Embedded, Inc., 
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2
@@ -2751,6 +2751,245 @@ static const unsigned int sdhi2_wp_pins[
 static const unsigned int sdhi2_wp_mux[] = {
SD2_WP_MARK,
 };
+/* - SSI  
*/
+static const unsigned int ssi0_data_pins[] = {
+   /* SDATA0 */
+   RCAR_GP_PIN(5, 3),
+};
+static const unsigned int ssi0_data_mux[] = {
+   SSI_SDATA0_MARK,
+};
+static const unsigned int ssi0129_ctrl_pins[] = {
+   /* SCK0129, WS0129 */
+   RCAR_GP_PIN(5, 1), RCAR_GP_PIN(5, 2),
+};
+static const unsigned int ssi0129_ctrl_mux[] = {
+   SSI_SCK0129_MARK, SSI_WS0129_MARK,
+};
+static const unsigned int ssi1_data_pins[] = {
+   /* SDATA1 */
+   RCAR_GP_PIN(5, 13),
+};
+static const unsigned int ssi1_data_mux[] = {
+   SSI_SDATA1_MARK,
+};
+static const unsigned int ssi1_ctrl_pins[] = {
+   /* SCK1, WS1 */
+   RCAR_GP_PIN(5, 11), RCAR_GP_PIN(5, 12),
+};
+static const unsigned int ssi1_ctrl_mux[] = {
+   SSI_SCK1_MARK, SSI_WS1_MARK,
+};
+static const unsigned int ssi1_data_b_pins[] = {
+   /* SDATA1 */
+   RCAR_GP_PIN(4, 13),
+};
+static const unsigned int ssi1_data_b_mux[] = {
+   SSI_SDATA1_B_MARK,
+};
+static const unsigned int ssi1_ctrl_b_pins[] = {
+   /* SCK1, WS1 */
+   RCAR_GP_PIN(4, 11), RCAR_GP_PIN(4, 12),
+};
+static const unsigned int ssi1_ctrl_b_mux[] = {
+   SSI_SCK1_B_MARK, SSI_WS1_B_MARK,
+};
+static const unsigned int ssi2_data_pins[] = {
+   /* SDATA2 */
+   RCAR_GP_PIN(5, 16),
+};
+static const unsigned int ssi2_data_mux[] = {
+   SSI_SDATA2_MARK,
+};
+static const unsigned int ssi2_ctrl_pins[] = {
+   /* SCK2, WS2 */
+   RCAR_GP_PIN(5, 14), RCAR_GP_PIN(5, 15),
+};
+static const unsigned int ssi2_ctrl_mux[] = {
+   SSI_SCK2_MARK, SSI_WS2_MARK,
+};
+static const unsigned int ssi2_data_b_pins[] = {
+   /* SDATA2 */
+   RCAR_GP_PIN(4, 16),
+};
+static const unsigned int ssi2_data_b_mux[] = {
+   SSI_SDATA2_B_MARK,
+};
+static const unsigned int ssi2_ctrl_b_pins[] = {
+   /* SCK2, WS2 */
+   RCAR_GP_PIN(4, 14), RCAR_GP_PIN(4, 15),
+};
+static const unsigned int ssi2_ctrl_b_mux[] = {
+   SSI_SCK2_B_MARK, SSI_WS2_B_MARK,
+};
+static const unsigned int ssi3_data_pins[] = {
+   /* SDATA3 */
+   RCAR_GP_PIN(5, 6),
+};
+static const unsigned int ssi3_data_mux[] = {
+   SSI_SDATA3_MARK
+};
+static const unsigned int ssi34_ctrl_pins[] = {
+   /* SCK34, WS34 */
+   RCAR_GP_PIN(5, 4), RCAR_GP_PIN(5, 5),
+};
+static const unsigned int ssi34_ctrl_mux[] = {
+   SSI_SCK34_MARK, SSI_WS34_MARK,
+};
+static const unsigned int ssi4_data_pins[] = {
+   /* SDATA4 */
+   RCAR_GP_PIN(5, 9),
+};
+static const unsigned int ssi4_data_mux[] = {
+   SSI_SDATA4_MARK,
+};
+static const unsigned int ssi4_ctrl_pins[] = {
+   /* SCK4, WS4 */
+   RCAR_GP_PIN(5, 7), RCAR_GP_PIN(5, 8),
+};
+static const unsigned int ssi4_ctrl_mux[] = {
+   SSI_SCK4_MARK, SSI_WS4_MARK,
+};
+static const unsigned int ssi4_data_b_pins[] = {
+   /* SDATA4 */
+   RCAR_GP_PIN(4, 22),
+};
+static const unsigned int ssi4_data_b_mux[] = {
+   SSI_SDATA4_B_MARK,
+};
+static const unsigned int ssi4_ctrl_b_pins[] = {
+   /* SCK4, WS4 */
+   RCAR_GP_PIN(4, 20), RCAR_GP_PIN(4, 21),
+};
+static const unsigned int ssi4_ctrl_b_mux[] = {
+   SSI_SCK4_B_MARK, SSI_WS4_B_MARK,
+};
+static const unsigned int ssi5_data_pins[] = {
+   /* SDATA5 */
+   RCAR_GP_PIN(4, 26),
+};
+static const unsigned int ssi5_data_mux[] = {
+   SSI_SDATA5_MARK,
+};
+static const unsigned int ssi5_ctrl_pins[] = {
+   /* SCK5, WS5 */
+   RCAR_GP_PIN(4, 24), RCAR_GP_PIN(4, 25),
+};
+static const unsigned int ssi5_ctrl_mux[]