Re: [PATCH 1/2] pinctrl: sh-pfc: r8a77965: add Audio clock pin support

2018-08-28 Thread Geert Uytterhoeven 
Hi Hoan,

On Tue, Aug 28, 2018 at 6:37 AM Nguyen An Hoan  wrote:
> From: Hoan Nguyen An 
>
> Add Audio clock pin support for r8a77965
>
> Signed-off-by: Hoan Nguyen An 

Thanks for the update!

Reviewed-by: Geert Uytterhoeven 
i.e. will queue in sh-pfc-for-v4.20.

Gr{oetje,eeting}s,

Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCH 1/2] pinctrl: sh-pfc: r8a77965: add Audio clock pin support

2018-08-27 Thread Nguyen An Hoan 
From: Hoan Nguyen An 

Add Audio clock pin support for r8a77965

Signed-off-by: Hoan Nguyen An 
---
 drivers/pinctrl/sh-pfc/pfc-r8a77965.c | 160 ++
 1 file changed, 160 insertions(+)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77965.c 
b/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
index 72ccd1a..46241c0 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
@@ -1575,6 +1575,128 @@ static const struct sh_pfc_pin pinmux_pins[] = {
SH_PFC_PIN_NAMED_CFG(ROW_GROUP_A('T'), 30, ASEBRK, CFG_FLAGS),
 };
 
+/* - AUDIO CLOCK  
*/
+static const unsigned int audio_clk_a_a_pins[] = {
+   /* CLK A */
+   RCAR_GP_PIN(6, 22),
+};
+static const unsigned int audio_clk_a_a_mux[] = {
+   AUDIO_CLKA_A_MARK,
+};
+static const unsigned int audio_clk_a_b_pins[] = {
+   /* CLK A */
+   RCAR_GP_PIN(5, 4),
+};
+static const unsigned int audio_clk_a_b_mux[] = {
+   AUDIO_CLKA_B_MARK,
+};
+static const unsigned int audio_clk_a_c_pins[] = {
+   /* CLK A */
+   RCAR_GP_PIN(5, 19),
+};
+static const unsigned int audio_clk_a_c_mux[] = {
+   AUDIO_CLKA_C_MARK,
+};
+static const unsigned int audio_clk_b_a_pins[] = {
+   /* CLK B */
+   RCAR_GP_PIN(5, 12),
+};
+static const unsigned int audio_clk_b_a_mux[] = {
+   AUDIO_CLKB_A_MARK,
+};
+static const unsigned int audio_clk_b_b_pins[] = {
+   /* CLK B */
+   RCAR_GP_PIN(6, 23),
+};
+static const unsigned int audio_clk_b_b_mux[] = {
+   AUDIO_CLKB_B_MARK,
+};
+static const unsigned int audio_clk_c_a_pins[] = {
+   /* CLK C */
+   RCAR_GP_PIN(5, 21),
+};
+static const unsigned int audio_clk_c_a_mux[] = {
+   AUDIO_CLKC_A_MARK,
+};
+static const unsigned int audio_clk_c_b_pins[] = {
+   /* CLK C */
+   RCAR_GP_PIN(5, 0),
+};
+static const unsigned int audio_clk_c_b_mux[] = {
+   AUDIO_CLKC_B_MARK,
+};
+static const unsigned int audio_clkout_a_pins[] = {
+   /* CLKOUT */
+   RCAR_GP_PIN(5, 18),
+};
+static const unsigned int audio_clkout_a_mux[] = {
+   AUDIO_CLKOUT_A_MARK,
+};
+static const unsigned int audio_clkout_b_pins[] = {
+   /* CLKOUT */
+   RCAR_GP_PIN(6, 28),
+};
+static const unsigned int audio_clkout_b_mux[] = {
+   AUDIO_CLKOUT_B_MARK,
+};
+static const unsigned int audio_clkout_c_pins[] = {
+   /* CLKOUT */
+   RCAR_GP_PIN(5, 3),
+};
+static const unsigned int audio_clkout_c_mux[] = {
+   AUDIO_CLKOUT_C_MARK,
+};
+static const unsigned int audio_clkout_d_pins[] = {
+   /* CLKOUT */
+   RCAR_GP_PIN(5, 21),
+};
+static const unsigned int audio_clkout_d_mux[] = {
+   AUDIO_CLKOUT_D_MARK,
+};
+static const unsigned int audio_clkout1_a_pins[] = {
+   /* CLKOUT1 */
+   RCAR_GP_PIN(5, 15),
+};
+static const unsigned int audio_clkout1_a_mux[] = {
+   AUDIO_CLKOUT1_A_MARK,
+};
+static const unsigned int audio_clkout1_b_pins[] = {
+   /* CLKOUT1 */
+   RCAR_GP_PIN(6, 29),
+};
+static const unsigned int audio_clkout1_b_mux[] = {
+   AUDIO_CLKOUT1_B_MARK,
+};
+static const unsigned int audio_clkout2_a_pins[] = {
+   /* CLKOUT2 */
+   RCAR_GP_PIN(5, 16),
+};
+static const unsigned int audio_clkout2_a_mux[] = {
+   AUDIO_CLKOUT2_A_MARK,
+};
+static const unsigned int audio_clkout2_b_pins[] = {
+   /* CLKOUT2 */
+   RCAR_GP_PIN(6, 30),
+};
+static const unsigned int audio_clkout2_b_mux[] = {
+   AUDIO_CLKOUT2_B_MARK,
+};
+
+static const unsigned int audio_clkout3_a_pins[] = {
+   /* CLKOUT3 */
+   RCAR_GP_PIN(5, 19),
+};
+static const unsigned int audio_clkout3_a_mux[] = {
+   AUDIO_CLKOUT3_A_MARK,
+};
+static const unsigned int audio_clkout3_b_pins[] = {
+   /* CLKOUT3 */
+   RCAR_GP_PIN(6, 31),
+};
+static const unsigned int audio_clkout3_b_mux[] = {
+   AUDIO_CLKOUT3_B_MARK,
+};
+
 /* - EtherAVB --- 
*/
 static const unsigned int avb_link_pins[] = {
/* AVB_LINK */
@@ -3426,6 +3548,23 @@ static const unsigned int usb30_mux[] = {
 };
 
 static const struct sh_pfc_pin_group pinmux_groups[] = {
+   SH_PFC_PIN_GROUP(audio_clk_a_a),
+   SH_PFC_PIN_GROUP(audio_clk_a_b),
+   SH_PFC_PIN_GROUP(audio_clk_a_c),
+   SH_PFC_PIN_GROUP(audio_clk_b_a),
+   SH_PFC_PIN_GROUP(audio_clk_b_b),
+   SH_PFC_PIN_GROUP(audio_clk_c_a),
+   SH_PFC_PIN_GROUP(audio_clk_c_b),
+   SH_PFC_PIN_GROUP(audio_clkout_a),
+   SH_PFC_PIN_GROUP(audio_clkout_b),
+   SH_PFC_PIN_GROUP(audio_clkout_c),
+   SH_PFC_PIN_GROUP(audio_clkout_d),
+   SH_PFC_PIN_GROUP(audio_clkout1_a),
+   SH_PFC_PIN_GROUP(audio_clkout1_b),
+   SH_PFC_PIN_GROUP(audio_clkout2_a),
+   SH_PFC_PIN_GROUP(audio_clkout2_b),
+   SH_PFC_PIN_GROUP(audio_clkout3_a),
+   SH_PFC_PIN_GROUP(audio_clkout3_b),
SH_PFC_PIN_GROUP(avb_link),
SH_PFC_PIN_GROUP(avb_magic),
SH_PFC_PIN_GROUP(avb_phy_in

Re: [PATCH 1/2] pinctrl: sh-pfc: r8a77965: add Audio clock pin support

2018-08-27 Thread Geert Uytterhoeven 
Hi Hoan,

On Fri, Aug 17, 2018 at 5:03 AM Nguyen An Hoan  wrote:
> From: Hoan Nguyen An 

Reviewed-by: Geert Uytterhoeven 

But I cannot apply it without your Signed-off-by.

Gr{oetje,eeting}s,

Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH 1/2] pinctrl: sh-pfc: r8a77965: add Audio clock pin support

2018-08-19 Thread Kuninori Morimoto 


Hi Nguyen

> From: Hoan Nguyen An 
> 
> ---
>  drivers/pinctrl/sh-pfc/pfc-r8a77965.c | 160 
> ++
>  1 file changed, 160 insertions(+)

You need to add Signed-off-by line.
Or, you can use "git commit -s xxx" when commit.
Same comment for [2/2] patch.

[PATCH 1/2] pinctrl: sh-pfc: r8a77965: add Audio clock pin support

2018-08-16 Thread Nguyen An Hoan 
From: Hoan Nguyen An 

---
 drivers/pinctrl/sh-pfc/pfc-r8a77965.c | 160 ++
 1 file changed, 160 insertions(+)

diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77965.c 
b/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
index 72ccd1a..46241c0 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a77965.c
@@ -1575,6 +1575,128 @@ static const struct sh_pfc_pin pinmux_pins[] = {
SH_PFC_PIN_NAMED_CFG(ROW_GROUP_A('T'), 30, ASEBRK, CFG_FLAGS),
 };
 
+/* - AUDIO CLOCK  
*/
+static const unsigned int audio_clk_a_a_pins[] = {
+   /* CLK A */
+   RCAR_GP_PIN(6, 22),
+};
+static const unsigned int audio_clk_a_a_mux[] = {
+   AUDIO_CLKA_A_MARK,
+};
+static const unsigned int audio_clk_a_b_pins[] = {
+   /* CLK A */
+   RCAR_GP_PIN(5, 4),
+};
+static const unsigned int audio_clk_a_b_mux[] = {
+   AUDIO_CLKA_B_MARK,
+};
+static const unsigned int audio_clk_a_c_pins[] = {
+   /* CLK A */
+   RCAR_GP_PIN(5, 19),
+};
+static const unsigned int audio_clk_a_c_mux[] = {
+   AUDIO_CLKA_C_MARK,
+};
+static const unsigned int audio_clk_b_a_pins[] = {
+   /* CLK B */
+   RCAR_GP_PIN(5, 12),
+};
+static const unsigned int audio_clk_b_a_mux[] = {
+   AUDIO_CLKB_A_MARK,
+};
+static const unsigned int audio_clk_b_b_pins[] = {
+   /* CLK B */
+   RCAR_GP_PIN(6, 23),
+};
+static const unsigned int audio_clk_b_b_mux[] = {
+   AUDIO_CLKB_B_MARK,
+};
+static const unsigned int audio_clk_c_a_pins[] = {
+   /* CLK C */
+   RCAR_GP_PIN(5, 21),
+};
+static const unsigned int audio_clk_c_a_mux[] = {
+   AUDIO_CLKC_A_MARK,
+};
+static const unsigned int audio_clk_c_b_pins[] = {
+   /* CLK C */
+   RCAR_GP_PIN(5, 0),
+};
+static const unsigned int audio_clk_c_b_mux[] = {
+   AUDIO_CLKC_B_MARK,
+};
+static const unsigned int audio_clkout_a_pins[] = {
+   /* CLKOUT */
+   RCAR_GP_PIN(5, 18),
+};
+static const unsigned int audio_clkout_a_mux[] = {
+   AUDIO_CLKOUT_A_MARK,
+};
+static const unsigned int audio_clkout_b_pins[] = {
+   /* CLKOUT */
+   RCAR_GP_PIN(6, 28),
+};
+static const unsigned int audio_clkout_b_mux[] = {
+   AUDIO_CLKOUT_B_MARK,
+};
+static const unsigned int audio_clkout_c_pins[] = {
+   /* CLKOUT */
+   RCAR_GP_PIN(5, 3),
+};
+static const unsigned int audio_clkout_c_mux[] = {
+   AUDIO_CLKOUT_C_MARK,
+};
+static const unsigned int audio_clkout_d_pins[] = {
+   /* CLKOUT */
+   RCAR_GP_PIN(5, 21),
+};
+static const unsigned int audio_clkout_d_mux[] = {
+   AUDIO_CLKOUT_D_MARK,
+};
+static const unsigned int audio_clkout1_a_pins[] = {
+   /* CLKOUT1 */
+   RCAR_GP_PIN(5, 15),
+};
+static const unsigned int audio_clkout1_a_mux[] = {
+   AUDIO_CLKOUT1_A_MARK,
+};
+static const unsigned int audio_clkout1_b_pins[] = {
+   /* CLKOUT1 */
+   RCAR_GP_PIN(6, 29),
+};
+static const unsigned int audio_clkout1_b_mux[] = {
+   AUDIO_CLKOUT1_B_MARK,
+};
+static const unsigned int audio_clkout2_a_pins[] = {
+   /* CLKOUT2 */
+   RCAR_GP_PIN(5, 16),
+};
+static const unsigned int audio_clkout2_a_mux[] = {
+   AUDIO_CLKOUT2_A_MARK,
+};
+static const unsigned int audio_clkout2_b_pins[] = {
+   /* CLKOUT2 */
+   RCAR_GP_PIN(6, 30),
+};
+static const unsigned int audio_clkout2_b_mux[] = {
+   AUDIO_CLKOUT2_B_MARK,
+};
+
+static const unsigned int audio_clkout3_a_pins[] = {
+   /* CLKOUT3 */
+   RCAR_GP_PIN(5, 19),
+};
+static const unsigned int audio_clkout3_a_mux[] = {
+   AUDIO_CLKOUT3_A_MARK,
+};
+static const unsigned int audio_clkout3_b_pins[] = {
+   /* CLKOUT3 */
+   RCAR_GP_PIN(6, 31),
+};
+static const unsigned int audio_clkout3_b_mux[] = {
+   AUDIO_CLKOUT3_B_MARK,
+};
+
 /* - EtherAVB --- 
*/
 static const unsigned int avb_link_pins[] = {
/* AVB_LINK */
@@ -3426,6 +3548,23 @@ static const unsigned int usb30_mux[] = {
 };
 
 static const struct sh_pfc_pin_group pinmux_groups[] = {
+   SH_PFC_PIN_GROUP(audio_clk_a_a),
+   SH_PFC_PIN_GROUP(audio_clk_a_b),
+   SH_PFC_PIN_GROUP(audio_clk_a_c),
+   SH_PFC_PIN_GROUP(audio_clk_b_a),
+   SH_PFC_PIN_GROUP(audio_clk_b_b),
+   SH_PFC_PIN_GROUP(audio_clk_c_a),
+   SH_PFC_PIN_GROUP(audio_clk_c_b),
+   SH_PFC_PIN_GROUP(audio_clkout_a),
+   SH_PFC_PIN_GROUP(audio_clkout_b),
+   SH_PFC_PIN_GROUP(audio_clkout_c),
+   SH_PFC_PIN_GROUP(audio_clkout_d),
+   SH_PFC_PIN_GROUP(audio_clkout1_a),
+   SH_PFC_PIN_GROUP(audio_clkout1_b),
+   SH_PFC_PIN_GROUP(audio_clkout2_a),
+   SH_PFC_PIN_GROUP(audio_clkout2_b),
+   SH_PFC_PIN_GROUP(audio_clkout3_a),
+   SH_PFC_PIN_GROUP(audio_clkout3_b),
SH_PFC_PIN_GROUP(avb_link),
SH_PFC_PIN_GROUP(avb_magic),
SH_PFC_PIN_GROUP(avb_phy_int),
@@ -3660,6 +3799,26 @@ static const struct sh_pfc_pin_group pinmux_gr