Re: [PATCH 3/3] ARM: dts: rskrza1: add sdhi1 DT support
On Fri, Sep 23, 2016 at 02:33:10PM +, Chris Brandt wrote:
> > > On Thu, Sep 22, 2016 at 11:32 PM, Chris Brandt
> > wrote:
> > > > Signed-off-by: Chris Brandt
> > > > ---
> > > > arch/arm/boot/dts/r7s72100-rskrza1.dts | 4
> > > > 1 file changed, 4 insertions(+)
> > > >
> > > > diff --git a/arch/arm/boot/dts/r7s72100-rskrza1.dts
> > > > b/arch/arm/boot/dts/r7s72100-rskrza1.dts
> > > > index e5dea5b..548b51f 100644
> > > > --- a/arch/arm/boot/dts/r7s72100-rskrza1.dts
> > > > +++ b/arch/arm/boot/dts/r7s72100-rskrza1.dts
> > > > @@ -56,6 +56,10 @@
> > > > };
> > > > };
> > > >
> > > > +&sdhi1 {
> > > > + status = "okay";
> > >
> > > On all other boards, we have the bus-width property in the
> > > board-specific .dts instead of in the SoC-specific .dtsi.
>
> I did see that.
> But, in my opinion, using 4-bit SDHI is way more common that 1-bit SDHI.
> So I figured I'd make 4-bit the 'default' by putting it in the dtsi, and if
> for some reason someone needed 1-bit, they could override it in the board
> .dts.
>
>
> > I'd like us to be consistent as much as possible.
> > But I do wonder why it has been added as a board property.
>
> It doesn't really matter to me. If you want me to move it to the board dts it
> to keep it consistent, just let me know and I'll change it.
Please do.
RE: [PATCH 3/3] ARM: dts: rskrza1: add sdhi1 DT support
> > On Thu, Sep 22, 2016 at 11:32 PM, Chris Brandt
> wrote:
> > > Signed-off-by: Chris Brandt
> > > ---
> > > arch/arm/boot/dts/r7s72100-rskrza1.dts | 4
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/r7s72100-rskrza1.dts
> > > b/arch/arm/boot/dts/r7s72100-rskrza1.dts
> > > index e5dea5b..548b51f 100644
> > > --- a/arch/arm/boot/dts/r7s72100-rskrza1.dts
> > > +++ b/arch/arm/boot/dts/r7s72100-rskrza1.dts
> > > @@ -56,6 +56,10 @@
> > > };
> > > };
> > >
> > > +&sdhi1 {
> > > + status = "okay";
> >
> > On all other boards, we have the bus-width property in the
> > board-specific .dts instead of in the SoC-specific .dtsi.
I did see that.
But, in my opinion, using 4-bit SDHI is way more common that 1-bit SDHI.
So I figured I'd make 4-bit the 'default' by putting it in the dtsi, and if for
some reason someone needed 1-bit, they could override it in the board .dts.
> I'd like us to be consistent as much as possible.
> But I do wonder why it has been added as a board property.
It doesn't really matter to me. If you want me to move it to the board dts it
to keep it consistent, just let me know and I'll change it.
Chris
Re: [PATCH 3/3] ARM: dts: rskrza1: add sdhi1 DT support
On Fri, Sep 23, 2016 at 09:09:07AM +0200, Geert Uytterhoeven wrote:
> On Thu, Sep 22, 2016 at 11:32 PM, Chris Brandt
> wrote:
> > Signed-off-by: Chris Brandt
> > ---
> > arch/arm/boot/dts/r7s72100-rskrza1.dts | 4
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/r7s72100-rskrza1.dts
> > b/arch/arm/boot/dts/r7s72100-rskrza1.dts
> > index e5dea5b..548b51f 100644
> > --- a/arch/arm/boot/dts/r7s72100-rskrza1.dts
> > +++ b/arch/arm/boot/dts/r7s72100-rskrza1.dts
> > @@ -56,6 +56,10 @@
> > };
> > };
> >
> > +&sdhi1 {
> > + status = "okay";
>
> On all other boards, we have the bus-width property in the board-specific
> .dts instead of in the SoC-specific .dtsi.
I'd like us to be consistent as much as possible.
But I do wonder why it has been added as a board property.
> > +};
> > +
> > &scif2 {
> > status = "okay";
> > };
Re: [PATCH 3/3] ARM: dts: rskrza1: add sdhi1 DT support
On Thu, Sep 22, 2016 at 11:32 PM, Chris Brandt wrote:
> Signed-off-by: Chris Brandt
> ---
> arch/arm/boot/dts/r7s72100-rskrza1.dts | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r7s72100-rskrza1.dts
> b/arch/arm/boot/dts/r7s72100-rskrza1.dts
> index e5dea5b..548b51f 100644
> --- a/arch/arm/boot/dts/r7s72100-rskrza1.dts
> +++ b/arch/arm/boot/dts/r7s72100-rskrza1.dts
> @@ -56,6 +56,10 @@
> };
> };
>
> +&sdhi1 {
> + status = "okay";
On all other boards, we have the bus-width property in the board-specific
.dts instead of in the SoC-specific .dtsi.
> +};
> +
> &scif2 {
> status = "okay";
> };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[PATCH 3/3] ARM: dts: rskrza1: add sdhi1 DT support
Signed-off-by: Chris Brandt
---
arch/arm/boot/dts/r7s72100-rskrza1.dts | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/r7s72100-rskrza1.dts
b/arch/arm/boot/dts/r7s72100-rskrza1.dts
index e5dea5b..548b51f 100644
--- a/arch/arm/boot/dts/r7s72100-rskrza1.dts
+++ b/arch/arm/boot/dts/r7s72100-rskrza1.dts
@@ -56,6 +56,10 @@
};
};
+&sdhi1 {
+ status = "okay";
+};
+
&scif2 {
status = "okay";
};
--
2.9.2
