Re: [PATCH 3/3] arm64: dts: renesas: draak: Describe HDMI input
Hi Niklas, On Monday, 14 May 2018 13:23:26 EEST Niklas Söderlund wrote: > On 2018-05-14 09:39:34 +0200, Jacopo Mondi wrote: > > On Sun, May 13, 2018 at 02:57:55PM +0200, Niklas Söderlund wrote: > >> On 2018-05-11 12:00:02 +0200, Jacopo Mondi wrote: > >>> Describe HDMI input connected to VIN4 interface for R-Car D3 Draak > >>> development board. > >>> > >>> Signed-off-by: Jacopo Mondi > >>> --- > >>> > >>> arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 68 +++ > >>> 1 file changed, 68 insertions(+) > >>> > >>> diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > >>> b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index > >>> d03f194..e0ce462 100644 > >>> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > >>> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts [snip] > >>> +&vin4 { > >>> + pinctrl-0 = <&vin4_pins>; > >>> + pinctrl-names = "default"; > >>> + > >>> + status = "okay"; > >>> + > >>> + ports { > >>> + #address-cells = <1>; > >>> + #size-cells = <0>; > >>> + > >>> + port@0 { > >>> + reg = <0>; > >>> + > >>> + vin4_in: endpoint { > >>> + hsync-active = <0>; > >>> + vsync-active = <0>; > >> > >> Comparing this to the Gen2 bindings some properties are missing, > >> > >> bus-width = <24>; > >> pclk-sample = <1>; > >> data-active = <1>; > > > > The VIN driver does not parse them, so there is no value in having > > them there, if not confusing people as it happened to me reading the > > Gen2 DT. > > I have no objection removing them. Trying to understand why the > description differed from Gen2. > > >> This is not a big deal as the VIN driver don't use these properties so > >> no functional change should come of this but still a difference. > > > > Exactly. > > > > On a side note. I have not seen a way to configure the pixel clock > > sampling level in the interface datasheet. The register used to > > configure synchronism signals polarities is VnDMR2, and there I read > > we can configure HSYNC/VSYNC and CLOCKENB (which is data enable, not > > pixel clock) polarities. Is it configured through some other > > register? > > I have not seen such a register no. > > >> Over all I'm happy with this change but before I add my tag I would like > >> to understand why it differs from the Gen2 configuration for the adv7612 > >> properties. > >> > >> Also on a side not it is possible with hardware switches on the board > >> switch the VIN4 source to a completely different pipeline CVBS connector > >> -> adv7180 -> VIN4. But I think it's best we keep the HDMI as default as > >> this seems to be how the boards are shipped. But maybe mentioning this > >> in the commit message would not hurt if you end-up resending the patch. > > > > Oh I see. SW-49 to SW-52 enables the HDMI input, SW53-SW54 CVBS one. > > And actually, reading the 'initial setting of slide switches' in the > > Draak board manual, it turns out that the board default configuration > > is with CVBS input selected... What should we do here? reflect > > defaults in the DT, or prioritize HDMI? > > I feel this is a question for Laurent. My feeling for how we handled > this in other cases is to go with the board default settings. I'm > however sure there are exceptions to the rule. So maybe we should go > with the most useful (what ever that is) configuration? I think I'd go with CVBS as I don't think HDMI would be considered as the most useful configuration here. The Draak board is unlikely to be used by us as a reference platform to test HDMI capture, is it ? This being said, you can instantiate the adv7612 and HDMI connector in DT, without connecting them to the VIN. That would make it easy to quickly change the configuration. > >>> + > >>> + remote-endpoint = <&adv7612_out>; > >>> + }; > >>> + }; > >>> + }; > >>> +}; -- Regards, Laurent Pinchart
Re: [PATCH 3/3] arm64: dts: renesas: draak: Describe HDMI input
Hi Niklas, On Monday, 14 May 2018 12:49:00 EEST Niklas Söderlund wrote: > On 2018-05-14 05:49:41 +0300, Laurent Pinchart wrote: > > [snip] > > >>> +&vin4 { > >>> + pinctrl-0 = <&vin4_pins>; > >>> + pinctrl-names = "default"; > >>> + > >>> + status = "okay"; > >>> + > >>> + ports { > >>> + #address-cells = <1>; > >>> + #size-cells = <0>; > >>> + > >>> + port@0 { > >>> + reg = <0>; > >>> + vin4_in: endpoint { > >>> + hsync-active = <0>; > >>> + vsync-active = <0>; > >> > >> Comparing this to the Gen2 bindings some properties are missing, > >> > >> bus-width = <24>; > >> pclk-sample = <1>; > >> data-active = <1>; > >> > >> This is not a big deal as the VIN driver don't use these properties so > >> no functional change should come of this but still a difference. > > > > I think the VIN DT bindings should be updated to explicitly list the > > endpoint properties that are mandatory, optional, or not allowed. > > I think it's documented as it reference video-interfaces.txt which lists > all these properties as optional. And in deed they are all optional. I don't think that's good enough. They're all listed as optional in video- interfaces.txt as the generic documentation can't know whether a particular device will require a particular property or not. It's the responsibility of device DT bindings to refine the bindings description. The VIN DT bindings should explicitly list the properties that apply to the VIN and tell whether they're optional or mandatory for the VIN. For optional properties, the default behaviour when the property is not specified should be documented too. For instance, does VIN support selecting which pixel clock edge to sample data on ? If so the pclk-sample property should listed as either mandatory or optional with a documented default, even if not used by the driver today. > If the VIN driver makes use of all the optional ones is another matter. How > do we know that the remote subdevice is not looking at its remote > endpoint for bus parameters not considered by the rcar-vin driver? No driver should parse properties of remote nodes, as those properties are to be interpreted in the context of the remote node's DT bindings, which the driver doesn't know about. Parsing OF graph properties (ports and endpoints) is an exception, as by connecting a remote node to the local node with OF graph properties you imply that the remote node uses OF graph DT bindings, so those properties (and only those properties) can be parsed. > The thing is that the rcar-vin driver only looks at the remote endpoint > for these properties and ignores the on its local endpoint. Maybe some > v4l2 framework change is needed here to make sure the bus properties are > the same on both endpoints of a link. But I fear such a change would > break a lot of stuff. Properties are specified on both endpoints to account for components such as inverter gates between the two devices. They can thus be different on the two sides, that's perfectly valid. The VIN driver should parse its local properties, not the remote properties. -- Regards, Laurent Pinchart
Re: [PATCH 3/3] arm64: dts: renesas: draak: Describe HDMI input
Hi Jacopo, On 2018-05-14 09:39:34 +0200, Jacopo Mondi wrote: > Hi Niklas, > > On Sun, May 13, 2018 at 02:57:55PM +0200, Niklas Söderlund wrote: > > Hi Jacopo, > > > > Thanks for your patch. > > > > On 2018-05-11 12:00:02 +0200, Jacopo Mondi wrote: > > > Describe HDMI input connected to VIN4 interface for R-Car D3 Draak > > > development board. > > > > > > Signed-off-by: Jacopo Mondi > > > --- > > > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 68 > > > ++ > > > 1 file changed, 68 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > index d03f194..e0ce462 100644 > > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > > @@ -59,6 +59,17 @@ > > > }; > > > }; > > > > > > + hdmi-in { > > > + compatible = "hdmi-connector"; > > > + type = "a"; > > > + > > > + port { > > > + hdmi_con_in: endpoint { > > > + remote-endpoint = <&adv7612_in>; > > > + }; > > > + }; > > > + }; > > > + > > > memory@4800 { > > > device_type = "memory"; > > > /* first 128MB is reserved for secure area. */ > > > @@ -142,6 +153,11 @@ > > > groups = "usb0"; > > > function = "usb0"; > > > }; > > > + > > > + vin4_pins: vin4 { > > > + groups = "vin4_data24", "vin4_sync", "vin4_clk", "vin4_clkenb"; > > > + function = "vin4"; > > > + }; > > > }; > > > > > > &i2c0 { > > > @@ -154,6 +170,35 @@ > > > reg = <0x50>; > > > pagesize = <8>; > > > }; > > > + > > > + hdmi-decoder@4c { > > > + compatible = "adi,adv7612"; > > > + reg = <0x4c>; > > > + default-input = <0>; > > > + > > > + ports { > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + port@0 { > > > + reg = <0>; > > > + adv7612_in: endpoint { > > > + remote-endpoint = <&hdmi_con_in>; > > > + }; > > > + }; > > > + > > > + port@2 { > > > + reg = <2>; > > > + adv7612_out: endpoint { > > > + pclk-sample = <0>; > > > + hsync-active = <0>; > > > + vsync-active = <0>; > > > > This differs from the Gen2 DT bindings which is a very similar hardware > > setup using the same components. Defining these properties will make the > > bus marked as V4L2_MBUS_PARALLEL instead of V4L2_MBUS_BT656. > > And that's what we want > > > > > This will change how the hardware is configured for capture if the media > > bus is in a UYVY format, see VNMC_INF register in rvin_setup(). Maybe > > this it not an issue here but still I'm curious to why this differ > > between Gen2 and Gen3 :-) > > Actually this won't impact the VIN configuration as this is the > 'remote endpoint' from VIN perspective and the properties used to > configure the interface are the ones in the 'local endpoint'. You are right, sorry for the confusion and thanks for educating me :-) > > > > > > + > > > + remote-endpoint = <&vin4_in>; > > > + }; > > > + }; > > > + }; > > > + }; > > > }; > > > > > > &i2c1 { > > > @@ -246,3 +291,26 @@ > > > timeout-sec = <60>; > > > status = "okay"; > > > }; > > > + > > > +&vin4 { > > > + pinctrl-0 = <&vin4_pins>; > > > + pinctrl-names = "default"; > > > + > > > + status = "okay"; > > > + > > > + ports { > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + port@0 { > > > + reg = <0>; > > > + > > > + vin4_in: endpoint { > > > + hsync-active = <0>; > > > + vsync-active = <0>; > > > > Comparing this to the Gen2 bindings some properties are missing, > > > > bus-width = <24>; > > pclk-sample = <1>; > > data-active = <1>; > > The VIN driver does not parse them, so there is no value in having > them there, if not confusing people as it happened to me reading the > Gen2 DT. I have no objection removing them. Trying to understand why the description differed from Gen2. > > > > > This is not a big deal as the VIN driver don't use these properties so > > no functional change should come of this but still a difference. > > Exactly. > > On a side note. I have not seen a way to configure the pixel clock > sampling level in the interface datasheet. The register used to > configure synchronism signals polarities is VnDMR2, and there I read > we can configure HSYNC/VSYNC and CLOCKENB (which is data enable, not > pixel clock) polarities. Is it configured through some othe
Re: [PATCH 3/3] arm64: dts: renesas: draak: Describe HDMI input
Hi again, On 2018-05-14 11:49:00 +0200, Niklas Söderlund wrote: > Hi Laurent, > > On 2018-05-14 05:49:41 +0300, Laurent Pinchart wrote: > > [snip] > > > > > +&vin4 { > > > > + pinctrl-0 = <&vin4_pins>; > > > > + pinctrl-names = "default"; > > > > + > > > > + status = "okay"; > > > > + > > > > + ports { > > > > + #address-cells = <1>; > > > > + #size-cells = <0>; > > > > + > > > > + port@0 { > > > > + reg = <0>; > > > > + > > > > + vin4_in: endpoint { > > > > + hsync-active = <0>; > > > > + vsync-active = <0>; > > > > > > Comparing this to the Gen2 bindings some properties are missing, > > > > > > bus-width = <24>; > > > pclk-sample = <1>; > > > data-active = <1>; > > > > > > This is not a big deal as the VIN driver don't use these properties so > > > no functional change should come of this but still a difference. > > > > I think the VIN DT bindings should be updated to explicitly list the > > endpoint > > properties that are mandatory, optional, or not allowed. > > I think it's documented as it reference video-interfaces.txt which lists > all these properties as optional. And in deed they are all optional. If > the VIN driver makes use of all the optional ones is another matter. How > do we know that the remote subdevice is not looking at its remote > endpoint for bus parameters not considered by the rcar-vin driver? > > The thing is that the rcar-vin driver only looks at the remote endpoint > for these properties and ignores the on its local endpoint. Maybe some > v4l2 framework change is needed here to make sure the bus properties are > the same on both endpoints of a link. But I fear such a change would > break a lot of stuff. Jacopo pointed out this statement is untrue. The rcar-vin only looks at it's local endpoint not the remote endpoint for it's bus parameters. The callback provided to v4l2_async_notifier_parse_fwnode_endpoints() confused me as the subdevice passed to it is the one describe the remote endpoint while the v4l2_fwnode_endpoint argument is that of the local endpoint. Sorry for the confusion and thanks Jacopo for correcting me. -- Regards, Niklas Söderlund
Re: [PATCH 3/3] arm64: dts: renesas: draak: Describe HDMI input
Hi Laurent, On 2018-05-14 05:49:41 +0300, Laurent Pinchart wrote: [snip] > > > +&vin4 { > > > + pinctrl-0 = <&vin4_pins>; > > > + pinctrl-names = "default"; > > > + > > > + status = "okay"; > > > + > > > + ports { > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + port@0 { > > > + reg = <0>; > > > + > > > + vin4_in: endpoint { > > > + hsync-active = <0>; > > > + vsync-active = <0>; > > > > Comparing this to the Gen2 bindings some properties are missing, > > > > bus-width = <24>; > > pclk-sample = <1>; > > data-active = <1>; > > > > This is not a big deal as the VIN driver don't use these properties so > > no functional change should come of this but still a difference. > > I think the VIN DT bindings should be updated to explicitly list the endpoint > properties that are mandatory, optional, or not allowed. I think it's documented as it reference video-interfaces.txt which lists all these properties as optional. And in deed they are all optional. If the VIN driver makes use of all the optional ones is another matter. How do we know that the remote subdevice is not looking at its remote endpoint for bus parameters not considered by the rcar-vin driver? The thing is that the rcar-vin driver only looks at the remote endpoint for these properties and ignores the on its local endpoint. Maybe some v4l2 framework change is needed here to make sure the bus properties are the same on both endpoints of a link. But I fear such a change would break a lot of stuff. -- Regards, Niklas Söderlund
Re: [PATCH 3/3] arm64: dts: renesas: draak: Describe HDMI input
Hi Niklas, On Sun, May 13, 2018 at 02:57:55PM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your patch. > > On 2018-05-11 12:00:02 +0200, Jacopo Mondi wrote: > > Describe HDMI input connected to VIN4 interface for R-Car D3 Draak > > development board. > > > > Signed-off-by: Jacopo Mondi > > --- > > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 68 > > ++ > > 1 file changed, 68 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > index d03f194..e0ce462 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > @@ -59,6 +59,17 @@ > > }; > > }; > > > > + hdmi-in { > > + compatible = "hdmi-connector"; > > + type = "a"; > > + > > + port { > > + hdmi_con_in: endpoint { > > + remote-endpoint = <&adv7612_in>; > > + }; > > + }; > > + }; > > + > > memory@4800 { > > device_type = "memory"; > > /* first 128MB is reserved for secure area. */ > > @@ -142,6 +153,11 @@ > > groups = "usb0"; > > function = "usb0"; > > }; > > + > > + vin4_pins: vin4 { > > + groups = "vin4_data24", "vin4_sync", "vin4_clk", "vin4_clkenb"; > > + function = "vin4"; > > + }; > > }; > > > > &i2c0 { > > @@ -154,6 +170,35 @@ > > reg = <0x50>; > > pagesize = <8>; > > }; > > + > > + hdmi-decoder@4c { > > + compatible = "adi,adv7612"; > > + reg = <0x4c>; > > + default-input = <0>; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + adv7612_in: endpoint { > > + remote-endpoint = <&hdmi_con_in>; > > + }; > > + }; > > + > > + port@2 { > > + reg = <2>; > > + adv7612_out: endpoint { > > + pclk-sample = <0>; > > + hsync-active = <0>; > > + vsync-active = <0>; > > This differs from the Gen2 DT bindings which is a very similar hardware > setup using the same components. Defining these properties will make the > bus marked as V4L2_MBUS_PARALLEL instead of V4L2_MBUS_BT656. And that's what we want > > This will change how the hardware is configured for capture if the media > bus is in a UYVY format, see VNMC_INF register in rvin_setup(). Maybe > this it not an issue here but still I'm curious to why this differ > between Gen2 and Gen3 :-) Actually this won't impact the VIN configuration as this is the 'remote endpoint' from VIN perspective and the properties used to configure the interface are the ones in the 'local endpoint'. > > > + > > + remote-endpoint = <&vin4_in>; > > + }; > > + }; > > + }; > > + }; > > }; > > > > &i2c1 { > > @@ -246,3 +291,26 @@ > > timeout-sec = <60>; > > status = "okay"; > > }; > > + > > +&vin4 { > > + pinctrl-0 = <&vin4_pins>; > > + pinctrl-names = "default"; > > + > > + status = "okay"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + > > + vin4_in: endpoint { > > + hsync-active = <0>; > > + vsync-active = <0>; > > Comparing this to the Gen2 bindings some properties are missing, > > bus-width = <24>; > pclk-sample = <1>; > data-active = <1>; The VIN driver does not parse them, so there is no value in having them there, if not confusing people as it happened to me reading the Gen2 DT. > > This is not a big deal as the VIN driver don't use these properties so > no functional change should come of this but still a difference. Exactly. On a side note. I have not seen a way to configure the pixel clock sampling level in the interface datasheet. The register used to configure synchronism signals polarities is VnDMR2, and there I read we can configure HSYNC/VSYNC and CLOCKENB (which is data enable, not pixel clock) polarities. Is it configured through some other register? > > Over all I'm happy with this change but before I add my tag I would like > to understand why it differs from the Gen2 configuration for the adv7612 > properties. > > Also on a side not it is possible with hardware switches on the board > switch the VIN4 source to a completely different pipeline CVBS connector > -> adv7180 -> VIN4. But I think it's best we keep the HDMI as default as > this s
Re: [PATCH 3/3] arm64: dts: renesas: draak: Describe HDMI input
Hello, On Sunday, 13 May 2018 15:57:55 EEST Niklas Söderlund wrote: > On 2018-05-11 12:00:02 +0200, Jacopo Mondi wrote: > > Describe HDMI input connected to VIN4 interface for R-Car D3 Draak > > development board. > > > > Signed-off-by: Jacopo Mondi > > --- > > > > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 68 + > > 1 file changed, 68 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index d03f194..e0ce462 > > 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > > @@ -59,6 +59,17 @@ > > > > }; > > > > }; > > > > + hdmi-in { > > + compatible = "hdmi-connector"; > > + type = "a"; > > + > > + port { > > + hdmi_con_in: endpoint { > > + remote-endpoint = <&adv7612_in>; > > + }; > > + }; > > + }; > > + > > > > memory@4800 { > > > > device_type = "memory"; > > /* first 128MB is reserved for secure area. */ > > > > @@ -142,6 +153,11 @@ > > > > groups = "usb0"; > > function = "usb0"; > > > > }; > > > > + > > + vin4_pins: vin4 { > > + groups = "vin4_data24", "vin4_sync", "vin4_clk", "vin4_clkenb"; > > + function = "vin4"; > > + }; > > > > }; > > > > &i2c0 { > > > > @@ -154,6 +170,35 @@ > > > > reg = <0x50>; > > pagesize = <8>; > > > > }; > > > > + > > + hdmi-decoder@4c { > > + compatible = "adi,adv7612"; > > + reg = <0x4c>; > > + default-input = <0>; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + adv7612_in: endpoint { > > + remote-endpoint = <&hdmi_con_in>; > > + }; > > + }; > > + > > + port@2 { > > + reg = <2>; > > + adv7612_out: endpoint { > > + pclk-sample = <0>; > > + hsync-active = <0>; > > + vsync-active = <0>; > > This differs from the Gen2 DT bindings which is a very similar hardware > setup using the same components. Defining these properties will make the > bus marked as V4L2_MBUS_PARALLEL instead of V4L2_MBUS_BT656. > > This will change how the hardware is configured for capture if the media > bus is in a UYVY format, see VNMC_INF register in rvin_setup(). Maybe > this it not an issue here but still I'm curious to why this differ > between Gen2 and Gen3 :-) > > > + > > + remote-endpoint = <&vin4_in>; > > + }; > > + }; > > + }; > > + }; > > > > }; > > > > &i2c1 { > > > > @@ -246,3 +291,26 @@ > > > > timeout-sec = <60>; > > status = "okay"; > > > > }; > > > > + > > +&vin4 { > > + pinctrl-0 = <&vin4_pins>; > > + pinctrl-names = "default"; > > + > > + status = "okay"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + > > + vin4_in: endpoint { > > + hsync-active = <0>; > > + vsync-active = <0>; > > Comparing this to the Gen2 bindings some properties are missing, > > bus-width = <24>; > pclk-sample = <1>; > data-active = <1>; > > This is not a big deal as the VIN driver don't use these properties so > no functional change should come of this but still a difference. I think the VIN DT bindings should be updated to explicitly list the endpoint properties that are mandatory, optional, or not allowed. > Over all I'm happy with this change but before I add my tag I would like > to understand why it differs from the Gen2 configuration for the adv7612 > properties. > > Also on a side not it is possible with hardware switches on the board > switch the VIN4 source to a completely different pipeline CVBS connector > -> adv7180 -> VIN4. But I think it's best we keep the HDMI as default as > this seems to be how the boards are shipped. But maybe mentioning this > in the commit message would not hurt if you end-up resending the patch. > > > + > > + remote-endpoint = <&adv7612_out>; > > + }; > > + }; > > + }; > > +}; -- Regards, Laurent Pinchart
Re: [PATCH 3/3] arm64: dts: renesas: draak: Describe HDMI input
Hi Jacopo, Thanks for your patch. On 2018-05-11 12:00:02 +0200, Jacopo Mondi wrote: > Describe HDMI input connected to VIN4 interface for R-Car D3 Draak > development board. > > Signed-off-by: Jacopo Mondi > --- > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 68 > ++ > 1 file changed, 68 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > index d03f194..e0ce462 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts > @@ -59,6 +59,17 @@ > }; > }; > > + hdmi-in { > + compatible = "hdmi-connector"; > + type = "a"; > + > + port { > + hdmi_con_in: endpoint { > + remote-endpoint = <&adv7612_in>; > + }; > + }; > + }; > + > memory@4800 { > device_type = "memory"; > /* first 128MB is reserved for secure area. */ > @@ -142,6 +153,11 @@ > groups = "usb0"; > function = "usb0"; > }; > + > + vin4_pins: vin4 { > + groups = "vin4_data24", "vin4_sync", "vin4_clk", "vin4_clkenb"; > + function = "vin4"; > + }; > }; > > &i2c0 { > @@ -154,6 +170,35 @@ > reg = <0x50>; > pagesize = <8>; > }; > + > + hdmi-decoder@4c { > + compatible = "adi,adv7612"; > + reg = <0x4c>; > + default-input = <0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + adv7612_in: endpoint { > + remote-endpoint = <&hdmi_con_in>; > + }; > + }; > + > + port@2 { > + reg = <2>; > + adv7612_out: endpoint { > + pclk-sample = <0>; > + hsync-active = <0>; > + vsync-active = <0>; This differs from the Gen2 DT bindings which is a very similar hardware setup using the same components. Defining these properties will make the bus marked as V4L2_MBUS_PARALLEL instead of V4L2_MBUS_BT656. This will change how the hardware is configured for capture if the media bus is in a UYVY format, see VNMC_INF register in rvin_setup(). Maybe this it not an issue here but still I'm curious to why this differ between Gen2 and Gen3 :-) > + > + remote-endpoint = <&vin4_in>; > + }; > + }; > + }; > + }; > }; > > &i2c1 { > @@ -246,3 +291,26 @@ > timeout-sec = <60>; > status = "okay"; > }; > + > +&vin4 { > + pinctrl-0 = <&vin4_pins>; > + pinctrl-names = "default"; > + > + status = "okay"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + vin4_in: endpoint { > + hsync-active = <0>; > + vsync-active = <0>; Comparing this to the Gen2 bindings some properties are missing, bus-width = <24>; pclk-sample = <1>; data-active = <1>; This is not a big deal as the VIN driver don't use these properties so no functional change should come of this but still a difference. Over all I'm happy with this change but before I add my tag I would like to understand why it differs from the Gen2 configuration for the adv7612 properties. Also on a side not it is possible with hardware switches on the board switch the VIN4 source to a completely different pipeline CVBS connector -> adv7180 -> VIN4. But I think it's best we keep the HDMI as default as this seems to be how the boards are shipped. But maybe mentioning this in the commit message would not hurt if you end-up resending the patch. > + > + remote-endpoint = <&adv7612_out>; > + }; > + }; > + }; > +}; > -- > 2.7.4 > -- Regards, Niklas Söderlund
Re: [PATCH 3/3] arm64: dts: renesas: draak: Describe HDMI input
Hi Simon, On 2018-05-13 10:17:50 +0200, Simon Horman wrote: > On Fri, May 11, 2018 at 12:00:02PM +0200, Jacopo Mondi wrote: > > Describe HDMI input connected to VIN4 interface for R-Car D3 Draak > > development board. > > > > Signed-off-by: Jacopo Mondi > > Hi Niklas, > > As you reviewed the rest of the series I'm wondering if you're planning > to review this patch too. Yes, I did not have schematics for D3 on hand when reviewing the rest of the series. Will review it now that I do, thanks for the ping :-) -- Regards, Niklas Söderlund
Re: [PATCH 3/3] arm64: dts: renesas: draak: Describe HDMI input
On Fri, May 11, 2018 at 12:00:02PM +0200, Jacopo Mondi wrote: > Describe HDMI input connected to VIN4 interface for R-Car D3 Draak > development board. > > Signed-off-by: Jacopo Mondi Hi Niklas, As you reviewed the rest of the series I'm wondering if you're planning to review this patch too.
[PATCH 3/3] arm64: dts: renesas: draak: Describe HDMI input
Describe HDMI input connected to VIN4 interface for R-Car D3 Draak development board. Signed-off-by: Jacopo Mondi --- arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 68 ++ 1 file changed, 68 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts index d03f194..e0ce462 100644 --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts @@ -59,6 +59,17 @@ }; }; + hdmi-in { + compatible = "hdmi-connector"; + type = "a"; + + port { + hdmi_con_in: endpoint { + remote-endpoint = <&adv7612_in>; + }; + }; + }; + memory@4800 { device_type = "memory"; /* first 128MB is reserved for secure area. */ @@ -142,6 +153,11 @@ groups = "usb0"; function = "usb0"; }; + + vin4_pins: vin4 { + groups = "vin4_data24", "vin4_sync", "vin4_clk", "vin4_clkenb"; + function = "vin4"; + }; }; &i2c0 { @@ -154,6 +170,35 @@ reg = <0x50>; pagesize = <8>; }; + + hdmi-decoder@4c { + compatible = "adi,adv7612"; + reg = <0x4c>; + default-input = <0>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + adv7612_in: endpoint { + remote-endpoint = <&hdmi_con_in>; + }; + }; + + port@2 { + reg = <2>; + adv7612_out: endpoint { + pclk-sample = <0>; + hsync-active = <0>; + vsync-active = <0>; + + remote-endpoint = <&vin4_in>; + }; + }; + }; + }; }; &i2c1 { @@ -246,3 +291,26 @@ timeout-sec = <60>; status = "okay"; }; + +&vin4 { + pinctrl-0 = <&vin4_pins>; + pinctrl-names = "default"; + + status = "okay"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + vin4_in: endpoint { + hsync-active = <0>; + vsync-active = <0>; + + remote-endpoint = <&adv7612_out>; + }; + }; + }; +}; -- 2.7.4