Re: [PATCH 4/4] ARM: dts: r8a77470: Add I2C4 support

2018-09-24 Thread Simon Horman 
On Mon, Sep 24, 2018 at 11:04:39AM +0200, Simon Horman wrote:
> On Sat, Sep 22, 2018 at 08:39:29PM +0200, Wolfram Sang wrote:
> > On Fri, Sep 21, 2018 at 06:37:01PM +0100, Fabrizio Castro wrote:
> > > Add I2C4 support to RZ/G1C (a.k.a. r8a77470) SoC specific
> > > device tree.
> > > 
> > > Signed-off-by: Fabrizio Castro 
> > > Reviewed-by: Biju Das 
> > 
> > Looks sane to me
> > 
> > Acked-by: Wolfram Sang 
> 
> Likewise, but I'd like some feedback on my comment on patch 1/4
> before applying this.

Thanks for the feedback on patch 1/4.
I have queued this patch up for v4.20.

On Mon, Sep 24, 2018 at 11:58:15AM +0200, Geert Uytterhoeven wrote:
> On Fri, Sep 21, 2018 at 7:37 PM Fabrizio Castro
>  wrote:
> > Add I2C4 support to RZ/G1C (a.k.a. r8a77470) SoC specific
> > device tree.
> >
> > Signed-off-by: Fabrizio Castro 
> > Reviewed-by: Biju Das 
> 
> Reviewed-by: Geert Uytterhoeven

Re: [PATCH 4/4] ARM: dts: r8a77470: Add I2C4 support

2018-09-24 Thread Geert Uytterhoeven 
On Fri, Sep 21, 2018 at 7:37 PM Fabrizio Castro
 wrote:
> Add I2C4 support to RZ/G1C (a.k.a. r8a77470) SoC specific
> device tree.
>
> Signed-off-by: Fabrizio Castro 
> Reviewed-by: Biju Das 

Reviewed-by: Geert Uytterhoeven 

Gr{oetje,eeting}s,

Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH 4/4] ARM: dts: r8a77470: Add I2C4 support

2018-09-24 Thread Simon Horman 
On Sat, Sep 22, 2018 at 08:39:29PM +0200, Wolfram Sang wrote:
> On Fri, Sep 21, 2018 at 06:37:01PM +0100, Fabrizio Castro wrote:
> > Add I2C4 support to RZ/G1C (a.k.a. r8a77470) SoC specific
> > device tree.
> > 
> > Signed-off-by: Fabrizio Castro 
> > Reviewed-by: Biju Das 
> 
> Looks sane to me
> 
> Acked-by: Wolfram Sang 

Likewise, but I'd like some feedback on my comment on patch 1/4
before applying this.

Re: [PATCH 4/4] ARM: dts: r8a77470: Add I2C4 support

2018-09-22 Thread Wolfram Sang 
On Fri, Sep 21, 2018 at 06:37:01PM +0100, Fabrizio Castro wrote:
> Add I2C4 support to RZ/G1C (a.k.a. r8a77470) SoC specific
> device tree.
> 
> Signed-off-by: Fabrizio Castro 
> Reviewed-by: Biju Das 

Looks sane to me

Acked-by: Wolfram Sang 



signature.asc
Description: PGP signature

[PATCH 4/4] ARM: dts: r8a77470: Add I2C4 support

2018-09-21 Thread Fabrizio Castro 
Add I2C4 support to RZ/G1C (a.k.a. r8a77470) SoC specific
device tree.

Signed-off-by: Fabrizio Castro 
Reviewed-by: Biju Das 
---
 arch/arm/boot/dts/r8a77470.dtsi | 14 ++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi
index 9e7f86d..9ec78d3 100644
--- a/arch/arm/boot/dts/r8a77470.dtsi
+++ b/arch/arm/boot/dts/r8a77470.dtsi
@@ -237,6 +237,20 @@
reg = <0 0xe630 0 0x2>;
};
 
+   i2c4: i2c@e652 {
+   #address-cells = <1>;
+   #size-cells = <0>;
+   compatible = "renesas,i2c-r8a77470",
+"renesas,rcar-gen2-i2c";
+   reg = <0 0xe652 0 0x40>;
+   interrupts = ;
+   clocks = < CPG_MOD 927>;
+   power-domains = < R8A77470_PD_ALWAYS_ON>;
+   resets = < 927>;
+   i2c-scl-internal-delay-ns = <6>;
+   status = "disabled";
+   };
+
dmac0: dma-controller@e670 {
compatible = "renesas,dmac-r8a77470",
 "renesas,rcar-dmac";
-- 
2.7.4