Re: [PATCH 4/6] arm64: renesas: draak: enable I2C controller 0 and EEPROM

2018-01-19 Thread Kieran Bingham 
Hi Ulrich,

On 17/11/17 16:39, Simon Horman wrote:
> On Fri, Nov 17, 2017 at 06:31:21AM -0800, Simon Horman wrote:
>> On Thu, Nov 16, 2017 at 10:27:56AM +0100, Geert Uytterhoeven wrote:
>>> Hi Ulrich,
>>>
>>> On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht
>>>  wrote:
 Enables EEPROM on I2C0 on the Draak board.

 Signed-off-by: Ulrich Hecht 
>>>
>>> Thanks for your patch!
>>>
 --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
 +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
>>>
 @@ -67,6 +72,18 @@
 };
  };

 +&i2c0 {
 +   pinctrl-0 = <&i2c0_pins>;
 +   pinctrl-names = "default";
 +   status = "okay";
 +
 +   eeprom@50 {
 +   compatible = "atmel,24c01";
>>>
>>> This is actually a ROHM Semiconductor BR24T01FVM-W, so it should be
>>>
>>> compatible = "rohm,br24t01", "atmel,24c01";
>>
>> Applied with the above change.
> 
> Sorry, I was a bit hasty there as this patch
> depends on a patch earlier in the series which I have not applied.
> 
> I've dropped this patch for now and will wait a bit longer for the review
> to unfold.
> 

I am dependant upon this patch for my Draak-D3 work.

Would you be able to consider the comments mentioned to progress this patch 
please?

--
Regards

Kieran


>>
>>> Please also submit a patch to add that compatible value to
>>> Documentation/devicetree/bindings/eeprom/eeprom.txt.
>>
>> Ulrich, please follow-up on this, thanks!
>>
>>> With the above fixed:
>>> Reviewed-by: Geert Uytterhoeven 
>>>
>>> Gr{oetje,eeting}s,
>>>
>>> Geert
>>>
>>> --
>>> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- 
>>> ge...@linux-m68k.org
>>>
>>> In personal conversations with technical people, I call myself a hacker. But
>>> when I'm talking to journalists I just say "programmer" or something like 
>>> that.
>>> -- Linus Torvalds
>>>
>>

Re: [PATCH 4/6] arm64: renesas: draak: enable I2C controller 0 and EEPROM

2017-11-17 Thread Simon Horman 
On Fri, Nov 17, 2017 at 06:31:21AM -0800, Simon Horman wrote:
> On Thu, Nov 16, 2017 at 10:27:56AM +0100, Geert Uytterhoeven wrote:
> > Hi Ulrich,
> > 
> > On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht
> >  wrote:
> > > Enables EEPROM on I2C0 on the Draak board.
> > >
> > > Signed-off-by: Ulrich Hecht 
> > 
> > Thanks for your patch!
> > 
> > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > 
> > > @@ -67,6 +72,18 @@
> > > };
> > >  };
> > >
> > > +&i2c0 {
> > > +   pinctrl-0 = <&i2c0_pins>;
> > > +   pinctrl-names = "default";
> > > +   status = "okay";
> > > +
> > > +   eeprom@50 {
> > > +   compatible = "atmel,24c01";
> > 
> > This is actually a ROHM Semiconductor BR24T01FVM-W, so it should be
> > 
> > compatible = "rohm,br24t01", "atmel,24c01";
> 
> Applied with the above change.

Sorry, I was a bit hasty there as this patch
depends on a patch earlier in the series which I have not applied.

I've dropped this patch for now and will wait a bit longer for the review
to unfold.

> 
> > Please also submit a patch to add that compatible value to
> > Documentation/devicetree/bindings/eeprom/eeprom.txt.
> 
> Ulrich, please follow-up on this, thanks!
> 
> > With the above fixed:
> > Reviewed-by: Geert Uytterhoeven 
> > 
> > Gr{oetje,eeting}s,
> > 
> > Geert
> > 
> > --
> > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- 
> > ge...@linux-m68k.org
> > 
> > In personal conversations with technical people, I call myself a hacker. But
> > when I'm talking to journalists I just say "programmer" or something like 
> > that.
> > -- Linus Torvalds
> > 
>

Re: [PATCH 4/6] arm64: renesas: draak: enable I2C controller 0 and EEPROM

2017-11-17 Thread Simon Horman 
On Thu, Nov 16, 2017 at 10:27:56AM +0100, Geert Uytterhoeven wrote:
> Hi Ulrich,
> 
> On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht
>  wrote:
> > Enables EEPROM on I2C0 on the Draak board.
> >
> > Signed-off-by: Ulrich Hecht 
> 
> Thanks for your patch!
> 
> > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> 
> > @@ -67,6 +72,18 @@
> > };
> >  };
> >
> > +&i2c0 {
> > +   pinctrl-0 = <&i2c0_pins>;
> > +   pinctrl-names = "default";
> > +   status = "okay";
> > +
> > +   eeprom@50 {
> > +   compatible = "atmel,24c01";
> 
> This is actually a ROHM Semiconductor BR24T01FVM-W, so it should be
> 
> compatible = "rohm,br24t01", "atmel,24c01";

Applied with the above change.

> Please also submit a patch to add that compatible value to
> Documentation/devicetree/bindings/eeprom/eeprom.txt.

Ulrich, please follow-up on this, thanks!

> With the above fixed:
> Reviewed-by: Geert Uytterhoeven 
> 
> Gr{oetje,eeting}s,
> 
> Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- 
> ge...@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like 
> that.
> -- Linus Torvalds
>

Re: [PATCH 4/6] arm64: renesas: draak: enable I2C controller 0 and EEPROM

2017-11-16 Thread Geert Uytterhoeven 
Hi Ulrich,

On Wed, Nov 15, 2017 at 4:25 PM, Ulrich Hecht
 wrote:
> Enables EEPROM on I2C0 on the Draak board.
>
> Signed-off-by: Ulrich Hecht 

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts

> @@ -67,6 +72,18 @@
> };
>  };
>
> +&i2c0 {
> +   pinctrl-0 = <&i2c0_pins>;
> +   pinctrl-names = "default";
> +   status = "okay";
> +
> +   eeprom@50 {
> +   compatible = "atmel,24c01";

This is actually a ROHM Semiconductor BR24T01FVM-W, so it should be

compatible = "rohm,br24t01", "atmel,24c01";

Please also submit a patch to add that compatible value to
Documentation/devicetree/bindings/eeprom/eeprom.txt.

With the above fixed:
Reviewed-by: Geert Uytterhoeven 

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCH 4/6] arm64: renesas: draak: enable I2C controller 0 and EEPROM

2017-11-15 Thread Ulrich Hecht 
Enables EEPROM on I2C0 on the Draak board.

Signed-off-by: Ulrich Hecht 
---
 arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 17 +
 1 file changed, 17 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts 
b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
index 09de73b..64a6339 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
@@ -46,6 +46,11 @@
};
};
 
+   i2c0_pins: i2c0 {
+   groups = "i2c0";
+   function = "i2c0";
+   };
+
pwm0_pins: pwm0 {
groups = "pwm0_c";
function = "pwm0";
@@ -67,6 +72,18 @@
};
 };
 
+&i2c0 {
+   pinctrl-0 = <&i2c0_pins>;
+   pinctrl-names = "default";
+   status = "okay";
+
+   eeprom@50 {
+   compatible = "atmel,24c01";
+   reg = <0x50>;
+   pagesize = <8>;
+   };
+};
+
 &ehci0 {
status = "okay";
 };
-- 
2.7.4