[PATCH 7/8] clk: vc5: Add bindings for IDT VersaClock 5P49V6901
From: Marek Vasut IDT VersaClock 6 5P49V6901 has 4 clock outputs, 4 fractional dividers. Input clock source can be taken from either external crystal or from external reference clock. Signed-off-by: Marek Vasut Cc: Alexey Firago Cc: Rob Herring Cc: Stephen Boyd Cc: Michael Turquette Cc: Laurent Pinchart Cc: linux-renesas-soc@vger.kernel.org Cc: devicet...@vger.kernel.org --- .../devicetree/bindings/clock/idt,versaclock5.txt | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt index 53d7e50ed875..a3d4260039a8 100644 --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt @@ -7,18 +7,20 @@ from 3 to 12 output clocks. Required properties: - compatible: shall be one of "idt,5p49v5923" , "idt,5p49v5933" , - "idt,5p49v5935". + "idt,5p49v5935" , "idt,5p49v6901". - reg: i2c device address, shall be 0x68 or 0x6a. - #clock-cells:from common clock binding; shall be set to 1. - clocks: from common clock binding; list of parent clock handles, - - 5p49v5923: (required) either or both of XTAL or CLKIN + - 5p49v5923 and + 5p49v6901: (required) either or both of XTAL or CLKIN reference clock. - 5p49v5933 and - 5p49v5935: (optional) property not present (internal Xtal used) or CLKIN reference clock. - clock-names: from common clock binding; clock input names, can be - - 5p49v5923: (required) either or both of "xin", "clkin". + - 5p49v5923 and + 5p49v6901: (required) either or both of "xin", "clkin". - 5p49v5933 and - 5p49v5935: (optional) property not present or "clkin". @@ -44,6 +46,13 @@ clock specifier, the following mapping applies: 3 -- OUT3 4 -- OUT4 +5P49V6901: + 0 -- OUT0_SEL_I2CB + 1 -- OUT1 + 2 -- OUT2 + 3 -- OUT3 + 4 -- OUT4 + ==Example== /* 25MHz reference crystal */ -- 2.11.0
Re: [PATCH 7/8] clk: vc5: Add bindings for IDT VersaClock 5P49V6901
Hi Marek,
On Thu, Jun 29, 2017 at 12:18 PM, Marek Vasut wrote:
> From: Marek Vasut
>
> IDT VersaClock 6 5P49V6901 has 4 clock outputs, 4 fractional dividers.
> Input clock source can be taken from either external crystal or from
> external reference clock.
>
> Signed-off-by: Marek Vasut
> Cc: Alexey Firago
> Cc: Rob Herring
> Cc: Stephen Boyd
> Cc: Michael Turquette
> Cc: Laurent Pinchart
> Cc: linux-renesas-soc@vger.kernel.org
> Cc: devicet...@vger.kernel.org
> ---
> .../devicetree/bindings/clock/idt,versaclock5.txt | 15
> ---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
> b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
> index 53d7e50ed875..a3d4260039a8 100644
> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
Probably you want to sprinkle the first few lines of the document with
a few "VersaClock 6" references?
> @@ -7,18 +7,20 @@ from 3 to 12 output clocks.
The rest looks OK to me, so
Acked-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH 7/8] clk: vc5: Add bindings for IDT VersaClock 5P49V6901
On 06/29/2017 01:38 PM, Geert Uytterhoeven wrote: > Hi Marek, > > On Thu, Jun 29, 2017 at 12:18 PM, Marek Vasut wrote: >> From: Marek Vasut >> >> IDT VersaClock 6 5P49V6901 has 4 clock outputs, 4 fractional dividers. >> Input clock source can be taken from either external crystal or from >> external reference clock. >> >> Signed-off-by: Marek Vasut >> Cc: Alexey Firago >> Cc: Rob Herring >> Cc: Stephen Boyd >> Cc: Michael Turquette >> Cc: Laurent Pinchart >> Cc: linux-renesas-soc@vger.kernel.org >> Cc: devicet...@vger.kernel.org >> --- >> .../devicetree/bindings/clock/idt,versaclock5.txt | 15 >> --- >> 1 file changed, 12 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt >> b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt >> index 53d7e50ed875..a3d4260039a8 100644 >> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt >> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt > > Probably you want to sprinkle the first few lines of the document with > a few "VersaClock 6" references? Something like this? --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt @@ -1,7 +1,7 @@ -Binding for IDT VersaClock5 programmable i2c clock generator. +Binding for IDT VersaClock 5,6 programmable i2c clock generators. -The IDT VersaClock5 are programmable i2c clock generators providing -from 3 to 12 output clocks. +The IDT VersaClock 5 and VersaClock 6 are programmable i2c clock +generators providing from 3 to 12 output clocks. ==I2C device node== >> @@ -7,18 +7,20 @@ from 3 to 12 output clocks. > > The rest looks OK to me, so > Acked-by: Geert Uytterhoeven Thanks -- Best regards, Marek Vasut
Re: [PATCH 7/8] clk: vc5: Add bindings for IDT VersaClock 5P49V6901
Hi Marek,
On Thu, Jun 29, 2017 at 5:49 PM, Marek Vasut wrote:
> On 06/29/2017 01:38 PM, Geert Uytterhoeven wrote:
>> On Thu, Jun 29, 2017 at 12:18 PM, Marek Vasut wrote:
>>> From: Marek Vasut
>>>
>>> IDT VersaClock 6 5P49V6901 has 4 clock outputs, 4 fractional dividers.
>>> Input clock source can be taken from either external crystal or from
>>> external reference clock.
>>>
>>> Signed-off-by: Marek Vasut
>>> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
>>> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
>>
>> Probably you want to sprinkle the first few lines of the document with
>> a few "VersaClock 6" references?
>
> Something like this?
>
> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt
> @@ -1,7 +1,7 @@
> -Binding for IDT VersaClock5 programmable i2c clock generator.
> +Binding for IDT VersaClock 5,6 programmable i2c clock generators.
>
> -The IDT VersaClock5 are programmable i2c clock generators providing
> -from 3 to 12 output clocks.
> +The IDT VersaClock 5 and VersaClock 6 are programmable i2c clock
> +generators providing from 3 to 12 output clocks.
>
> ==I2C device node==
Exactly. Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
