[PATCH RESEND] mmc: renesas_sdhi: Add r8a7743/5 support

2017-08-29 Thread Biju Das 
Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI
is identical to the R-Car Gen2 family.

Signed-off-by: Biju Das 
---
DT binding patch for r8a7743/5 SoC is applied for mmc next. But the driver 
patch 
is still not applied for mmc next.So resending the driver patch.

This patch is compiled and tested against mmc/next.

 drivers/mmc/host/renesas_sdhi_sys_dmac.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c 
b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
index 160fbb2..df44654 100644
--- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
+++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
@@ -98,6 +98,8 @@
{ .compatible = "renesas,sdhi-r7s72100", .data = &of_rz_compatible, },
{ .compatible = "renesas,sdhi-r8a7778", .data = 
&of_rcar_gen1_compatible, },
{ .compatible = "renesas,sdhi-r8a7779", .data = 
&of_rcar_gen1_compatible, },
+   { .compatible = "renesas,sdhi-r8a7743", .data = 
&of_rcar_gen2_compatible, },
+   { .compatible = "renesas,sdhi-r8a7745", .data = 
&of_rcar_gen2_compatible, },
{ .compatible = "renesas,sdhi-r8a7790", .data = 
&of_rcar_gen2_compatible, },
{ .compatible = "renesas,sdhi-r8a7791", .data = 
&of_rcar_gen2_compatible, },
{ .compatible = "renesas,sdhi-r8a7792", .data = 
&of_rcar_gen2_compatible, },
-- 
1.9.1

Re: [PATCH RESEND] mmc: renesas_sdhi: Add r8a7743/5 support

2017-08-29 Thread Wolfram Sang 
On Tue, Aug 29, 2017 at 02:52:06PM +0100, Biju Das wrote:
> Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI
> is identical to the R-Car Gen2 family.
> 
> Signed-off-by: Biju Das 
> ---
> DT binding patch for r8a7743/5 SoC is applied for mmc next. But the driver 
> patch 
> is still not applied for mmc next.So resending the driver patch.

Didn't Chris Paterson volunteer to write a new patch introducing Gen2
generic compatibles? Or did I misunderstand?

> 
> This patch is compiled and tested against mmc/next.
> 
>  drivers/mmc/host/renesas_sdhi_sys_dmac.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c 
> b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> index 160fbb2..df44654 100644
> --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> @@ -98,6 +98,8 @@
>   { .compatible = "renesas,sdhi-r7s72100", .data = &of_rz_compatible, },
>   { .compatible = "renesas,sdhi-r8a7778", .data = 
> &of_rcar_gen1_compatible, },
>   { .compatible = "renesas,sdhi-r8a7779", .data = 
> &of_rcar_gen1_compatible, },
> + { .compatible = "renesas,sdhi-r8a7743", .data = 
> &of_rcar_gen2_compatible, },
> + { .compatible = "renesas,sdhi-r8a7745", .data = 
> &of_rcar_gen2_compatible, },
>   { .compatible = "renesas,sdhi-r8a7790", .data = 
> &of_rcar_gen2_compatible, },
>   { .compatible = "renesas,sdhi-r8a7791", .data = 
> &of_rcar_gen2_compatible, },
>   { .compatible = "renesas,sdhi-r8a7792", .data = 
> &of_rcar_gen2_compatible, },
> -- 
> 1.9.1
> 


signature.asc
Description: PGP signature

RE: [PATCH RESEND] mmc: renesas_sdhi: Add r8a7743/5 support

2017-08-29 Thread Chris Paterson 


> From: Wolfram Sang [mailto:w...@the-dreams.de]
> Sent: 29 August 2017 15:59
> 
> On Tue, Aug 29, 2017 at 02:52:06PM +0100, Biju Das wrote:
> > Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI is
> > identical to the R-Car Gen2 family.
> >
> > Signed-off-by: Biju Das 
> > ---
> > DT binding patch for r8a7743/5 SoC is applied for mmc next. But the
> > driver patch is still not applied for mmc next.So resending the driver 
> > patch.
> 
> Didn't Chris Paterson volunteer to write a new patch introducing Gen2 generic
> compatibles? Or did I misunderstand?

I did :)

But after some off-ML discussion with Geert/Simon I decided to leave it to 
Simon as he's been doing a lot of similar work for all of the R-Car related 
drivers.

This may not happen immediately, and we already have the bindings/DT patches 
accepted based on this patch, hence the repost.

Sorry for the confusion!

> 
> >
> > This patch is compiled and tested against mmc/next.
> >
> >  drivers/mmc/host/renesas_sdhi_sys_dmac.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> > b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> > index 160fbb2..df44654 100644
> > --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> > +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> > @@ -98,6 +98,8 @@
> > { .compatible = "renesas,sdhi-r7s72100", .data = &of_rz_compatible, },
> > { .compatible = "renesas,sdhi-r8a7778", .data =
> &of_rcar_gen1_compatible, },
> > { .compatible = "renesas,sdhi-r8a7779", .data =
> > &of_rcar_gen1_compatible, },
> > +   { .compatible = "renesas,sdhi-r8a7743", .data =
> &of_rcar_gen2_compatible, },
> > +   { .compatible = "renesas,sdhi-r8a7745", .data =
> > +&of_rcar_gen2_compatible, },
> > { .compatible = "renesas,sdhi-r8a7790", .data =
> &of_rcar_gen2_compatible, },
> > { .compatible = "renesas,sdhi-r8a7791", .data =
> &of_rcar_gen2_compatible, },
> > { .compatible = "renesas,sdhi-r8a7792", .data =
> > &of_rcar_gen2_compatible, },
> > --
> > 1.9.1
> >

Re: [PATCH RESEND] mmc: renesas_sdhi: Add r8a7743/5 support

2017-08-30 Thread Simon Horman 
On Tue, Aug 29, 2017 at 02:52:06PM +0100, Biju Das wrote:
> Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI
> is identical to the R-Car Gen2 family.
> 
> Signed-off-by: Biju Das 

Acked-by: Simon Horman 

> ---
> DT binding patch for r8a7743/5 SoC is applied for mmc next. But the driver 
> patch 
> is still not applied for mmc next.So resending the driver patch.
> 
> This patch is compiled and tested against mmc/next.
> 
>  drivers/mmc/host/renesas_sdhi_sys_dmac.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c 
> b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> index 160fbb2..df44654 100644
> --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> @@ -98,6 +98,8 @@
>   { .compatible = "renesas,sdhi-r7s72100", .data = &of_rz_compatible, },
>   { .compatible = "renesas,sdhi-r8a7778", .data = 
> &of_rcar_gen1_compatible, },
>   { .compatible = "renesas,sdhi-r8a7779", .data = 
> &of_rcar_gen1_compatible, },
> + { .compatible = "renesas,sdhi-r8a7743", .data = 
> &of_rcar_gen2_compatible, },
> + { .compatible = "renesas,sdhi-r8a7745", .data = 
> &of_rcar_gen2_compatible, },
>   { .compatible = "renesas,sdhi-r8a7790", .data = 
> &of_rcar_gen2_compatible, },
>   { .compatible = "renesas,sdhi-r8a7791", .data = 
> &of_rcar_gen2_compatible, },
>   { .compatible = "renesas,sdhi-r8a7792", .data = 
> &of_rcar_gen2_compatible, },
> -- 
> 1.9.1
>

Re: [PATCH RESEND] mmc: renesas_sdhi: Add r8a7743/5 support

2017-08-30 Thread Simon Horman 
On Tue, Aug 29, 2017 at 03:05:53PM +, Chris Paterson wrote:
> 
> 
> > From: Wolfram Sang [mailto:w...@the-dreams.de]
> > Sent: 29 August 2017 15:59
> > 
> > On Tue, Aug 29, 2017 at 02:52:06PM +0100, Biju Das wrote:
> > > Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI is
> > > identical to the R-Car Gen2 family.
> > >
> > > Signed-off-by: Biju Das 
> > > ---
> > > DT binding patch for r8a7743/5 SoC is applied for mmc next. But the
> > > driver patch is still not applied for mmc next.So resending the driver 
> > > patch.
> > 
> > Didn't Chris Paterson volunteer to write a new patch introducing Gen2 
> > generic
> > compatibles? Or did I misunderstand?
> 
> I did :)
> 
> But after some off-ML discussion with Geert/Simon I decided to leave it to 
> Simon as he's been doing a lot of similar work for all of the R-Car related 
> drivers.
> 
> This may not happen immediately, and we already have the bindings/DT patches 
> accepted based on this patch, hence the repost.
> 
> Sorry for the confusion!

I confirm the above conversation.

In my experience rolling out fallback compat strings takes time as there
are often unexpected complications. Perhaps that is not the case here but
in my opinion it would be better if support for these new SoCs didn't have
an extra dependency. After all the goal of the fallback compat strings is
to make adding new SoCs easier not harder.

Re: [PATCH RESEND] mmc: renesas_sdhi: Add r8a7743/5 support

2017-09-01 Thread Ulf Hansson 
On 29 August 2017 at 15:52, Biju Das  wrote:
> Add support for r8a7743/5 SoC.Renesas RZ/G1[ME] (R8A7743/5) SDHI
> is identical to the R-Car Gen2 family.
>
> Signed-off-by: Biju Das 

Thanks, applied for next!

Kind regards
Uffe

> ---
> DT binding patch for r8a7743/5 SoC is applied for mmc next. But the driver 
> patch
> is still not applied for mmc next.So resending the driver patch.
>
> This patch is compiled and tested against mmc/next.
>
>  drivers/mmc/host/renesas_sdhi_sys_dmac.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c 
> b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> index 160fbb2..df44654 100644
> --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c
> @@ -98,6 +98,8 @@
> { .compatible = "renesas,sdhi-r7s72100", .data = &of_rz_compatible, },
> { .compatible = "renesas,sdhi-r8a7778", .data = 
> &of_rcar_gen1_compatible, },
> { .compatible = "renesas,sdhi-r8a7779", .data = 
> &of_rcar_gen1_compatible, },
> +   { .compatible = "renesas,sdhi-r8a7743", .data = 
> &of_rcar_gen2_compatible, },
> +   { .compatible = "renesas,sdhi-r8a7745", .data = 
> &of_rcar_gen2_compatible, },
> { .compatible = "renesas,sdhi-r8a7790", .data = 
> &of_rcar_gen2_compatible, },
> { .compatible = "renesas,sdhi-r8a7791", .data = 
> &of_rcar_gen2_compatible, },
> { .compatible = "renesas,sdhi-r8a7792", .data = 
> &of_rcar_gen2_compatible, },
> --
> 1.9.1
>