Re: [PATCH v2] arm64: dts: ulcb-kf: enable USB2 PHY of channel 0
On Wed, Nov 15, 2017 at 05:36:21PM +0100, Geert Uytterhoeven wrote: > Hi Vladimir, > > On Wed, Nov 8, 2017 at 1:21 PM, Vladimir Barinov > wrote: > > This supports USB2 PHY channel #0 on ULCB Kingfisher board > > > > The dedicated USB0_PWEN pin is used to control CN13 VBUS source from U43 > > power supply. > > MAX3355 can also provide VBUS, hence it should be disabled via OTG_OFFVBUSn > > node coming from gpio expander TCA9539. > > Set MAX3355 enabled using OTG_EXTLPn node to be able to read OTG ID of CN13. I took the liberty of line-wrapping the line above to keep it from going over 75 characters wide to keep checkpatch happy. > > > > Signed-off-by: Vladimir Barinov > > --- > > Changes in version 2: > > - added gpio hogs for MAX3355 VBUS and SHDN > > Thanks for the update! > > Reviewed-by: Geert Uytterhoeven Thanks, applied.
Re: [PATCH v2] arm64: dts: ulcb-kf: enable USB2 PHY of channel 0
Hi Vladimir, On Wed, Nov 8, 2017 at 1:21 PM, Vladimir Barinov wrote: > This supports USB2 PHY channel #0 on ULCB Kingfisher board > > The dedicated USB0_PWEN pin is used to control CN13 VBUS source from U43 > power supply. > MAX3355 can also provide VBUS, hence it should be disabled via OTG_OFFVBUSn > node coming from gpio expander TCA9539. > Set MAX3355 enabled using OTG_EXTLPn node to be able to read OTG ID of CN13. > > Signed-off-by: Vladimir Barinov > --- > Changes in version 2: > - added gpio hogs for MAX3355 VBUS and SHDN Thanks for the update! Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
[PATCH v2] arm64: dts: ulcb-kf: enable USB2 PHY of channel 0
This supports USB2 PHY channel #0 on ULCB Kingfisher board The dedicated USB0_PWEN pin is used to control CN13 VBUS source from U43 power supply. MAX3355 can also provide VBUS, hence it should be disabled via OTG_OFFVBUSn node coming from gpio expander TCA9539. Set MAX3355 enabled using OTG_EXTLPn node to be able to read OTG ID of CN13. Signed-off-by: Vladimir Barinov --- Changes in version 2: - added gpio hogs for MAX3355 VBUS and SHDN arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi index 657ad10..48a2e8f 100644 --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi @@ -67,6 +67,20 @@ output-high; line-name = "HUB rst"; }; + + otg_offvbusn { + gpio-hog; + gpios = <8 GPIO_ACTIVE_HIGH>; + output-low; + line-name = "OTG OFFVBUSn"; + }; + + otg_extlpn { + gpio-hog; + gpios = <9 GPIO_ACTIVE_HIGH>; + output-high; + line-name = "OTG EXTLPn"; + }; }; gpio_exp_75: gpio@75 { @@ -154,6 +168,11 @@ groups = "scif1_data_b", "scif1_ctrl"; function = "scif1"; }; + + usb0_pins: usb0 { + groups = "usb0"; + function = "usb0"; + }; }; &scif1 { @@ -164,6 +183,13 @@ status = "okay"; }; +&usb2_phy0 { + pinctrl-0 = <&usb0_pins>; + pinctrl-names = "default"; + + status = "okay"; +}; + &xhci0 { status = "okay"; }; -- 1.9.1