Re: [PATCH v2] mmc: document 'Reliable Write' bit in uapi header
On Mon, 3 Dec 2018 at 20:56, Wolfram Sang
wrote:
>
> If we use it this way, people should know about it. Also, replace
> true/false with nonzero/zero because the flag is not strictly a bool
> anymore.
>
> Signed-off-by: Wolfram Sang
> Reviewed-by: Geert Uytterhoeven
Applied for next, thanks!
Kind regards
Uffe
> ---
>
> Change since V1:
> * reworded first line of comment as well. Thanks, Geert!
>
> Still not super happy about shifting into the sign bit, but yeah...
> don't break userspace, I guess.
>
> include/uapi/linux/mmc/ioctl.h | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/mmc/ioctl.h b/include/uapi/linux/mmc/ioctl.h
> index 45f369dc0a42..00c08120f3ba 100644
> --- a/include/uapi/linux/mmc/ioctl.h
> +++ b/include/uapi/linux/mmc/ioctl.h
> @@ -5,7 +5,10 @@
> #include
>
> struct mmc_ioc_cmd {
> - /* Implies direction of data. true = write, false = read */
> + /*
> +* Direction of data: nonzero = write, zero = read.
> +* Bit 31 selects 'Reliable Write' for RPMB.
> +*/
> int write_flag;
>
> /* Application-specific command. true = precede with CMD55 */
> --
> 2.11.0
>
[PATCH v2] mmc: document 'Reliable Write' bit in uapi header
If we use it this way, people should know about it. Also, replace
true/false with nonzero/zero because the flag is not strictly a bool
anymore.
Signed-off-by: Wolfram Sang
Reviewed-by: Geert Uytterhoeven
---
Change since V1:
* reworded first line of comment as well. Thanks, Geert!
Still not super happy about shifting into the sign bit, but yeah...
don't break userspace, I guess.
include/uapi/linux/mmc/ioctl.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/mmc/ioctl.h b/include/uapi/linux/mmc/ioctl.h
index 45f369dc0a42..00c08120f3ba 100644
--- a/include/uapi/linux/mmc/ioctl.h
+++ b/include/uapi/linux/mmc/ioctl.h
@@ -5,7 +5,10 @@
#include
struct mmc_ioc_cmd {
- /* Implies direction of data. true = write, false = read */
+ /*
+* Direction of data: nonzero = write, zero = read.
+* Bit 31 selects 'Reliable Write' for RPMB.
+*/
int write_flag;
/* Application-specific command. true = precede with CMD55 */
--
2.11.0
