Re: [PATCH v2 6/8] arm64: dts: r8a7795: salvator-x: Add panel backlight support

[Simon Horman]

On Thu, Apr 27, 2017 at 05:43:35PM +0300, Laurent Pinchart wrote:
> On Thursday 27 Apr 2017 17:42:53 Laurent Pinchart wrote:
> > On Thursday 27 Apr 2017 16:37:41 Ulrich Hecht wrote:
> > > From: Laurent Pinchart 
> > > 
> > > The panel backlight is controlled through a GPIO and a PWM channel.
> > > 
> > > Signed-off-by: Laurent Pinchart
> > > 
> > 
> > Reviewed-by: Laurent Pinchart 
> 
> Please ignore this, I meant to reply to the M3-W patch.

Thanks, noted.

Re: [PATCH v2 6/8] arm64: dts: r8a7795: salvator-x: Add panel backlight support

[Laurent Pinchart]

On Thursday 27 Apr 2017 17:42:53 Laurent Pinchart wrote:
> On Thursday 27 Apr 2017 16:37:41 Ulrich Hecht wrote:
> > From: Laurent Pinchart 
> > 
> > The panel backlight is controlled through a GPIO and a PWM channel.
> > 
> > Signed-off-by: Laurent Pinchart
> > 
> 
> Reviewed-by: Laurent Pinchart 

Please ignore this, I meant to reply to the M3-W patch.

> 
> > ---
> > 
> >  arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 22 +
> >  1 file changed, 22 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> > b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts index
> > bf4674e..8558b27
> > 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> > +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> > @@ -280,6 +280,16 @@
> > 
> > };
> > 
> > };
> > 
> > };
> > 
> > +
> > +   backlight: backlight {
> > +   compatible = "pwm-backlight";
> > +   pwms = < 0 5>;
> > +
> > +   brightness-levels = <256 128 64 16 8 4 0>;
> > +   default-brightness-level = <6>;
> > +
> > +   enable-gpios = < 7 GPIO_ACTIVE_HIGH>;
> > +   };
> > 
> >  };
> >  
> >   {
> > 
> > @@ -366,6 +376,11 @@
> > 
> > function = "du";
> > 
> > };
> > 
> > +   pwm1_pins: pwm {
> > +   groups = "pwm1_a";
> > +   function = "pwm1";
> > +   };
> > +
> > 
> > sdhi0_pins: sd0 {
> > 
> > groups = "sdhi0_data4", "sdhi0_ctrl";
> > function = "sdhi0";
> > 
> > @@ -441,6 +456,13 @@
> > 
> > };
> >  
> >  };
> > 
> > + {
> > +   pinctrl-0 = <_pins>;
> > +   pinctrl-names = "default";
> > +
> > +   status = "okay";
> > +};
> > +
> > 
> >   {
> >  
> > pinctrl-0 = <_pins>;
> > pinctrl-names = "default";

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 6/8] arm64: dts: r8a7795: salvator-x: Add panel backlight support

[Laurent Pinchart]

Hi Ulrich,

Thank you for the patch.

On Thursday 27 Apr 2017 16:37:41 Ulrich Hecht wrote:
> From: Laurent Pinchart 
> 
> The panel backlight is controlled through a GPIO and a PWM channel.
> 
> Signed-off-by: Laurent Pinchart 

Reviewed-by: Laurent Pinchart 

> ---
>  arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 22 +++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts index bf4674e..8558b27
> 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
> @@ -280,6 +280,16 @@
>   };
>   };
>   };
> +
> + backlight: backlight {
> + compatible = "pwm-backlight";
> + pwms = < 0 5>;
> +
> + brightness-levels = <256 128 64 16 8 4 0>;
> + default-brightness-level = <6>;
> +
> + enable-gpios = < 7 GPIO_ACTIVE_HIGH>;
> + };
>  };
> 
>   {
> @@ -366,6 +376,11 @@
>   function = "du";
>   };
> 
> + pwm1_pins: pwm {
> + groups = "pwm1_a";
> + function = "pwm1";
> + };
> +
>   sdhi0_pins: sd0 {
>   groups = "sdhi0_data4", "sdhi0_ctrl";
>   function = "sdhi0";
> @@ -441,6 +456,13 @@
>   };
>  };
> 
> + {
> + pinctrl-0 = <_pins>;
> + pinctrl-names = "default";
> +
> + status = "okay";
> +};
> +
>   {
>   pinctrl-0 = <_pins>;
>   pinctrl-names = "default";

-- 
Regards,

Laurent Pinchart

[PATCH v2 6/8] arm64: dts: r8a7795: salvator-x: Add panel backlight support

[Ulrich Hecht]

From: Laurent Pinchart 

The panel backlight is controlled through a GPIO and a PWM channel.

Signed-off-by: Laurent Pinchart 
---
 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 22 ++
 1 file changed, 22 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts 
b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
index bf4674e..8558b27 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
@@ -280,6 +280,16 @@
};
};
};
+
+   backlight: backlight {
+   compatible = "pwm-backlight";
+   pwms = < 0 5>;
+
+   brightness-levels = <256 128 64 16 8 4 0>;
+   default-brightness-level = <6>;
+
+   enable-gpios = < 7 GPIO_ACTIVE_HIGH>;
+   };
 };
 
  {
@@ -366,6 +376,11 @@
function = "du";
};
 
+   pwm1_pins: pwm {
+   groups = "pwm1_a";
+   function = "pwm1";
+   };
+
sdhi0_pins: sd0 {
groups = "sdhi0_data4", "sdhi0_ctrl";
function = "sdhi0";
@@ -441,6 +456,13 @@
};
 };
 
+ {
+   pinctrl-0 = <_pins>;
+   pinctrl-names = "default";
+
+   status = "okay";
+};
+
  {
pinctrl-0 = <_pins>;
pinctrl-names = "default";
-- 
2.7.4