Re: [PATCHv2 2/5] sh_eth: enable wake-on-lan for Gen2 devices

2016-12-17 Thread Sergei Shtylyov 

On 12/14/2016 04:37 PM, Sergei Shtylyov wrote:


Tested on Gen2 r8a7791/Koelsch.

Signed-off-by: Niklas Söderlund 
---
 drivers/net/ethernet/renesas/sh_eth.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/renesas/sh_eth.c
b/drivers/net/ethernet/renesas/sh_eth.c
index 87640b9..348ed22 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -624,8 +624,9 @@ static struct sh_eth_cpu_data r8a779x_data = {

 .register_type= SH_ETH_REG_FAST_RCAR,

-.ecsr_value= ECSR_PSRTO | ECSR_LCHNG | ECSR_ICD,
-.ecsipr_value= ECSIPR_PSRTOIP | ECSIPR_LCHNGIP | ECSIPR_ICDIP,
+.ecsr_value= ECSR_PSRTO | ECSR_LCHNG | ECSR_ICD | ECSR_MPD,
+.ecsipr_value= ECSIPR_PSRTOIP | ECSIPR_LCHNGIP | ECSIPR_ICDIP |
+  ECSIPR_MPDIP,


  These expressions seem to have been sorted by the bit # before your patch,
now they aren't... care to fix? :-)


   After looking at the SH7743/64 code, nevermind this request. Sorry. :-)

MBR, Sergei

Re: [PATCHv2 2/5] sh_eth: enable wake-on-lan for Gen2 devices

2016-12-14 Thread Sergei Shtylyov 

Hello!

   You forgot "R-Car" before "Gen2" in the subject.

On 12/12/2016 07:09 PM, Niklas Söderlund wrote:


Tested on Gen2 r8a7791/Koelsch.

Signed-off-by: Niklas Söderlund 
---
 drivers/net/ethernet/renesas/sh_eth.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/renesas/sh_eth.c 
b/drivers/net/ethernet/renesas/sh_eth.c
index 87640b9..348ed22 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -624,8 +624,9 @@ static struct sh_eth_cpu_data r8a779x_data = {

.register_type  = SH_ETH_REG_FAST_RCAR,

-   .ecsr_value = ECSR_PSRTO | ECSR_LCHNG | ECSR_ICD,
-   .ecsipr_value   = ECSIPR_PSRTOIP | ECSIPR_LCHNGIP | ECSIPR_ICDIP,
+   .ecsr_value = ECSR_PSRTO | ECSR_LCHNG | ECSR_ICD | ECSR_MPD,
+   .ecsipr_value   = ECSIPR_PSRTOIP | ECSIPR_LCHNGIP | ECSIPR_ICDIP |
+ ECSIPR_MPDIP,


  These expressions seem to have been sorted by the bit # before your patch, 
now they aren't... care to fix? :-)


[...]

MBR, Sergei

Re: [PATCHv2 2/5] sh_eth: enable wake-on-lan for Gen2 devices

2016-12-13 Thread Geert Uytterhoeven 
On Mon, Dec 12, 2016 at 5:09 PM, Niklas Söderlund
 wrote:
> Tested on Gen2 r8a7791/Koelsch.
>
> Signed-off-by: Niklas Söderlund 

Tested-by: Geert Uytterhoeven 

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCHv2 2/5] sh_eth: enable wake-on-lan for Gen2 devices

2016-12-12 Thread Niklas Söderlund 
Tested on Gen2 r8a7791/Koelsch.

Signed-off-by: Niklas Söderlund 
---
 drivers/net/ethernet/renesas/sh_eth.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/renesas/sh_eth.c 
b/drivers/net/ethernet/renesas/sh_eth.c
index 87640b9..348ed22 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -624,8 +624,9 @@ static struct sh_eth_cpu_data r8a779x_data = {
 
.register_type  = SH_ETH_REG_FAST_RCAR,
 
-   .ecsr_value = ECSR_PSRTO | ECSR_LCHNG | ECSR_ICD,
-   .ecsipr_value   = ECSIPR_PSRTOIP | ECSIPR_LCHNGIP | ECSIPR_ICDIP,
+   .ecsr_value = ECSR_PSRTO | ECSR_LCHNG | ECSR_ICD | ECSR_MPD,
+   .ecsipr_value   = ECSIPR_PSRTOIP | ECSIPR_LCHNGIP | ECSIPR_ICDIP |
+ ECSIPR_MPDIP,
.eesipr_value   = 0x01ff009f,
 
.tx_check   = EESR_FTC | EESR_CND | EESR_DLC | EESR_CD | EESR_RTO,
@@ -641,6 +642,7 @@ static struct sh_eth_cpu_data r8a779x_data = {
.tpauser= 1,
.hw_swap= 1,
.rmiimode   = 1,
+   .magic  = 1,
 };
 #endif /* CONFIG_OF */
 
-- 
2.10.2