Re: [RFC v2 6/6] ARM: dts: blanche: add SCIF1 and MAX9260 deserializer

[Laurent Pinchart]

Hi Ulrich,

Thank you for the patch.

On Monday 17 Jul 2017 17:24:36 Ulrich Hecht wrote:
> Adds serial port SCIF1 and the MAX9260 deserializers connected to it.
> 
> Signed-off-by: Ulrich Hecht 
> ---
>  arch/arm/boot/dts/r8a7792-blanche.dts | 52 +++

You're probably aware of this already, but you need to document the DT 
bindings :-)

>  1 file changed, 52 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7792-blanche.dts
> b/arch/arm/boot/dts/r8a7792-blanche.dts index 9b67dca..2ae9a87 100644
> --- a/arch/arm/boot/dts/r8a7792-blanche.dts
> +++ b/arch/arm/boot/dts/r8a7792-blanche.dts
> @@ -21,6 +21,7 @@
>   aliases {
>   serial0 = 
>   serial1 = 
> + serial2 = 
>   };
> 
>   chosen {
> @@ -186,6 +187,16 @@
>   gpio = < 12 GPIO_ACTIVE_HIGH>;
>   enable-active-high;
>   };
> +
> + mux: mux-controller {
> + compatible = "gpio-mux";
> + #mux-control-cells = <0>;
> +
> + mux-gpios = < 12 GPIO_ACTIVE_HIGH>,
> + < 13 GPIO_ACTIVE_HIGH>,
> + < 14 GPIO_ACTIVE_HIGH>,
> + < 15 GPIO_ACTIVE_HIGH>;
> + };
>  };
> 
>  _clk {
> @@ -202,6 +213,11 @@
>   function = "scif0";
>   };
> 
> + scif1_pins: scif1 {
> + groups = "scif1_data";
> + function = "scif1";
> + };
> +
>   scif3_pins: scif3 {
>   groups = "scif3_data";
>   function = "scif3";
> @@ -246,6 +262,42 @@
>   status = "okay";
>  };
> 
> + {
> + pinctrl-0 = <_pins>;
> + pinctrl-names = "default";
> +
> + status = "okay";
> +
> + mux-controls = <>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> + gmsl-deserializer@0 {
> + compatible = "maxim,max9260";
> + reg = <0x8>;
> + };
> + gmsl-deserializer@1 {
> + compatible = "maxim,max9260";
> + reg = <0x9>;
> + };
> + gmsl-deserializer@2 {
> + compatible = "maxim,max9260";
> + reg = <0xa>;
> + };
> + gmsl-deserializer@3 {
> + compatible = "maxim,max9260";
> + reg = <0xb>;
> + };
> + gmsl-deserializer@4 {
> + compatible = "maxim,max9260";
> + reg = <0x4>;
> + };
> + gmsl-deserializer@5 {
> + compatible = "maxim,max9260";
> + reg = <0x5>;
> + };
> +};
> +
>   {
>   pinctrl-0 = <_pins>;
>   pinctrl-names = "default";

-- 
Regards,

Laurent Pinchart

Re: [RFC v2 6/6] ARM: dts: blanche: add SCIF1 and MAX9260 deserializer

[Geert Uytterhoeven]

Hi Uli,

On Mon, Jul 17, 2017 at 5:24 PM, Ulrich Hecht
 wrote:
> Adds serial port SCIF1 and the MAX9260 deserializers connected to it.
>
> Signed-off-by: Ulrich Hecht 

Thanks for your patch!

>  arch/arm/boot/dts/r8a7792-blanche.dts | 52 
> +++
>  1 file changed, 52 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7792-blanche.dts 
> b/arch/arm/boot/dts/r8a7792-blanche.dts
> index 9b67dca..2ae9a87 100644
> --- a/arch/arm/boot/dts/r8a7792-blanche.dts
> +++ b/arch/arm/boot/dts/r8a7792-blanche.dts

> status = "okay";
>  };
>
> + {
> +   pinctrl-0 = <_pins>;
> +   pinctrl-names = "default";
> +
> +   status = "okay";
> +
> +   mux-controls = <>;
> +
> +   #address-cells = <1>;
> +   #size-cells = <0>;
> +   gmsl-deserializer@0 {
> +   compatible = "maxim,max9260";
> +   reg = <0x8>;

unit address and reg property don't match.

(try "make dtbs W=1")

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[RFC v2 6/6] ARM: dts: blanche: add SCIF1 and MAX9260 deserializer

[Ulrich Hecht]

Adds serial port SCIF1 and the MAX9260 deserializers connected to it.

Signed-off-by: Ulrich Hecht 
---
 arch/arm/boot/dts/r8a7792-blanche.dts | 52 +++
 1 file changed, 52 insertions(+)

diff --git a/arch/arm/boot/dts/r8a7792-blanche.dts 
b/arch/arm/boot/dts/r8a7792-blanche.dts
index 9b67dca..2ae9a87 100644
--- a/arch/arm/boot/dts/r8a7792-blanche.dts
+++ b/arch/arm/boot/dts/r8a7792-blanche.dts
@@ -21,6 +21,7 @@
aliases {
serial0 = 
serial1 = 
+   serial2 = 
};
 
chosen {
@@ -186,6 +187,16 @@
gpio = < 12 GPIO_ACTIVE_HIGH>;
enable-active-high;
};
+
+   mux: mux-controller {
+   compatible = "gpio-mux";
+   #mux-control-cells = <0>;
+
+   mux-gpios = < 12 GPIO_ACTIVE_HIGH>,
+   < 13 GPIO_ACTIVE_HIGH>,
+   < 14 GPIO_ACTIVE_HIGH>,
+   < 15 GPIO_ACTIVE_HIGH>;
+   };
 };
 
 _clk {
@@ -202,6 +213,11 @@
function = "scif0";
};
 
+   scif1_pins: scif1 {
+   groups = "scif1_data";
+   function = "scif1";
+   };
+
scif3_pins: scif3 {
groups = "scif3_data";
function = "scif3";
@@ -246,6 +262,42 @@
status = "okay";
 };
 
+ {
+   pinctrl-0 = <_pins>;
+   pinctrl-names = "default";
+
+   status = "okay";
+
+   mux-controls = <>;
+
+   #address-cells = <1>;
+   #size-cells = <0>;
+   gmsl-deserializer@0 {
+   compatible = "maxim,max9260";
+   reg = <0x8>;
+   };
+   gmsl-deserializer@1 {
+   compatible = "maxim,max9260";
+   reg = <0x9>;
+   };
+   gmsl-deserializer@2 {
+   compatible = "maxim,max9260";
+   reg = <0xa>;
+   };
+   gmsl-deserializer@3 {
+   compatible = "maxim,max9260";
+   reg = <0xb>;
+   };
+   gmsl-deserializer@4 {
+   compatible = "maxim,max9260";
+   reg = <0x4>;
+   };
+   gmsl-deserializer@5 {
+   compatible = "maxim,max9260";
+   reg = <0x5>;
+   };
+};
+
  {
pinctrl-0 = <_pins>;
pinctrl-names = "default";
-- 
2.7.4