Re: [PATCH 4/4] soc: renesas: rcar-rst: Add support for R-Car E3
On Thu, Apr 12, 2018 at 08:11:22AM +, Yoshihiro Shimoda wrote: > Hi Simon-san, > > > From: Simon Horman, Sent: Thursday, April 12, 2018 4:55 PM > > > > On Wed, Apr 11, 2018 at 05:18:28PM +0200, Geert Uytterhoeven wrote: > > > Hi Shimoda-san, > > > > > > Thanks for your patch! > > > > > > On Wed, Apr 11, 2018 at 11:36 AM, Yoshihiro Shimoda > > > wrote: > > > > From: Takeshi Kihara > > > > > > > > This patch adds definition of reset vector for the R8A77990 SoC. > > > > > > The description doesn't seem to match what the patch does? > > > > How about this text, based on Sergei's test for the R8a77980? > > > > Add support for R-Car E3 (R8A77990) to the R-Car RST driver. > > This driver is needed for the clock driver to work. > > It's good to me. So, should I submit v2 patch? No need, I have applied the patch with the changelog text above.
RE: [PATCH 4/4] soc: renesas: rcar-rst: Add support for R-Car E3
Hi Simon-san, > From: Simon Horman, Sent: Thursday, April 12, 2018 4:55 PM > > On Wed, Apr 11, 2018 at 05:18:28PM +0200, Geert Uytterhoeven wrote: > > Hi Shimoda-san, > > > > Thanks for your patch! > > > > On Wed, Apr 11, 2018 at 11:36 AM, Yoshihiro Shimoda > > wrote: > > > From: Takeshi Kihara > > > > > > This patch adds definition of reset vector for the R8A77990 SoC. > > > > The description doesn't seem to match what the patch does? > > How about this text, based on Sergei's test for the R8a77980? > > Add support for R-Car E3 (R8A77990) to the R-Car RST driver. > This driver is needed for the clock driver to work. It's good to me. So, should I submit v2 patch? Best regards, Yoshihiro Shimoda > > > Signed-off-by: Takeshi Kihara > > > [shimoda: rebase] > > > Signed-off-by: Yoshihiro Shimoda > > > > The actual patch contents are fine, so: > > Reviewed-by: Geert Uytterhoeven > > > > Gr{oetje,eeting}s, > > > > Geert > > > > -- > > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > > ge...@linux-m68k.org > > > > In personal conversations with technical people, I call myself a hacker. But > > when I'm talking to journalists I just say "programmer" or something like > > that. > > -- Linus Torvalds > >
Re: [PATCH 4/4] soc: renesas: rcar-rst: Add support for R-Car E3
On Wed, Apr 11, 2018 at 05:18:28PM +0200, Geert Uytterhoeven wrote: > Hi Shimoda-san, > > Thanks for your patch! > > On Wed, Apr 11, 2018 at 11:36 AM, Yoshihiro Shimoda > wrote: > > From: Takeshi Kihara > > > > This patch adds definition of reset vector for the R8A77990 SoC. > > The description doesn't seem to match what the patch does? How about this text, based on Sergei's test for the R8a77980? Add support for R-Car E3 (R8A77990) to the R-Car RST driver. This driver is needed for the clock driver to work. > > Signed-off-by: Takeshi Kihara > > [shimoda: rebase] > > Signed-off-by: Yoshihiro Shimoda > > The actual patch contents are fine, so: > Reviewed-by: Geert Uytterhoeven > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > ge...@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like > that. > -- Linus Torvalds >
Re: [PATCH 4/4] soc: renesas: rcar-rst: Add support for R-Car E3
Hi Shimoda-san, Thanks for your patch! On Wed, Apr 11, 2018 at 11:36 AM, Yoshihiro Shimoda wrote: > From: Takeshi Kihara > > This patch adds definition of reset vector for the R8A77990 SoC. The description doesn't seem to match what the patch does? > Signed-off-by: Takeshi Kihara > [shimoda: rebase] > Signed-off-by: Yoshihiro Shimoda The actual patch contents are fine, so: Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds