RE: [PATCH v2] ARM: dts: iwg22d: Enable SDHI0 controller

[Chris Paterson]

Hello Simon,

> From: Simon Horman [mailto:ho...@verge.net.au]
> Sent: 25 September 2017 08:18
> 
> On Fri, Sep 22, 2017 at 01:33:39PM +, Fabrizio Castro wrote:
> > Hello Simon,
> >
> > just to clarify the changes between v1 and v2, we can't use SDR50 and
> SDR104 (due to an HW issue) therefore the pinctrl for UHS has been
> removed and we dropped property "sd-uhs-sdr104". High Speed has been
> tested, therefore if you are happy with the patch I guess you can update the
> following page accordingly:
> > http://elinux.org/index.php?title=Renesas-MMC-Enabled-
> Speeds=revi
> > sion=451426=451421
> >
> > Although (due to a bug) sdhi0 may not hold a reference to "vccq_sdhi0",
> the gpio regulator will initialize "SDHI0 VccQ" at 3.3V.
> > I have sent another patch (mmc: tmio: check mmc_regulator_get_supply
> return value) to start a discussion about a possible fix for the bug.
> >
> > Let me know if you need more information.
> 
> Thanks again for following up on this.
> 
> I have applied the patch with Geert's tag.

Thanks

> 
> I have also updated the Wiki at the URL above, feel free to make any further
> updates there as appropriate.

Thanks, looks okay to me.

Kind regards, Chris

Re: [PATCH v2] ARM: dts: iwg22d: Enable SDHI0 controller

[Simon Horman]

On Fri, Sep 22, 2017 at 01:33:39PM +, Fabrizio Castro wrote:
> Hello Simon,
> 
> just to clarify the changes between v1 and v2, we can't use SDR50 and SDR104 
> (due to an HW issue) therefore the pinctrl for UHS has been removed and we 
> dropped property "sd-uhs-sdr104". High Speed has been tested, therefore if 
> you are happy with the patch I guess you can update the following page 
> accordingly:
> http://elinux.org/index.php?title=Renesas-MMC-Enabled-Speeds=revision=451426=451421
> 
> Although (due to a bug) sdhi0 may not hold a reference to "vccq_sdhi0", the 
> gpio regulator will initialize "SDHI0 VccQ" at 3.3V.
> I have sent another patch (mmc: tmio: check mmc_regulator_get_supply return 
> value) to start a discussion about a possible fix for the bug.
> 
> Let me know if you need more information.

Thanks again for following up on this.

I have applied the patch with Geert's tag.

I have also updated the Wiki at the URL above,
feel free to make any further updates there as appropriate.

Re: [PATCH v2] ARM: dts: iwg22d: Enable SDHI0 controller

[Geert Uytterhoeven]

On Fri, Sep 22, 2017 at 3:01 PM, Fabrizio Castro
 wrote:
> Enable the SDHI0 controller on iWave RZ/G1E carrier board.
>
> Signed-off-by: Fabrizio Castro 
> Signed-off-by: Chris Paterson 

Reviewed-by: Geert Uytterhoeven 

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

RE: [PATCH v2] ARM: dts: iwg22d: Enable SDHI0 controller

[Fabrizio Castro]

Hello Simon,

just to clarify the changes between v1 and v2, we can't use SDR50 and SDR104 
(due to an HW issue) therefore the pinctrl for UHS has been removed and we 
dropped property "sd-uhs-sdr104". High Speed has been tested, therefore if you 
are happy with the patch I guess you can update the following page accordingly:
http://elinux.org/index.php?title=Renesas-MMC-Enabled-Speeds=revision=451426=451421

Although (due to a bug) sdhi0 may not hold a reference to "vccq_sdhi0", the 
gpio regulator will initialize "SDHI0 VccQ" at 3.3V.
I have sent another patch (mmc: tmio: check mmc_regulator_get_supply return 
value) to start a discussion about a possible fix for the bug.

Let me know if you need more information.

Thanks,
Fabrizio

> -Original Message-
> From: linux-renesas-soc-ow...@vger.kernel.org 
> [mailto:linux-renesas-soc-ow...@vger.kernel.org] On Behalf Of Fabrizio Castro
> Sent: 22 September 2017 14:01
> To: Simon Horman 
> Cc: Rob Herring ; Mark Rutland ; 
> Magnus Damm ;
> Russell King ; Chris Paterson 
> ; Fabrizio Castro
> ; Biju Das ; 
> devicet...@vger.kernel.org; linux-renesas-
> s...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; Chris Paterson 
> 
> Subject: [PATCH v2] ARM: dts: iwg22d: Enable SDHI0 controller
>
> Enable the SDHI0 controller on iWave RZ/G1E carrier board.
>
> Signed-off-by: Fabrizio Castro 
> Signed-off-by: Chris Paterson 
> ---
>  arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts | 29 
> +
>  1 file changed, 29 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts 
> b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> index aac84c6..8772c56 100644
> --- a/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> +++ b/arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts
> @@ -24,6 +24,19 @@
>  bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
>  stdout-path = "serial0:115200n8";
>  };
> +
> +vccq_sdhi0: regulator-vccq-sdhi0 {
> +compatible = "regulator-gpio";
> +
> +regulator-name = "SDHI0 VccQ";
> +regulator-min-microvolt = <180>;
> +regulator-max-microvolt = <330>;
> +
> +gpios = < 20 GPIO_ACTIVE_LOW>;
> +gpios-states = <1>;
> +states = <330 1
> +  180 0>;
> +};
>  };
>
>   {
> @@ -36,6 +49,12 @@
>  groups = "avb_mdio", "avb_gmii";
>  function = "avb";
>  };
> +
> +sdhi0_pins: sd0 {
> +groups = "sdhi0_data4", "sdhi0_ctrl";
> +function = "sdhi0";
> +power-source = <3300>;
> +};
>  };
>
>   {
> @@ -63,3 +82,13 @@
>  micrel,led-mode = <1>;
>  };
>  };
> +
> + {
> +pinctrl-0 = <_pins>;
> +pinctrl-names = "default";
> +
> +vmmc-supply = <_3p3v>;
> +vqmmc-supply = <_sdhi0>;
> +cd-gpios = < 6 GPIO_ACTIVE_LOW>;
> +status = "okay";
> +};
> --
> 2.7.4




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, 
Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered 
No. 04586709.