Re: [PATCH] gpiolib: Avoid calling chip->request() for unused gpios

[Linus Walleij]

On Tue, Aug 7, 2018 at 9:21 AM Biju Das  wrote:

> Add a check for unused gpios to avoid chip->request() call to client
> driver for unused gpios.
>
> Signed-off-by: Biju Das 
> Reviewed-by: Fabrizio Castro 

Patch applied with Geert's ACK.

Yours,
Linus Walleij

Re: [PATCH] gpiolib: Avoid calling chip->request() for unused gpios

[Geert Uytterhoeven]

Hi Biju,

Thanks for your patch!

On Tue, Aug 7, 2018 at 9:21 AM Biju Das  wrote:
> Add a check for unused gpios to avoid chip->request() call to client
> driver for unused gpios.

"... so not every driver has to do this in its chip->request() callback."

Note that currently no driver seems to check for this.
I was mistaken in my earlier report about msm_pinmux_request
(this is pinmux_ops.request(), not gpio_chip.request()).

> Signed-off-by: Biju Das 
> Reviewed-by: Fabrizio Castro 

Reviewed-by: Geert Uytterhoeven 

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds