Re: [PATCH] pinctrl: sh-pfc: r8a7794: add EtherAVB pin groups

2016-02-19 Thread Geert Uytterhoeven 
On Thu, Feb 18, 2016 at 8:49 PM, Linus Walleij  wrote:
> On Thu, Feb 18, 2016 at 9:36 AM, Geert Uytterhoeven
>  wrote:
>
>> On Wed, Feb 17, 2016 at 11:32 PM, Sergei Shtylyov
>>  wrote:
>>> Add the EtherAVB pin groups to the R8A7794 PFC driver.
>>>
>>> Based on the patches by Mitsuhiro Kimura .
>>
>> Thank you for your patch!
>>
>>> Signed-off-by: Sergei Shtylyov 
>>
>> Reviewed-by: Geert Uytterhoeven 
>
> I guess this means you're queueing it too?

Indeed.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH] pinctrl: sh-pfc: r8a7794: add EtherAVB pin groups

2016-02-18 Thread Linus Walleij 
On Thu, Feb 18, 2016 at 9:36 AM, Geert Uytterhoeven
 wrote:

> On Wed, Feb 17, 2016 at 11:32 PM, Sergei Shtylyov
>  wrote:
>> Add the EtherAVB pin groups to the R8A7794 PFC driver.
>>
>> Based on the patches by Mitsuhiro Kimura .
>
> Thank you for your patch!
>
>> Signed-off-by: Sergei Shtylyov 
>
> Reviewed-by: Geert Uytterhoeven 

I guess this means you're queueing it too?

Yours,
Linus Walleij

Re: [PATCH] pinctrl: sh-pfc: r8a7794: add EtherAVB pin groups

2016-02-18 Thread Sergei Shtylyov 

Hello.

On 02/18/2016 11:36 AM, Geert Uytterhoeven wrote:


Add the EtherAVB pin groups to the R8A7794 PFC driver.

Based on the patches by Mitsuhiro Kimura .


Thank you for your patch!


Signed-off-by: Sergei Shtylyov 


Reviewed-by: Geert Uytterhoeven 


+static const unsigned int avb_avtp_capture_pins[] = {
+   RCAR_GP_PIN(5, 11),
+};
+static const unsigned int avb_avtp_capture_mux[] = {
+   AVB_AVTP_CAPTURE_MARK,
+};
+static const unsigned int avb_avtp_match_pins[] = {
+   RCAR_GP_PIN(5, 12),
+};
+static const unsigned int avb_avtp_match_mux[] = {
+   AVB_AVTP_MATCH_MARK,
+};
+static const unsigned int avb_avtp_capture_b_pins[] = {
+   RCAR_GP_PIN(1, 1),
+};
+static const unsigned int avb_avtp_capture_b_mux[] = {
+   AVB_AVTP_CAPTURE_B_MARK,
+};
+static const unsigned int avb_avtp_match_b_pins[] = {
+   RCAR_GP_PIN(1, 2),
+};
+static const unsigned int avb_avtp_match_b_mux[] = {
+   AVB_AVTP_MATCH_B_MARK,
+};


BTW, the capture pin seems to be available on R-Car E2 only.


   Yes, I've noticed.


The match pin seems to be available on R-Car E2 and V2H only.


   Don't have V2H manual, have to trust you. :-)


The EtherAVB section in the datasheet doesn't clarify this.
Do you know more?


   Unfortunately, no. I only know what AVTP in the pin name probably stands 
for: Audio/Video Transport Protocol.



Gr{oetje,eeting}s,

 Geert


MBR, Sergei

Re: [PATCH] pinctrl: sh-pfc: r8a7794: add EtherAVB pin groups

2016-02-18 Thread Geert Uytterhoeven 
Hi Sergei,

On Wed, Feb 17, 2016 at 11:32 PM, Sergei Shtylyov
 wrote:
> Add the EtherAVB pin groups to the R8A7794 PFC driver.
>
> Based on the patches by Mitsuhiro Kimura .

Thank you for your patch!

> Signed-off-by: Sergei Shtylyov 

Reviewed-by: Geert Uytterhoeven 

> +static const unsigned int avb_avtp_capture_pins[] = {
> +   RCAR_GP_PIN(5, 11),
> +};
> +static const unsigned int avb_avtp_capture_mux[] = {
> +   AVB_AVTP_CAPTURE_MARK,
> +};
> +static const unsigned int avb_avtp_match_pins[] = {
> +   RCAR_GP_PIN(5, 12),
> +};
> +static const unsigned int avb_avtp_match_mux[] = {
> +   AVB_AVTP_MATCH_MARK,
> +};
> +static const unsigned int avb_avtp_capture_b_pins[] = {
> +   RCAR_GP_PIN(1, 1),
> +};
> +static const unsigned int avb_avtp_capture_b_mux[] = {
> +   AVB_AVTP_CAPTURE_B_MARK,
> +};
> +static const unsigned int avb_avtp_match_b_pins[] = {
> +   RCAR_GP_PIN(1, 2),
> +};
> +static const unsigned int avb_avtp_match_b_mux[] = {
> +   AVB_AVTP_MATCH_B_MARK,
> +};

BTW, the capture pin seems to be available on R-Car E2 only.
The match pin seems to be available on R-Car E2 and V2H only.
The EtherAVB section in the datasheet doesn't clarify this.
Do you know more?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds